libvirt/src
Michal Privoznik a1229335f6 qemu_hotplug: Don't dereference NULL pointer @newb in qemuDomainChangeNet()
In one of my previous commits I've made an attempt to restore the
noqueue qdisc on a TAP corresponding to domain's <interface/> if
QoS is cleared out. The commit consisted of two almost identical
hunks. In both the pointer is dereferenced. But in one of them,
the pointer to new bandwidth can't be NULL while in the other it
can leading to a crash.

Fixes: d53b092353
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1919619
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
2021-02-16 09:05:33 +01:00
..
access access: replace VIR_FREE with g_free in all *Dispose() functions 2021-02-05 00:22:09 -05:00
admin admin: replace VIR_FREE with g_free in all vir*Free() functions 2021-02-05 00:20:44 -05:00
bhyve Replace virStringListJoin by g_strjoinv 2021-02-11 17:05:34 +01:00
conf conf: convert VIR_FREE to g_free in other functions that free their arg 2021-02-12 12:10:38 -05:00
cpu Replace virStringListLength by g_strv_length 2021-02-11 17:05:34 +01:00
cpu_map cpu_map: Remove intel-pt from x86 CPU models 2021-01-26 15:44:50 +01:00
esx esx: replace VIR_FREE with g_free in any ESX_VI__TEMPLATE__FREE 2021-02-12 12:10:38 -05:00
hyperv hypervFreeInvokeParams: Don't use VIR_DISPOSE_N for freeing 'params' 2021-02-03 13:07:12 +01:00
hypervisor hypervisor: replace VIR_FREE with g_free in all *Dispose() functions 2021-02-05 00:22:09 -05:00
interface build: Remove unused 'conflicts' key from virt_daemon_unit 2021-02-10 09:30:41 -07:00
keycodemapdb@27acf0ef82
libxl Replace virStringListJoin by g_strjoinv 2021-02-11 17:05:34 +01:00
locking locking: convert VIR_FREE to g_free in other functions that free their arg 2021-02-12 12:10:38 -05:00
logging logging: replace VIR_FREE with g_free in all *Dispose() functions 2021-02-05 00:22:09 -05:00
lxc Replace virStringSplit with g_strsplit 2021-02-11 17:05:34 +01:00
network build: Remove unused 'conflicts' key from virt_daemon_unit 2021-02-10 09:30:41 -07:00
node_device build: Remove unused 'conflicts' key from virt_daemon_unit 2021-02-10 09:30:41 -07:00
nwfilter build: Remove unused 'conflicts' key from virt_daemon_unit 2021-02-10 09:30:41 -07:00
openvz openvz: convert VIR_FREE to g_free in other functions that free their arg 2021-02-12 12:10:38 -05:00
qemu qemu_hotplug: Don't dereference NULL pointer @newb in qemuDomainChangeNet() 2021-02-16 09:05:33 +01:00
remote remote: convert VIR_FREE to g_free in other functions that free their arg 2021-02-12 12:10:38 -05:00
rpc Replace virStringSplit with g_strsplit 2021-02-11 17:05:34 +01:00
secret build: Remove unused 'conflicts' key from virt_daemon_unit 2021-02-10 09:30:41 -07:00
security security: replace VIR_FREE with g_free in all *Dispose() functions 2021-02-05 00:22:09 -05:00
storage Replace virStringSplit with g_strsplit 2021-02-11 17:05:34 +01:00
storage_file Replace virStringListJoin by g_strjoinv 2021-02-11 17:05:34 +01:00
test test_driver: replace VIR_FREE with g_free in all vir*Free() functions 2021-02-05 00:20:43 -05:00
util vircgroup: correctly free nested virCgroupPtr 2021-02-15 19:21:35 +01:00
vbox build: Remove unused 'conflicts' key from virt_daemon_unit 2021-02-10 09:30:41 -07:00
vmware vmware: convert VIR_FREE to g_free in other functions that free their arg 2021-02-12 12:10:38 -05:00
vmx vmx: replace VIR_FREE with g_free in all vir*Free() functions 2021-02-05 00:20:44 -05:00
vz Replace virStringSplit with g_strsplit 2021-02-11 17:05:34 +01:00
admin_protocol-structs
datatypes.c datatypes: replace VIR_FREE with g_free in all *Dispose() functions 2021-02-05 00:22:09 -05:00
datatypes.h
driver-hypervisor.h src: define virDomainGetMessages API 2021-02-12 09:19:12 +00:00
driver-interface.h
driver-network.h
driver-nodedev.h
driver-nwfilter.h
driver-secret.h
driver-state.h libvirt: add stateShutdownPrepare/stateShutdownWait to drivers 2020-09-07 09:33:58 +03:00
driver-storage.h
driver-stream.h
driver.c log error if virConnectCacheOnceInit() fails 2021-02-02 00:27:27 -05:00
driver.h src: don't hide error in VIR_DRV_SUPPORTS_FEATURE 2021-01-06 17:10:10 +03:00
internal.h internal.h: Introduce and use VIR_IS_POW2() 2020-12-04 16:24:19 +01:00
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_internal.h libvirt: add stateShutdownPrepare/stateShutdownWait to drivers 2020-09-07 09:33:58 +03:00
libvirt_libssh2.syms
libvirt_libssh.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms qemu: implement virDomainGetMessages API 2021-02-12 09:19:13 +00:00
libvirt_probes.d drop libdbus from libvirt 2020-09-17 18:20:33 +02:00
libvirt_public.syms src: define virDomainGetMessages API 2021-02-12 09:19:12 +00:00
libvirt_qemu.syms
libvirt_remote.syms virnetdaemon: Wait for "daemon-stop" thread to finish before quitting 2020-11-24 17:52:54 +01:00
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms vmx: hide private helpers 2020-10-14 11:23:18 +02:00
libvirt-domain-checkpoint.c Fix name prefix of VIR_DOMAIN_CHECKPOINT_REDEFINE_VALIDATE 2020-11-09 16:29:06 +00:00
libvirt-domain-snapshot.c
libvirt-domain.c src: define virDomainGetMessages API 2021-02-12 09:19:12 +00:00
libvirt-host.c src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1 2021-01-06 17:10:01 +03:00
libvirt-interface.c
libvirt-lxc.c use more virStrcpy() and virStrcpyStatic() 2021-01-04 20:18:24 +01:00
libvirt-lxc.pc.in
libvirt-network.c libvirtd: replace straggler VIR_FREE with g_free in all vir*Free() functions 2021-02-05 00:20:45 -05:00
libvirt-nodedev.c virsh: nodedev: filter by AP Matrix capability 2020-12-09 14:03:05 +01:00
libvirt-nwfilter.c
libvirt-qemu.c
libvirt-qemu.pc.in
libvirt-secret.c
libvirt-storage.c libvirt-storage: Document volume upload/download stream format 2020-08-24 13:32:53 +02:00
libvirt-stream.c src: libvirt-stream: use g_new0 instead of VIR_ALLOC* 2020-10-01 12:34:13 +02:00
libvirt.c src: adopt to VIR_DRV_SUPPORTS_FEATURE return -1 2021-01-06 17:10:01 +03:00
libvirt.conf
libvirt.pc.in
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
meson.build build: Remove unused 'conflicts' key from virt_daemon_unit 2021-02-10 09:30:41 -07:00
qemu_protocol-structs
README
remote_protocol-structs remote: add RPC support for the virDomainGetMessages API 2021-02-12 09:19:13 +00:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
The ESX, Hyper-V, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories