libvirt/src/libxl
Daniel P. Berrangé a302480dcb conf: add enum constants for default controller models
The controller model is slightly unusual in that the default value is
-1, not 0. As a result the default value is not covered by any of the
existing enum cases. This in turn means that any switch() statements
that think they have covered all cases, will in fact not match the
default value at all. In the qemuDomainDeviceCalculatePCIConnectFlags()
method this has caused a serious mistake where we fallthrough from the
SCSI controller case, to the VirtioSerial controller case, and from
the USB controller case to the IDE controller case.

By adding explicit enum constant starting at -1, we can ensure switches
remember to handle the default case.

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2018-02-20 14:58:39 +00:00
..
libvirtd_libxl.aug libxl: keepalive messages support 2016-02-09 21:14:12 -07:00
libxl_capabilities.c cpu: Drop unused parameter from cpuDecode 2017-10-16 09:21:52 +02:00
libxl_capabilities.h libxl: implement connectGetDomainCapabilities 2016-06-13 14:13:17 -06:00
libxl_conf.c conf: add enum constants for default controller models 2018-02-20 14:58:39 +00:00
libxl_conf.h libxl: set nestedhvm for mode host-passthrough 2017-04-27 15:05:44 -06:00
libxl_domain.c conf: introduce callback registration for domain net device allocation 2018-02-09 11:05:10 +00:00
libxl_domain.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
libxl_driver.c conf: introduce callback registration for domain net device allocation 2018-02-09 11:05:10 +00:00
libxl_driver.h
libxl_logger.c libxl: define a per-domain logger. 2017-01-11 09:32:47 +01:00
libxl_logger.h libxl: define a per-domain logger. 2017-01-11 09:32:47 +01:00
libxl_migration.c libxl: resume lock process after failed migration 2018-01-25 09:22:14 -07:00
libxl_migration.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
libxl.conf docs: Fix typo deamon -> daemon 2017-09-04 15:07:17 +02:00
test_libvirtd_libxl.aug.in libxl: keepalive messages support 2016-02-09 21:14:12 -07:00