libvirt/tools
Michal Privoznik 6f3f6c0f76 virsh: Make domif-setlink work more than once
In virsh, we have this convenient domif-setlink command, which is
just a wrapper over virDomainUpdateDeviceFlags() and which allows
setting link state of given guest NIC. It does so by fetching
corresponding <interface/> XML snippet and either putting <link
state=''/> into it, OR if the element already exists setting the
attribute to desired value. The XML is then fed into the update
API.

There's, however, a small bug in detecting the pre-existence of
the element and its attribute. The code looks at "link"
attribute, while in fact, the attribute is called "state".

Resolves: https://gitlab.com/libvirt/libvirt/-/issues/426
Fixes: e575bf082e
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-01-30 12:06:41 +01:00
..
bash-completion
nss nss: Compare hostname case insensitive 2022-05-27 13:43:14 +02:00
wireshark meson: Replace meson.source_root() with meson.project_source_root() 2022-10-10 15:06:09 +02:00
libvirt_recover_xattrs.sh
libvirt_win_icon_16x16.ico
libvirt_win_icon_32x32.ico
libvirt_win_icon_48x48.ico
libvirt_win_icon_64x64.ico
libvirt-guests.service.in libvirt-guests: Fix dependency ordering in service file 2022-09-26 13:04:48 +02:00
libvirt-guests.sh.in
meson.build tools: Fix install_mode for some scripts 2022-12-08 09:26:56 +01:00
virsh_win_icon.rc
virsh-backup.c virsh: Require --xpath for *dumpxml 2022-07-25 09:50:21 +02:00
virsh-backup.h
virsh-checkpoint.c virsh: Require --xpath for *dumpxml 2022-07-25 09:50:21 +02:00
virsh-checkpoint.h backup: Implement virsh support for checkpoints 2019-07-26 16:48:58 -05:00
virsh-completer-checkpoint.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer-checkpoint.h
virsh-completer-domain.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer-domain.h
virsh-completer-host.c virsh: Add completer for hypervisor-cpu-baseline --model 2022-10-10 14:31:43 +02:00
virsh-completer-host.h virsh: Add completer for hypervisor-cpu-baseline --model 2022-10-10 14:31:43 +02:00
virsh-completer-interface.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer-interface.h
virsh-completer-network.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer-network.h virsh: Introduce net-update --section completer 2022-01-19 16:48:33 +01:00
virsh-completer-nodedev.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer-nodedev.h
virsh-completer-nwfilter.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer-nwfilter.h
virsh-completer-pool.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer-pool.h
virsh-completer-secret.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer-secret.h
virsh-completer-snapshot.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer-snapshot.h
virsh-completer-volume.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer-volume.h
virsh-completer.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-completer.h
virsh-console.c util: remove virObjectUnref() adapters 2022-07-15 16:44:39 -05:00
virsh-console.h
virsh-domain-event.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
virsh-domain-event.h
virsh-domain-monitor.c Document caveats of 'VIR_DOMAIN_STATS_VM' group of statistics 2022-11-01 11:56:00 +01:00
virsh-domain-monitor.h
virsh-domain.c virsh: Make domif-setlink work more than once 2023-01-30 12:06:41 +01:00
virsh-domain.h
virsh-edit.c
virsh-host.c virsh: Add completer for hypervisor-cpu-baseline --model 2022-10-10 14:31:43 +02:00
virsh-host.h
virsh-interface.c virsh: Require --xpath for *dumpxml 2022-07-25 09:50:21 +02:00
virsh-interface.h
virsh-network.c virsh: Require --xpath for *dumpxml 2022-07-25 09:50:21 +02:00
virsh-network.h
virsh-nodedev.c nodedev: Add VIR_NODE_DEVICE_(CREATE|DEFINE)_XML_VALIDATE flags 2022-11-01 13:07:20 +01:00
virsh-nodedev.h
virsh-nwfilter.c virsh: Require --xpath for *dumpxml 2022-07-25 09:50:21 +02:00
virsh-nwfilter.h
virsh-pool.c virsh: Require --xpath for *dumpxml 2022-07-25 09:50:21 +02:00
virsh-pool.h
virsh-secret.c virsh: Require --xpath for *dumpxml 2022-07-25 09:50:21 +02:00
virsh-secret.h
virsh-snapshot.c virsh: Add message to terminal when running snapshot-revert 2022-12-07 14:33:28 +01:00
virsh-snapshot.h
virsh-util.c virsh: Use proper helper for parsing XML in virshDumpXML 2022-10-06 10:54:25 +02:00
virsh-util.h tools: add helper method for printing an XML document 2022-06-20 10:40:34 +01:00
virsh-volume.c virsh: virshMakeCloneXML: Use virXPathNode instead of xmlXPathEval 2022-12-02 16:49:25 +01:00
virsh-volume.h
virsh.c virsh: Report iSCSI-direct backend in long version 2022-11-24 15:23:47 +01:00
virsh.h virsh: Add --model option for hypervisor-cpu-baseline 2022-10-10 14:31:43 +02:00
virt-admin-completer.c
virt-admin-completer.h
virt-admin.c lib: Use the same style in the 'struct option' 2022-11-22 10:15:11 +01:00
virt-admin.h
virt-host-validate-bhyve.c virt-host-validate-bhyve.c: Reintroduce @ret to virHostValidateBhyve() 2020-05-05 14:45:58 +02:00
virt-host-validate-bhyve.h
virt-host-validate-ch.c
virt-host-validate-ch.h
virt-host-validate-common.c
virt-host-validate-common.h
virt-host-validate-lxc.c
virt-host-validate-lxc.h
virt-host-validate-qemu.c virt-host-validate: Improve failure message when no HW virt is found 2022-06-01 11:58:09 +02:00
virt-host-validate-qemu.h
virt-host-validate.c lib: Use the same style in the 'struct option' 2022-11-22 10:15:11 +01:00
virt-login-shell-helper.c lib: Use the same style in the 'struct option' 2022-11-22 10:15:11 +01:00
virt-login-shell.c
virt-login-shell.conf
virt-pki-query-dn.c lib: Use the same style in the 'struct option' 2022-11-22 10:15:11 +01:00
virt-pki-validate.in
virt-qemu-qmp-proxy tools: add virt-qemu-qmp-proxy for proxying QMP via libvirt QEMU guests 2022-10-07 14:32:36 +01:00
virt-qemu-sev-validate tools: Fix style issues in virt-qemu-sev-validate 2022-12-08 18:09:29 +01:00
virt-sanlock-cleanup.in
virt-xml-validate.in virt-xml-validate: Fix incorrect wildcards for XML roots 2022-07-07 12:21:16 +02:00
vsh-table.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
vsh-table.h
vsh.c tools: Remove unused includes 2022-06-16 06:43:58 +02:00
vsh.h virsh: Add --model option for hypervisor-cpu-baseline 2022-10-10 14:31:43 +02:00