mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-26 23:55:23 +00:00
c19bb8c0cf
Move the SPICE caps validation from qemuBuildGraphicsSPICECommandLine() to a new function called qemuDomainDeviceDefValidateSPICEGraphics(). This function is called by qemuDomainDeviceDefValidateGraphics(), which in turn is called by qemuDomainDefValidate(), validating the graphics parameters in domain define time. This validation move exposed a flaw in the 'default-video-type' tests for PPC64, AARCH64 and s390 archs. The XML was considering 'spice' as the default video type, which isn't true for those architectures. This was flying under the radar until now because the SPICE validation was being made in 'virsh start' time, while the XML validation done in qemuxml2xmltest.c considers define time. All other tests were adapted to consider SPICE validation in this earlier stage. Reviewed-by: Cole Robinson <crobinso@redhat.com> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
17 lines
485 B
XML
17 lines
485 B
XML
<domain type='kvm'>
|
|
<name>default-video-type-ppc64-test</name>
|
|
<uuid>6ba410c5-1e5c-4d57-bee7-2228e7ffa32f</uuid>
|
|
<memory unit='KiB'>1048576</memory>
|
|
<vcpu placement='static'>1</vcpu>
|
|
<os>
|
|
<type arch='ppc64' machine='virt'>hvm</type>
|
|
</os>
|
|
<cpu mode='host-passthrough'/>
|
|
<devices>
|
|
<emulator>/usr/bin/qemu-system-ppc64</emulator>
|
|
<controller type='usb' index='0' model='none'/>
|
|
<memballoon model='none'/>
|
|
<graphics type='vnc'/>
|
|
</devices>
|
|
</domain>
|