libvirt/tests/nodedevmdevctldata
Andrea Bolognani 8a743a598b tests: Ensure test files are newline-terminated
Currently we only append a newline to 'actual' if 'expected'
(as loaded from file) already ends in a newline, but that
results in inconsistent behavior.

For example, some of the test files used by virhostcputest are
newline-terminated and some aren't. If we were to remove
existing newlines from those files or add them where they
aren't present, the test would still pass, and even using
VIR_TEST_REGENERATE_OUTPUT=1 wouldn't change them back.

Make things consistent by ensuring that 'actual' is always
newline-terminated. The only exception is when 'actual' is
completely empty: in that case, we want the file to be actually
empty, not contain a single empty line. query-jobs-empty.result
in qemumonitorjsondata/ is an example of this being used.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2024-01-05 14:38:49 +01:00
..
mdev_cc000052_9b13_9b13_9b13_cc23009b1326-create.argv
mdev_cc000052_9b13_9b13_9b13_cc23009b1326-create.json
mdev_cc000052_9b13_9b13_9b13_cc23009b1326-define.argv
mdev_cc000052_9b13_9b13_9b13_cc23009b1326-define.json
mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-create.argv
mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-create.json tests: Ensure test files are newline-terminated 2024-01-05 14:38:49 +01:00
mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-define.argv
mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-define.json tests: Ensure test files are newline-terminated 2024-01-05 14:38:49 +01:00
mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-start.argv
mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-stop.argv
mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-undefine.argv
mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-create.argv
mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-create.json tests: Ensure test files are newline-terminated 2024-01-05 14:38:49 +01:00
mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-define.argv
mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-define.json tests: Ensure test files are newline-terminated 2024-01-05 14:38:49 +01:00
mdev_fedc4916_1ca8_49ac_b176_871d16c13076-create.argv
mdev_fedc4916_1ca8_49ac_b176_871d16c13076-create.json tests: Ensure test files are newline-terminated 2024-01-05 14:38:49 +01:00
mdev_fedc4916_1ca8_49ac_b176_871d16c13076-define.argv
mdev_fedc4916_1ca8_49ac_b176_871d16c13076-define.json tests: Ensure test files are newline-terminated 2024-01-05 14:38:49 +01:00
mdevctl-autostart.argv
mdevctl-list-defined.argv
mdevctl-list-empty-array.json
mdevctl-list-empty-array.out.xml
mdevctl-list-empty.json
mdevctl-list-empty.out.xml
mdevctl-list-multiple.json
mdevctl-list-multiple.out.xml