mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-07 09:19:19 +00:00
43b99fc4c0
This patch adds instrumentation that will allow hypervisor drivers to fill and validate domain and device definitions after parsed by the XML parser. With this patch, after the XML is parsed, a callback to the driver is issued requesting to fill and validate driver specific details of the configuration. This allows to use sensible defaults and checks on a per driver basis at the time the XML is parsed. Two callback pointers are stored in the new virDomainXMLConf object: * virDomainDeviceDefPostParseCallback (devicesPostParseCallback) - called for a single device parsed and for every single device in a domain config. A virDomainDeviceDefPtr is passed along with the domain definition and virCaps. * virDomainDefPostParseCallback, (domainPostParseCallback) - A callback that is meant to process the domain config after it's parsed. A virDomainDefPtr is passed along with virCaps. Both types of callbacks support arbitrary opaque data passed for the callback functions. Errors may be reported in those callbacks resulting in a XML parsing failure.
330 lines
8.6 KiB
C
330 lines
8.6 KiB
C
#include <config.h>
|
|
|
|
#ifdef WITH_VMX
|
|
|
|
# include <stdio.h>
|
|
# include <string.h>
|
|
# include <unistd.h>
|
|
|
|
# include "internal.h"
|
|
# include "viralloc.h"
|
|
# include "testutils.h"
|
|
# include "vmx/vmx.h"
|
|
|
|
static virCapsPtr caps;
|
|
static virVMXContext ctx;
|
|
static virDomainXMLOptionPtr xmlopt;
|
|
|
|
static int testDefaultConsoleType(const char *ostype ATTRIBUTE_UNUSED,
|
|
virArch arch ATTRIBUTE_UNUSED)
|
|
{
|
|
return VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL;
|
|
}
|
|
|
|
static void
|
|
testCapsInit(void)
|
|
{
|
|
virCapsGuestPtr guest = NULL;
|
|
|
|
caps = virCapabilitiesNew(VIR_ARCH_I686, 1, 1);
|
|
|
|
if (caps == NULL) {
|
|
return;
|
|
}
|
|
|
|
caps->defaultConsoleTargetType = testDefaultConsoleType;
|
|
|
|
virCapabilitiesSetMacPrefix(caps, (unsigned char[]){ 0x00, 0x0c, 0x29 });
|
|
virCapabilitiesAddHostMigrateTransport(caps, "esx");
|
|
|
|
caps->hasWideScsiBus = true;
|
|
|
|
/* i686 guest */
|
|
guest =
|
|
virCapabilitiesAddGuest(caps, "hvm",
|
|
VIR_ARCH_I686,
|
|
NULL, NULL, 0, NULL);
|
|
|
|
if (guest == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
if (virCapabilitiesAddGuestDomain(guest, "vmware", NULL, NULL, 0,
|
|
NULL) == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
/* x86_64 guest */
|
|
guest =
|
|
virCapabilitiesAddGuest(caps, "hvm",
|
|
VIR_ARCH_X86_64,
|
|
NULL, NULL, 0, NULL);
|
|
|
|
if (guest == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
if (virCapabilitiesAddGuestDomain(guest, "vmware", NULL, NULL, 0,
|
|
NULL) == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
return;
|
|
|
|
failure:
|
|
virObjectUnref(caps);
|
|
virObjectUnref(xmlopt);
|
|
caps = NULL;
|
|
}
|
|
|
|
static int
|
|
testCompareFiles(const char *xml, const char *vmx, int virtualHW_version)
|
|
{
|
|
int result = -1;
|
|
char *xmlData = NULL;
|
|
char *vmxData = NULL;
|
|
char *formatted = NULL;
|
|
virDomainDefPtr def = NULL;
|
|
|
|
if (virtTestLoadFile(xml, &xmlData) < 0) {
|
|
goto failure;
|
|
}
|
|
|
|
if (virtTestLoadFile(vmx, &vmxData) < 0) {
|
|
goto failure;
|
|
}
|
|
|
|
def = virDomainDefParseString(caps, xmlopt, xmlData,
|
|
1 << VIR_DOMAIN_VIRT_VMWARE,
|
|
VIR_DOMAIN_XML_INACTIVE);
|
|
|
|
if (def == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
formatted = virVMXFormatConfig(&ctx, caps, def, virtualHW_version);
|
|
|
|
if (formatted == NULL) {
|
|
goto failure;
|
|
}
|
|
|
|
if (STRNEQ(vmxData, formatted)) {
|
|
virtTestDifference(stderr, vmxData, formatted);
|
|
goto failure;
|
|
}
|
|
|
|
result = 0;
|
|
|
|
failure:
|
|
VIR_FREE(xmlData);
|
|
VIR_FREE(vmxData);
|
|
VIR_FREE(formatted);
|
|
virDomainDefFree(def);
|
|
|
|
return result;
|
|
}
|
|
|
|
struct testInfo {
|
|
const char *input;
|
|
const char *output;
|
|
int virtualHW_version;
|
|
};
|
|
|
|
static int
|
|
testCompareHelper(const void *data)
|
|
{
|
|
int result = -1;
|
|
const struct testInfo *info = data;
|
|
char *xml = NULL;
|
|
char *vmx = NULL;
|
|
|
|
if (virAsprintf(&xml, "%s/xml2vmxdata/xml2vmx-%s.xml", abs_srcdir,
|
|
info->input) < 0 ||
|
|
virAsprintf(&vmx, "%s/xml2vmxdata/xml2vmx-%s.vmx", abs_srcdir,
|
|
info->output) < 0) {
|
|
goto cleanup;
|
|
}
|
|
|
|
result = testCompareFiles(xml, vmx, info->virtualHW_version);
|
|
|
|
cleanup:
|
|
VIR_FREE(xml);
|
|
VIR_FREE(vmx);
|
|
|
|
return result;
|
|
}
|
|
|
|
static int
|
|
testAutodetectSCSIControllerModel(virDomainDiskDefPtr def ATTRIBUTE_UNUSED,
|
|
int *model, void *opaque ATTRIBUTE_UNUSED)
|
|
{
|
|
*model = VIR_DOMAIN_CONTROLLER_MODEL_SCSI_LSILOGIC;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static char *
|
|
testFormatVMXFileName(const char *src, void *opaque ATTRIBUTE_UNUSED)
|
|
{
|
|
bool success = false;
|
|
char *copyOfDatastorePath = NULL;
|
|
char *tmp = NULL;
|
|
char *saveptr = NULL;
|
|
char *datastoreName = NULL;
|
|
char *directoryAndFileName = NULL;
|
|
char *absolutePath = NULL;
|
|
|
|
if (STRPREFIX(src, "[")) {
|
|
/* Found potential datastore path */
|
|
copyOfDatastorePath = strdup(src);
|
|
|
|
if (copyOfDatastorePath == NULL) {
|
|
goto cleanup;
|
|
}
|
|
|
|
/* Expected format: '[<datastore>] <path>' where <path> is optional */
|
|
if ((tmp = STRSKIP(copyOfDatastorePath, "[")) == NULL || *tmp == ']' ||
|
|
(datastoreName = strtok_r(tmp, "]", &saveptr)) == NULL) {
|
|
goto cleanup;
|
|
}
|
|
|
|
directoryAndFileName = strtok_r(NULL, "", &saveptr);
|
|
|
|
if (directoryAndFileName == NULL) {
|
|
directoryAndFileName = (char *)"";
|
|
} else {
|
|
directoryAndFileName += strspn(directoryAndFileName, " ");
|
|
}
|
|
|
|
if (virAsprintf(&absolutePath, "/vmfs/volumes/%s/%s", datastoreName,
|
|
directoryAndFileName) < 0)
|
|
goto cleanup;
|
|
} else if (STRPREFIX(src, "/")) {
|
|
/* Found absolute path */
|
|
absolutePath = strdup(src);
|
|
} else {
|
|
/* Found relative path, this is not supported */
|
|
goto cleanup;
|
|
}
|
|
|
|
success = true;
|
|
|
|
cleanup:
|
|
if (! success) {
|
|
VIR_FREE(absolutePath);
|
|
}
|
|
|
|
VIR_FREE(copyOfDatastorePath);
|
|
|
|
return absolutePath;
|
|
}
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int result = 0;
|
|
|
|
# define DO_TEST(_in, _out, _version) \
|
|
do { \
|
|
struct testInfo info = { _in, _out, _version }; \
|
|
virResetLastError(); \
|
|
if (virtTestRun("VMware XML-2-VMX "_in" -> "_out, 1, \
|
|
testCompareHelper, &info) < 0) { \
|
|
result = -1; \
|
|
} \
|
|
} while (0)
|
|
|
|
testCapsInit();
|
|
|
|
if (caps == NULL) {
|
|
return EXIT_FAILURE;
|
|
}
|
|
|
|
if (!(xmlopt = virDomainXMLOptionNew(NULL, NULL, NULL)))
|
|
return EXIT_FAILURE;
|
|
|
|
ctx.opaque = NULL;
|
|
ctx.parseFileName = NULL;
|
|
ctx.formatFileName = testFormatVMXFileName;
|
|
ctx.autodetectSCSIControllerModel = testAutodetectSCSIControllerModel;
|
|
|
|
DO_TEST("minimal", "minimal", 4);
|
|
DO_TEST("minimal-64bit", "minimal-64bit", 4);
|
|
|
|
DO_TEST("graphics-vnc", "graphics-vnc", 4);
|
|
|
|
DO_TEST("scsi-driver", "scsi-driver", 4);
|
|
DO_TEST("scsi-writethrough", "scsi-writethrough", 4);
|
|
|
|
DO_TEST("harddisk-scsi-file", "harddisk-scsi-file", 4);
|
|
DO_TEST("harddisk-ide-file", "harddisk-ide-file", 4);
|
|
|
|
DO_TEST("cdrom-scsi-file", "cdrom-scsi-file", 4);
|
|
DO_TEST("cdrom-scsi-device", "cdrom-scsi-device", 4);
|
|
DO_TEST("cdrom-ide-file", "cdrom-ide-file", 4);
|
|
DO_TEST("cdrom-ide-device", "cdrom-ide-device", 4);
|
|
|
|
DO_TEST("floppy-file", "floppy-file", 4);
|
|
DO_TEST("floppy-device", "floppy-device", 4);
|
|
|
|
DO_TEST("sharedfolder", "sharedfolder", 4);
|
|
|
|
DO_TEST("ethernet-e1000", "ethernet-e1000", 4);
|
|
DO_TEST("ethernet-vmxnet2", "ethernet-vmxnet2", 4);
|
|
|
|
DO_TEST("ethernet-custom", "ethernet-custom", 4);
|
|
DO_TEST("ethernet-bridged", "ethernet-bridged", 4);
|
|
DO_TEST("ethernet-nat", "ethernet-nat", 4);
|
|
|
|
DO_TEST("ethernet-generated", "ethernet-generated", 4);
|
|
DO_TEST("ethernet-static", "ethernet-static", 4);
|
|
DO_TEST("ethernet-vpx", "ethernet-vpx", 4);
|
|
DO_TEST("ethernet-other", "ethernet-other", 4);
|
|
|
|
DO_TEST("serial-file", "serial-file", 4);
|
|
DO_TEST("serial-device", "serial-device", 4);
|
|
DO_TEST("serial-pipe", "serial-pipe", 4);
|
|
DO_TEST("serial-network-server", "serial-network-server", 7);
|
|
DO_TEST("serial-network-client", "serial-network-client", 7);
|
|
|
|
DO_TEST("parallel-file", "parallel-file", 4);
|
|
DO_TEST("parallel-device", "parallel-device", 4);
|
|
|
|
DO_TEST("esx-in-the-wild-1", "esx-in-the-wild-1", 4);
|
|
DO_TEST("esx-in-the-wild-2", "esx-in-the-wild-2", 4);
|
|
DO_TEST("esx-in-the-wild-3", "esx-in-the-wild-3", 4);
|
|
DO_TEST("esx-in-the-wild-4", "esx-in-the-wild-4", 4);
|
|
DO_TEST("esx-in-the-wild-5", "esx-in-the-wild-5", 4);
|
|
DO_TEST("esx-in-the-wild-6", "esx-in-the-wild-6", 4);
|
|
|
|
DO_TEST("gsx-in-the-wild-1", "gsx-in-the-wild-1", 4);
|
|
DO_TEST("gsx-in-the-wild-2", "gsx-in-the-wild-2", 4);
|
|
DO_TEST("gsx-in-the-wild-3", "gsx-in-the-wild-3", 4);
|
|
DO_TEST("gsx-in-the-wild-4", "gsx-in-the-wild-4", 4);
|
|
|
|
DO_TEST("ws-in-the-wild-1", "ws-in-the-wild-1", 8);
|
|
DO_TEST("ws-in-the-wild-2", "ws-in-the-wild-2", 8);
|
|
|
|
DO_TEST("annotation", "annotation", 4);
|
|
|
|
DO_TEST("smbios", "smbios", 4);
|
|
|
|
DO_TEST("svga", "svga", 4);
|
|
|
|
virObjectUnref(caps);
|
|
|
|
return result == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
VIRT_TEST_MAIN(mymain)
|
|
|
|
#else
|
|
# include "testutils.h"
|
|
|
|
int main(void)
|
|
{
|
|
return EXIT_AM_SKIP;
|
|
}
|
|
|
|
#endif /* WITH_VMX */
|