libvirt/include/libvirt
Jiri Denemark 44c42b564d qemu: Don't report false error from MigrateFinish
virDomainMigrateFinish* APIs were unfortunately designed to return the
pointer to the domain on destination and NULL on error. This looks OK in
normal cases but the same API is also called when we know migration
failed and thus we expect Finish to return NULL even if it actually did
all it was supposed to do without any error. The call is defined to
return nonnull domain pointer over RPC, which means returning NULL will
always result in an error being send. If this was not in fact an error,
the API itself wouldn't set anything to the thread local virError, which
makes the RPC layer come up with it's own "Library function returned
error but did not set virError" error.

This is quite confusing and also hard to detect by the caller. This
patch adds a special error code which can be used to check that Finish
successfully aborted migration.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
2015-07-10 11:47:13 +02:00
..
libvirt-admin.h Revert "admin: Add virAdmHello function" 2015-06-16 14:08:59 +02:00
libvirt-domain-snapshot.h Move virDomainSnapshot related APIs out of libvirt.h.in 2014-10-24 17:20:20 +01:00
libvirt-domain.h Support for a new watchdog action inject-nmi 2015-06-24 15:26:31 +02:00
libvirt-event.h Move virEvent related APIs out of libvirt.h.in 2014-10-24 17:23:17 +01:00
libvirt-host.h util: add virTypedParamsAddStringList 2015-06-18 16:46:09 +02:00
libvirt-interface.h Move virInterface related APIs out of libvirt.h.in 2014-10-24 17:21:15 +01:00
libvirt-lxc.h syntax-check: Only allows to include public headers in external tools 2013-04-18 11:31:19 +08:00
libvirt-network.h Move virNetwork related APIs out of libvirt.h.in 2014-10-24 17:20:52 +01:00
libvirt-nodedev.h Move virNodeDevice related APIs out of libvirt.h.in 2014-10-24 17:21:59 +01:00
libvirt-nwfilter.h Move virNWFilter related APIs out of libvirt.h.in 2014-10-24 17:21:34 +01:00
libvirt-qemu.h qemu: lifecycle: make agent-mode shutdown and reboot timeout 2015-04-02 11:08:48 +02:00
libvirt-secret.h Move virSecret related APIs out of libvirt.h.in 2014-10-24 17:22:20 +01:00
libvirt-storage.h storage: add a flag to clone files on btrfs 2015-01-27 13:41:14 +01:00
libvirt-stream.h Move virStream related APIs out of libvirt.h.in 2014-10-24 17:22:38 +01:00
libvirt.h.in Fix preprocessor indentation in libvirt.h.in 2014-10-24 17:23:52 +01:00
Makefile.am Temporarily disable admin API 2015-06-28 11:34:25 +08:00
virterror.h qemu: Don't report false error from MigrateFinish 2015-07-10 11:47:13 +02:00