Laine Stump 48e8b95d8e test: fix IP address range failure test
This was revealed when I made a cut-paste mistake in an upgrade to
virSocketAddrGetRange(), leading to failure to check for the end
address being outside of the defined network, but a negative test case
that should have caught the error instead returned success.

The problem was that testRange in sockettest.c was written so that
when it expected a failure, even an "unexpected success" would be
considered as an "expected failure" because of the way the check in
testRange was done. testRange had this:

 if (gotsize < 0 || gotsize != size) {
     return pass ? -1 : 0;
 } else {
     return pass ? 0 : -1;
 }

but all the tests that expected a failure give "-1" as the expected
size. So in a case where we expect a failure, we would have pass ==
false and size == -1. If virSocketAddrGetRange() was incorrectly
*successful* (returned some positive number), then "gotsize != size"
would be, e.g. "276 != -1", so we would take the if clause and, since
pass == false, we would return 0 (success i.e. expected failure).

The solution is that in the case where we expect failure, we should
just ignore size - virSocketAddrGetRange() must return -1 in order for
us to report "expected failure == success".

Part of fix for: https://bugzilla.redhat.com/show_bug.cgi?id=985653
2015-06-02 12:40:07 -04:00
..
2014-09-03 09:36:13 -06:00
2015-05-21 18:13:18 +02:00
2015-04-23 17:08:48 -04:00
2015-04-23 17:08:48 -04:00
2009-10-07 12:18:13 +02:00
2015-04-23 17:08:48 -04:00
2015-04-27 16:03:31 +02:00
2014-09-04 15:18:43 -06:00
2015-05-21 18:13:18 +02:00
2015-05-04 15:01:27 +02:00
2015-04-23 17:08:48 -04:00
2014-11-25 08:47:12 -07:00
2013-10-14 10:31:01 +01:00
2015-04-14 19:33:02 +02:00
2015-04-14 19:33:02 +02:00
2014-04-08 11:15:55 +01:00
2015-04-23 17:08:48 -04:00
2015-04-23 17:08:48 -04:00
2015-04-23 17:08:48 -04:00