Eric Blake
4932ef4502
rng: restrict passthrough names to known-good files
...
There is some controversy[1] on the qemu list on whether qemu should
have ever allowed arbitrary file name passthrough, or whether it
should be restricted to JUST /dev/random and /dev/hwrng. It is
always easier to add support for additional filenames than it is
to remove support for something once released, so this patch
restricts libvirt 1.0.3 (where the virtio-random backend was first
supported) to just the two uncontroversial names, letting us defer
to a later date any decision on whether supporting arbitrary files
makes sense. Additionally, since qemu 1.4 does NOT support
/dev/fdset/nnn fd passthrough for the backend, limiting to just
two known names means that we don't get tempted to try fd
passthrough where it won't work.
[1]https://lists.gnu.org/archive/html/qemu-devel/2013-03/threads.html#00023
* src/conf/domain_conf.c (virDomainRNGDefParseXML): Only allow
/dev/random and /dev/hwrng.
* docs/schemas/domaincommon.rng: Flag invalid files.
* docs/formatdomain.html.in (elementsRng): Document this.
* tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.args:
Update test to match.
* tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-random.xml:
Likewise.
2013-03-04 17:45:38 -07:00
..
2012-02-01 16:28:17 -07:00
2012-02-03 15:27:16 -07:00
2012-02-03 15:27:16 -07:00
2012-10-12 00:03:43 +02:00
2013-03-04 17:45:38 -07:00
2006-01-23 22:55:41 +00:00
2012-08-10 10:54:23 +02:00
2012-08-10 10:58:54 +02:00
2013-03-04 17:36:03 -05:00
2013-02-07 19:52:44 +01:00
2012-10-12 00:03:43 +02:00
2008-04-23 17:08:31 +00:00
2011-10-28 10:11:16 +01:00
2005-12-21 16:59:34 +00:00
2010-10-27 15:01:45 +11:00
2011-04-01 16:03:11 -06:00
2008-04-23 17:08:31 +00:00
2009-11-06 16:05:18 +01:00
2012-12-14 13:35:03 +01:00
2011-02-09 12:29:29 -07:00
2012-08-22 15:34:07 -06:00
2012-09-18 10:59:16 +01:00
2011-01-05 18:07:30 +11:00
2010-11-30 02:22:38 +11:00
2010-10-27 15:01:45 +11:00
2010-10-27 15:01:45 +11:00
2008-04-23 17:08:31 +00:00
2010-12-21 20:55:10 +11:00
2013-03-04 17:36:03 -05:00
2012-10-24 19:50:28 +02:00
2011-08-26 17:52:55 +02:00
2012-02-03 11:32:51 -07:00
2012-04-16 17:02:08 +02:00
2012-08-15 16:39:40 +08:00
2012-10-09 15:20:32 +02:00
2012-08-22 15:34:07 -06:00
2008-04-23 17:08:31 +00:00
2012-08-22 15:34:07 -06:00
2011-07-15 13:19:41 -06:00
2011-10-29 19:50:48 +02:00
2011-07-15 13:19:41 -06:00
2012-12-06 16:15:54 -07:00
2009-09-22 12:55:39 +02:00
2008-04-28 08:29:35 +00:00
2013-01-30 09:37:03 +01:00
2008-04-23 17:08:31 +00:00
2008-04-23 17:08:31 +00:00
2008-04-23 17:08:31 +00:00
2011-11-30 10:12:30 +00:00
2013-03-04 17:45:38 -07:00
2013-02-27 21:18:33 -07:00
2012-08-22 15:34:07 -06:00
2012-08-22 15:34:07 -06:00
2011-10-28 11:34:17 -06:00
2012-11-02 09:56:23 -06:00
2012-08-02 17:14:17 -06:00
2011-04-01 16:03:11 -06:00
2013-01-18 15:36:38 +01:00
2011-03-28 10:40:24 +08:00
2010-11-12 19:47:20 +01:00
2012-09-08 23:20:29 -04:00
2013-02-07 14:08:14 -05:00
2013-03-01 20:28:00 +01:00
2013-01-14 13:58:34 +00:00
2013-03-04 17:36:03 -05:00
2013-02-07 19:52:44 +01:00
2013-03-04 17:36:03 -05:00
2009-04-02 12:01:11 +00:00
2012-10-04 09:17:45 -06:00
2009-07-16 15:06:42 +02:00
2011-10-28 10:11:16 +01:00
2012-07-23 16:07:13 -06:00
2011-10-28 10:11:16 +01:00
2012-07-23 16:07:13 -06:00
2008-04-23 17:08:31 +00:00
2008-04-23 17:08:31 +00:00
2011-10-28 10:11:16 +01:00
2012-07-23 16:07:13 -06:00
2011-10-28 10:11:16 +01:00
2012-07-23 16:07:13 -06:00
2011-10-28 10:11:16 +01:00
2012-07-23 16:07:13 -06:00
2013-03-04 17:36:03 -05:00
2013-03-04 17:36:03 -05:00
2013-02-01 08:47:38 +01:00
2012-06-18 20:10:29 +01:00
2006-02-09 17:45:11 +00:00
2012-10-30 10:12:10 +01:00
2012-08-17 21:26:53 +02:00
2006-02-09 17:45:11 +00:00
2008-04-23 17:08:31 +00:00
2013-01-21 18:41:26 +01:00
2011-10-28 10:11:16 +01:00
2011-10-28 10:07:45 +01:00
2011-10-28 10:11:16 +01:00
2011-10-28 10:07:45 +01:00
2011-10-28 10:11:16 +01:00
2011-10-28 10:07:45 +01:00
2011-10-28 10:11:16 +01:00
2011-10-28 10:07:45 +01:00
2011-10-28 10:11:16 +01:00
2011-10-28 10:07:45 +01:00
2012-12-11 20:46:31 +01:00
2013-02-01 08:47:38 +01:00
2013-02-11 15:20:53 -07:00
2009-07-29 09:04:21 +01:00
2011-10-28 10:11:16 +01:00
2006-01-23 13:24:07 +00:00
2012-09-11 17:36:03 +02:00
2012-08-10 10:58:54 +02:00
2011-02-09 12:29:29 -07:00
2012-02-09 14:28:40 -07:00
2012-09-20 15:47:21 -06:00
2012-10-12 00:03:43 +02:00
2012-08-10 10:58:38 +02:00
2012-08-10 10:58:38 +02:00
2012-08-10 10:54:23 +02:00
2013-03-04 17:36:03 -05:00
2013-02-26 20:19:19 -07:00
2011-10-28 10:11:16 +01:00
2010-12-02 16:00:47 -07:00
2011-05-11 19:18:38 +08:00
2011-05-11 08:18:04 -06:00
2011-05-11 19:18:38 +08:00
2010-10-12 11:26:52 +01:00
2012-07-30 13:09:57 +01:00
2012-12-14 13:35:03 +01:00
2011-01-11 07:33:15 +11:00
2011-04-01 16:03:11 -06:00
2010-11-12 19:47:20 +01:00