mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-02 11:21:12 +00:00
d0c7254bf1
Diego reported a bug where virsh tries to initialize a readline
history directory during 'make check' run as root, but fails
because /root was read-only.
It turns out that I could reproduce this as non-root, by using:
mv ~/.virsh{,.bak}
chmod a-w ~
make check -C tests TESTS=int-overflow
chmod u+w ~
mv ~/.virsh{.bak,}
* tests/int-overflow: Don't trigger interactive mode.
Reported by Diego Elio Pettenò.
23 lines
678 B
Bash
Executable File
23 lines
678 B
Bash
Executable File
#!/bin/bash
|
|
# Ensure that an invalid domain ID isn't interpreted as a valid one.
|
|
# Before, an ID of 2^32+2 would be treated just like an ID of 2.
|
|
|
|
test -z "$srcdir" && srcdir=$(pwd)
|
|
test -z "$abs_top_srcdir" && abs_top_srcdir=$(pwd)/..
|
|
test -z "$abs_top_builddir" && abs_top_builddir=$(pwd)/..
|
|
|
|
if test "$VERBOSE" = yes; then
|
|
set -x
|
|
$abs_top_builddir/tools/virsh --version
|
|
fi
|
|
|
|
. "$srcdir/test-lib.sh"
|
|
|
|
echo "error: failed to get domain '4294967298'" > exp || fail=1
|
|
$abs_top_builddir/tools/virsh --quiet \
|
|
--connect test://$abs_top_srcdir/examples/xml/test/testnode.xml \
|
|
'domname 4294967298; quit' > /dev/null 2> err || fail=1
|
|
diff -u err exp || fail=1
|
|
|
|
exit $fail
|