Michal Privoznik 5c98d1cee0 virdnsmasq: Lookup DNSMASQ in PATH ... While it's true that our virCommand subsystem is happy with non-absolute paths, the dnsmasq capability code is not. It stores the path to dnsmasq within and makes it accessible via dnsmasqCapsGetBinaryPath(). While strictly speaking no caller necessarily needs canonicalized path, let's find dnsmasq once and cache the result. Therefore, when constructing the capabilities structure look up the binary path. If DNSMASQ already contains an absolute path then virFindFileInPath() will simply return a copy. With this code in place, the virFileIsExecutable() check can be removed from dnsmasqCapsRefreshInternal() because virFindFileInPath() already made sure the binary is executable. But introducing virFindFileInPath() means we have to mock it in test suite because dnsmasqCaps are created in networkxml2conftest. Moreover, we don't need to check for dnsmasq in configure. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com>		2022-01-18 15:19:47 +01:00
..
bhyveargv2xmldata
bhyvefirmwaredata
bhyvexml2argvdata
bhyvexml2xmloutdata
capabilityschemadata
commanddata
cputestdata
domainbackupxml2xmlin
domainbackupxml2xmlout
domaincapsdata	tests: qemucapabilities: Add test data for the qemu-7.0 development cycle	2022-01-17 09:26:17 +01:00
domainconfdata
domainschemadata
fchostdata/fc_host
genericxml2xmlindata
genericxml2xmloutdata
interfaceschemadata
libxlxml2domconfigdata
lxcconf2xmldata
lxcxml2xmldata
lxcxml2xmloutdata
networkxml2confdata	tests: do not test dnsmasq older than 2.67	2021-12-15 15:28:17 +01:00
networkxml2firewalldata
networkxml2xmlin
networkxml2xmlout
networkxml2xmlupdatein
networkxml2xmlupdateout
nodedevmdevctldata	nodedev: Add tests for mdevctl autostart command	2021-09-14 14:24:07 -05:00
nodedevschemadata	Add PCI VPD Capability Support	2021-10-21 17:34:04 +01:00
nodedevxml2xmlout	Add PCI VPD Capability Support	2021-10-21 17:34:04 +01:00
nssdata
nwfilterxml2firewalldata
nwfilterxml2xmlin
nwfilterxml2xmlout
qemuagentdata
qemublocktestdata	qemublocktest: Add test for creating a qcow2 on top of an luks-encrypted qcow2	2021-08-20 15:43:17 +02:00
qemucapabilitiesdata	qemu: capabilities: Re-enable JSON syntax for -device	2022-01-17 09:26:17 +01:00
qemucaps2xmloutdata
qemudomaincheckpointxml2xmlin
qemudomaincheckpointxml2xmlout
qemudomainsnapshotxml2xmlin
qemudomainsnapshotxml2xmlout
qemufirmwaredata
qemuhotplugtestcpus	qemuhotplugtest: Remove tests for legacy cpu hotplug on x86	2021-11-01 16:14:53 +01:00
qemuhotplugtestdevices
qemuhotplugtestdomains	Add the port allocation logic for isa-serial devices.	2022-01-14 15:41:57 +01:00
qemumemlockdata
qemumigparamsdata	qemumigparamstest: Drop "unsupported" test case	2021-10-22 07:00:44 +02:00
qemumigrationcookiexmldata	qemu: migration: Don't transfer 'allowReboot' flag	2021-08-25 15:32:44 +02:00
qemumonitorjsondata
qemusecuritydata
qemustatusxml2xmldata	qemustatusxml2xmldata: backup-pull: Add private data for scratch image	2021-11-04 10:55:28 +01:00
qemuvhostuserdata
qemuxml2argvdata	qemu: capabilities: Re-enable JSON syntax for -device	2022-01-17 09:26:17 +01:00
qemuxml2xmloutdata	qemuxml2(argv|xml)data: x86-kvm-32-on-64: Add machine type	2022-01-17 09:26:17 +01:00
secretxml2xmlin
securityselinuxhelperdata
securityselinuxlabeldata	securityselinuxlabeldata: Purge unneeded versioned machine type	2022-01-07 09:25:14 +01:00
storagepoolcapsschemadata
storagepoolschemadata
storagepoolxml2argvdata
storagepoolxml2xmlin
storagepoolxml2xmlout
storagevolschemadata
storagevolxml2argvdata	storage: Introduce 'extended_l2' feature for storage volume	2021-12-21 13:23:09 +01:00
storagevolxml2xmlin	storage: Introduce 'extended_l2' feature for storage volume	2021-12-21 13:23:09 +01:00
storagevolxml2xmlout	storage: Introduce 'extended_l2' feature for storage volume	2021-12-21 13:23:09 +01:00
sysinfodata
vboxsnapshotxmldata
vircaps2xmldata
vircgroupdata
virconfdata	Add suggestions for virt-pki-query-dn usage	2021-11-12 12:37:29 +01:00
virfilecachedata
virfiledata
virhostcpudata
virjsondata
virmacmaptestdata
virnetdaemondata
virnetdevopenvswitchdata
virnetdevtestdata/sys/class/net
virnetworkportxml2xmldata
virnwfilterbindingxml2xmldata
virpcitestdata
virprocessstatdata	util: Add virProcessGetStat	2021-11-23 16:43:08 +01:00
virresctrldata
virscsidata
virstoragetestdata	virstoragetest: Reinstate testing of images without 'backing_fmt'	2021-09-09 15:29:00 +02:00
virstorageutildata
virusbtestdata/sys_bus_usb/devices
vmwareverdata
vmx2xmldata	tests: Add missing test cases to vmx2xmltest	2021-08-19 13:32:10 +02:00
xlconfigdata
xmconfigdata
xml2vmxdata
.valgrind.supp
bhyveargv2xmlmock.c
bhyveargv2xmltest.c	tests: bhyve: use bitwise shift when defining flags	2021-09-08 15:13:12 +02:00
bhyvexml2argvmock.c	lib: Drop intermediary return variables	2021-10-25 12:48:46 +02:00
bhyvexml2argvtest.c
bhyvexml2xmltest.c
commandhelper.c
commandtest.c
cputest.c	tests: remove pointless labels	2021-09-09 18:06:13 +02:00
domaincapsmock.c	virhostmem: Introduce virHostMemGetTHPSize()	2021-10-01 10:58:27 +02:00
domaincapstest.c	tests: Remove 'qemucapsfixreplies'	2022-01-03 13:14:43 +01:00
domainconftest.c	lib: Drop needless one line labels	2021-11-22 12:39:59 +01:00
esxutilstest.c	tests: esxutils: reduce variable scope in testConvertWindows1252ToUTF8	2021-09-08 15:31:01 +02:00
eventtest.c	tests: use g_autofree	2021-09-09 18:06:13 +02:00
fchosttest.c	tests: remove pointless labels	2021-09-09 18:06:13 +02:00
fdstreamtest.c	tests: use VIR_AUTOCLOSE	2021-09-09 18:06:13 +02:00
genericxml2xmltest.c	virDomainBackupDefFormat: Propagate private data callbacks	2021-11-04 10:55:28 +01:00
interfacexml2xmltest.c	lib: Introduce and use g_autoptr() for virInterfaceDef	2021-11-02 10:52:18 +01:00
libvirtd-fail
libvirtd-pool
libxlmock.c
libxlxml2domconfigtest.c	tests: use g_auto instead of virDomainFree	2021-09-09 18:06:13 +02:00
lxcconf2xmltest.c	tests: remove pointless labels	2021-09-09 18:06:13 +02:00
lxcxml2xmltest.c	tests: use g_autofree	2021-09-09 18:06:13 +02:00
meson.build	virdnsmasq: Lookup DNSMASQ in PATH	2022-01-18 15:19:47 +01:00
metadatatest.c	tests: remove pointless labels	2021-09-09 18:06:13 +02:00
networkxml2conftest.c	virdnsmasq: Lookup DNSMASQ in PATH	2022-01-18 15:19:47 +01:00
networkxml2firewalltest.c	util: remove currentBackend from virfirewall.c	2021-12-13 13:37:31 -05:00
networkxml2xmltest.c	tests: network: use g_autofree	2021-09-09 18:06:13 +02:00
networkxml2xmlupdatetest.c	tests: network: use g_autofree	2021-09-09 18:06:13 +02:00
nodedevmdevctltest.c	nodedev: Add tests for mdevctl autostart command	2021-09-14 14:24:07 -05:00
nodedevxml2xmltest.c	Add PCI VPD Capability Support	2021-10-21 17:34:04 +01:00
nsslinktest.c
nssmock.c
nsstest.c	tests: use g_autofree	2021-09-09 18:06:13 +02:00
nwfilterebiptablestest.c	util: remove currentBackend from virfirewall.c	2021-12-13 13:37:31 -05:00
nwfilterxml2firewalltest.c	util: remove currentBackend from virfirewall.c	2021-12-13 13:37:31 -05:00
nwfilterxml2xmltest.c	tests: nwfilter: use g_autofree	2021-09-09 18:06:13 +02:00
objecteventtest.c	objecteventtest: Don't overwrite @ret on failure	2021-10-18 12:09:33 +02:00
openvzutilstest.c	tests: remove pointless labels	2021-09-09 18:06:13 +02:00
openvzutilstest.conf
permitted_file_access.txt
pkix_asn1_tab.c
qemuagenttest.c	tests: Drop cleanup/error labels	2021-11-11 16:16:30 +01:00
qemublocktest.c	qemublocktest: Replace virJSONValueObjectCreate by virJSONValueObjectAdd	2021-11-17 12:04:11 +01:00
qemucapabilitiesnumbering.c	Fix some typos	2022-01-12 11:43:30 +01:00
qemucapabilitiestest.c	Fix some typos	2022-01-12 11:43:30 +01:00
qemucaps2xmlmock.c
qemucaps2xmltest.c	Remove empty cleanup sections	2021-12-13 14:44:01 +01:00
qemucapsprobe.c	qemu: Invalidate capabilities cache on host cpuid mismatch	2021-11-05 17:12:25 +01:00
qemucapsprobemock.c	tests: qemu: remove pointless labels	2021-09-09 18:06:13 +02:00
qemucommandutiltest.c	tests: qemu: remove pointless labels	2021-09-09 18:06:13 +02:00
qemucpumock.c
qemudomaincheckpointxml2xmltest.c
qemudomainsnapshotxml2xmltest.c
qemufirmwaretest.c
qemuhotplugmock.c	virDevMapperGetTargets: Use a linked list as return type	2021-09-21 12:25:42 +02:00
qemuhotplugtest.c	tests: Use g_autoptr(qemuMonitorTest)	2021-11-11 16:16:26 +01:00
qemumemlocktest.c
qemumigparamstest.c	tests: Drop cleanup/error labels	2021-11-11 16:16:30 +01:00
qemumigrationcookiexmltest.c	testQEMUSchemaValidateCommand: Add possibility for partial QMP validation	2021-10-18 14:00:58 +02:00
qemumonitorjsontest.c	qemu: Implement the virDomainSetLaunchSecurityState API	2022-01-04 10:56:00 -07:00
qemumonitortestutils.c	tests: Report expected monitor command for simulated commands	2022-01-15 06:33:33 +01:00
qemumonitortestutils.h	qemumonitortestutils: Extract parser for the monitor conversation dump file	2022-01-03 13:14:43 +01:00
qemusecuritymock.c	Switch away from virHashFree	2021-12-01 13:53:12 +01:00
qemusecuritytest.c	qemuxml2argvtest: Remove redundant floppy controller tests	2022-01-07 09:25:13 +01:00
qemusecuritytest.h
qemustatusxml2xmltest.c	test: Drop unused @cfg from qemu*test	2021-08-26 09:16:44 +02:00
qemuvhostusertest.c
qemuxml2argvmock.c	lib: Drop intermediary return variables	2021-10-25 12:48:46 +02:00
qemuxml2argvtest.c	qemuxml2argvtest: Convert 'missing-machine' to DO_TEST_CAPS_LATEST	2022-01-07 09:25:14 +01:00
qemuxml2xmltest.c	qemuxml2(xml|argv)test: Test real state of things with 'x86-kvm-32-on-64'	2022-01-07 09:25:14 +01:00
scsihosttest.c	tests: remove pointless labels	2021-09-09 18:06:13 +02:00
seclabeltest.c
secretxml2xmltest.c	tests: use g_autofree	2021-09-09 18:06:13 +02:00
securityselinuxhelper.c
securityselinuxlabeltest.c	tests: remove pointless labels	2021-09-09 18:06:13 +02:00
securityselinuxtest.c	lib: Use g_autoptr() for virDomainDef	2021-12-03 17:18:26 +01:00
shunloadhelper.c
shunloadtest.c
sockettest.c	tests: use g_autofree	2021-09-09 18:06:13 +02:00
ssh.c
storagebackendsheepdogtest.c
storagepoolcapstest.c
storagepoolxml2argvtest.c
storagepoolxml2xmltest.c
storagevolxml2argvtest.c	tests: storagevolxml2argvtest: do not reuse cmd	2021-12-14 16:41:06 +01:00
storagevolxml2xmltest.c
sysinfotest.c
test-lib.sh
testutils.c	testutils: Terminate usage string with a new line	2022-01-17 16:53:21 +01:00
testutils.h	Add a PCI/PCIe device VPD Parser	2021-10-21 17:34:04 +01:00
testutilshostcpus.h
testutilslxc.c	testLXCCapsInit: Cleanup	2021-11-08 14:32:32 +01:00
testutilslxc.h
testutilsqemu.c	qemuTestCapsCacheInsert: Rewrite caps cache insertion	2022-01-07 09:25:14 +01:00
testutilsqemu.h	tests: qemuxml2*test: switch to virTestRunLog	2021-08-23 14:43:57 +02:00
testutilsqemuschema.c	testQEMUSchemaValidateEnum: Validate deprecated members	2021-11-01 17:37:15 +01:00
testutilsqemuschema.h	testQEMUSchemaValidateCommand: Add possibility for partial QMP validation	2021-10-18 14:00:58 +02:00
testutilsxen.c	Use g_auto for stealing virCaps	2021-12-13 14:44:01 +01:00
testutilsxen.h
utiltest.c
vboxsnapshotxmltest.c	Remove empty cleanup sections	2021-12-13 14:44:01 +01:00
viralloctest.c
virauthconfigtest.c
virbitmaptest.c	virBitmapSetBitExpand: Remove return value	2021-12-10 16:36:25 +01:00
virbuftest.c
vircaps2xmltest.c
vircapstest.c	testutilsqemu: Remove unused non-x86 fake machine types	2022-01-07 09:25:13 +01:00
vircgroupmock.c
vircgrouptest.c	tests: vir: use g_autofree	2021-09-09 18:06:13 +02:00
virconftest.c	Remove empty cleanup sections	2021-12-13 14:44:01 +01:00
vircryptotest.c	util: Remove use of virCryptoHaveCipher(VIR_CRYPTO_CIPHER_AES256CBC)	2021-09-22 14:53:55 +02:00
virdnsmasqmock.c	virdnsmasq: Lookup DNSMASQ in PATH	2022-01-18 15:19:47 +01:00
virdriverconnvalidatetest.c
virdrivermoduletest.c
virendiantest.c
virerrortest.c
virfilecachemock.c
virfilecachetest.c	tests: vir: use g_autofree	2021-09-09 18:06:13 +02:00
virfilemock.c	tests: vir: use g_autofree	2021-09-09 18:06:13 +02:00
virfiletest.c	Remove empty cleanup sections	2021-12-13 14:44:01 +01:00
virfilewrapper.c
virfilewrapper.h
virfirewallmock.c
virfirewalltest.c	util: remove currentBackend from virfirewall.c	2021-12-13 13:37:31 -05:00
virgdbusmock.c
virhostcpumock.c
virhostcputest.c	tests: vir: remove pointless labels	2021-09-09 18:06:13 +02:00
virhostdevmock.c
virhostdevtest.c
virhostidmock.c
viridentitytest.c
viriscsitest.c	tests: vir: remove pointless labels	2021-09-09 18:06:13 +02:00
virjsontest.c	util: json: Don't copy string in virJSONValueNewString	2021-12-22 13:48:35 +01:00
virkeycodetest.c
virkmodtest.c	tests: vir: remove pointless labels	2021-09-09 18:06:13 +02:00
virlockspacetest.c
virlogtest.c
virmacmaptest.c	tests: vir: remove pointless labels	2021-09-09 18:06:13 +02:00
virmigtest.c
virmock.h
virmockstathelpers.c
virnetdaemonmock.c
virnetdaemontest.c	tests/virnetdaemontest.c: testExecRestart: Automatically free virJSONValue-s	2021-12-07 09:00:39 +01:00
virnetdevbandwidthmock.c
virnetdevbandwidthtest.c	tests: virnetdev*: remove unnecessary labels	2021-08-20 16:43:20 +02:00
virnetdevmock.c
virnetdevopenvswitchtest.c	virnetdevopenvswitch: unify calculation of ovs and tc	2021-11-01 15:56:47 +01:00
virnetdevtest.c
virnetmessagetest.c
virnetserverclientmock.c
virnetserverclienttest.c	lib: Drop intermediary return variables	2021-10-25 12:48:46 +02:00
virnetsockettest.c	virnetsocket: Don't free virCommand in virNetSocketNewConnectCommand()	2021-10-15 16:03:22 +02:00
virnettlscontexttest.c
virnettlshelpers.c	tests: use VIR_AUTOCLOSE	2021-09-09 18:06:13 +02:00
virnettlshelpers.h
virnettlssessiontest.c
virnetworkportxml2xmltest.c	tests: vir: remove pointless labels	2021-09-09 18:06:13 +02:00
virnumamock.c	virnumamock: Use automatic memory freeing for virBitmap	2021-12-10 16:36:24 +01:00
virnwfilterbindingxml2xmltest.c	tests: vir: use g_autofree	2021-09-09 18:06:13 +02:00
virpcimock.c	lib: Use G_N_ELEMENTS instead of sizeof()/sizeof()	2021-11-03 14:46:54 +01:00
virpcitest.c	Add PCI VPD-related helper functions to virpci	2021-10-21 17:34:04 +01:00
virpcivpdtest.c	tests: pcivpdtest: check return value of virCreateAnonymousFile	2021-11-23 16:59:36 +01:00
virpolkittest.c
virportallocatormock.c
virportallocatortest.c
virprocessmock.c
virprocessstattest.c	util: Add virProcessGetStat	2021-11-23 16:43:08 +01:00
virrandommock.c
virresctrltest.c	tests: vir: remove pointless labels	2021-09-09 18:06:13 +02:00
virrotatingfiletest.c	tests: use VIR_AUTOCLOSE	2021-09-09 18:06:13 +02:00
virschematest.c
virscsitest.c	tests: vir: remove pointless labels	2021-09-09 18:06:13 +02:00
virsh-auth
virsh-auth.xml
virsh-checkpoint
virsh-cpuset
virsh-define-dev-segfault
virsh-int-overflow
virsh-optparse
virsh-output
virsh-output-commands
virsh-output.out
virsh-read-bufsiz
virsh-read-non-seekable
virsh-schedinfo
virsh-self-test
virsh-snapshot	test: snapshot revert: properly emulate starting CPUs	2021-11-23 11:41:55 +01:00
virsh-start
virsh-undefine
virsh-uriprecedence
virsh-vcpupin
virshtest.c	tests: Test IOThread related functions for test driver	2021-09-23 13:41:39 +02:00
virstoragetest.c	Fix typos	2021-09-17 14:28:00 +02:00
virstorageutiltest.c
virstringtest.c	Remove empty cleanup sections	2021-12-13 14:44:01 +01:00
virsystemdtest.c	tests: vir: remove pointless labels	2021-09-09 18:06:13 +02:00
virt-aa-helper-test
virt-admin-self-test
virtestmock.c	tests: vir: use g_autofree	2021-09-09 18:06:13 +02:00
virtimetest.c	tests: virtimetest: Mention GLib version containing fix	2022-01-03 09:39:35 +01:00
virtypedparamtest.c
viruritest.c	tests: vir: use g_autofree	2021-09-09 18:06:13 +02:00
virusbmock.c	lib: Drop intermediary return variables	2021-10-25 12:48:46 +02:00
virusbtest.c	tests: vir: use g_autofree	2021-09-09 18:06:13 +02:00
vmwarevertest.c	tests: remove pointless labels	2021-09-09 18:06:13 +02:00
vmx2xmltest.c	lib: Don't check for virCapabilitiesAddGuestDomain() retval	2021-11-01 16:08:26 +01:00
vshtabletest.c	vsh-table: Ensure NULL terminated arguments to vshTable*()	2021-12-17 15:05:58 +01:00
xlconfigtest.c	tests: libxl: remove pointless labels	2021-09-09 18:06:13 +02:00
xmconfigtest.c	tests: libxl: remove pointless labels	2021-09-09 18:06:13 +02:00
xml2vmxtest.c	lib: Don't check for virCapabilitiesAddGuestDomain() retval	2021-11-01 16:08:26 +01:00