mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-25 05:55:17 +00:00
3e2c3d8f6d
No thanks to 64-bit windows, with 64-bit pid_t, we have to avoid constructs like 'int pid'. Our API in libvirt-qemu cannot be changed without breaking ABI; but then again, libvirt-qemu can only be used on systems that support UNIX sockets, which rules out Windows (even if qemu could be compiled there) - so for all points on the call chain that interact with this API decision, we require a different variable name to make it clear that we audited the use for safety. Adding a syntax-check rule only solves half the battle; anywhere that uses printf on a pid_t still needs to be converted, but that will be a separate patch. * cfg.mk (sc_correct_id_types): New syntax check. * src/libvirt-qemu.c (virDomainQemuAttach): Document why we didn't use pid_t for pid, and validate for overflow. * include/libvirt/libvirt-qemu.h (virDomainQemuAttach): Tweak name for syntax check. * src/vmware/vmware_conf.c (vmwareExtractPid): Likewise. * src/driver.h (virDrvDomainQemuAttach): Likewise. * tools/virsh.c (cmdQemuAttach): Likewise. * src/remote/qemu_protocol.x (qemu_domain_attach_args): Likewise. * src/qemu_protocol-structs (qemu_domain_attach_args): Likewise. * src/util/cgroup.c (virCgroupPidCode, virCgroupKillInternal): Likewise. * src/qemu/qemu_command.c(qemuParseProcFileStrings): Likewise. (qemuParseCommandLinePid): Use pid_t for pid. * daemon/libvirtd.c (daemonForkIntoBackground): Likewise. * src/conf/domain_conf.h (_virDomainObj): Likewise. * src/probes.d (rpc_socket_new): Likewise. * src/qemu/qemu_command.h (qemuParseCommandLinePid): Likewise. * src/qemu/qemu_driver.c (qemudGetProcessInfo, qemuDomainAttach): Likewise. * src/qemu/qemu_process.c (qemuProcessAttach): Likewise. * src/qemu/qemu_process.h (qemuProcessAttach): Likewise. * src/uml/uml_driver.c (umlGetProcessInfo): Likewise. * src/util/virnetdev.h (virNetDevSetNamespace): Likewise. * src/util/virnetdev.c (virNetDevSetNamespace): Likewise. * tests/testutils.c (virtTestCaptureProgramOutput): Likewise. * src/conf/storage_conf.h (_virStoragePerms): Use mode_t, uid_t, and gid_t rather than int. * src/security/security_dac.c (virSecurityDACSetOwnership): Likewise. * src/conf/storage_conf.c (virStorageDefParsePerms): Avoid compiler warning.
220 lines
9.1 KiB
C
220 lines
9.1 KiB
C
/*
|
|
* qemu_command.h: QEMU command generation
|
|
*
|
|
* Copyright (C) 2006-2012 Red Hat, Inc.
|
|
* Copyright (C) 2006 Daniel P. Berrange
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
* Author: Daniel P. Berrange <berrange@redhat.com>
|
|
*/
|
|
|
|
#ifndef __QEMU_COMMAND_H__
|
|
# define __QEMU_COMMAND_H__
|
|
|
|
# include "domain_conf.h"
|
|
# include "command.h"
|
|
# include "capabilities.h"
|
|
# include "qemu_conf.h"
|
|
# include "qemu_domain.h"
|
|
|
|
/* Config type for XML import/export conversions */
|
|
# define QEMU_CONFIG_FORMAT_ARGV "qemu-argv"
|
|
|
|
# define QEMU_DRIVE_HOST_PREFIX "drive-"
|
|
# define QEMU_VIRTIO_SERIAL_PREFIX "virtio-serial"
|
|
# define QEMU_FSDEV_HOST_PREFIX "fsdev-"
|
|
|
|
# define QEMU_VNC_PORT_MIN 5900
|
|
# define QEMU_VNC_PORT_MAX 65535
|
|
|
|
|
|
virCommandPtr qemuBuildCommandLine(virConnectPtr conn,
|
|
struct qemud_driver *driver,
|
|
virDomainDefPtr def,
|
|
virDomainChrSourceDefPtr monitor_chr,
|
|
bool monitor_json,
|
|
virBitmapPtr qemuCaps,
|
|
const char *migrateFrom,
|
|
int migrateFd,
|
|
virDomainSnapshotObjPtr current_snapshot,
|
|
enum virNetDevVPortProfileOp vmop)
|
|
ATTRIBUTE_NONNULL(1);
|
|
|
|
/* Generate string for arch-specific '-device' parameter */
|
|
char *
|
|
qemuBuildChrDeviceStr (virDomainChrDefPtr serial,
|
|
virBitmapPtr qemuCaps,
|
|
char *os_arch,
|
|
char *machine);
|
|
|
|
/* With vlan == -1, use netdev syntax, else old hostnet */
|
|
char * qemuBuildHostNetStr(virDomainNetDefPtr net,
|
|
char type_sep,
|
|
int vlan,
|
|
const char *tapfd,
|
|
const char *vhostfd);
|
|
|
|
/* Legacy, pre device support */
|
|
char * qemuBuildNicStr(virDomainNetDefPtr net,
|
|
const char *prefix,
|
|
int vlan);
|
|
|
|
/* Current, best practice */
|
|
char * qemuBuildNicDevStr(virDomainNetDefPtr net,
|
|
int vlan,
|
|
int bootindex,
|
|
virBitmapPtr qemuCaps);
|
|
|
|
char *qemuDeviceDriveHostAlias(virDomainDiskDefPtr disk,
|
|
virBitmapPtr qemuCaps);
|
|
|
|
/* Both legacy & current support */
|
|
char *qemuBuildDriveStr(virConnectPtr conn,
|
|
virDomainDiskDefPtr disk,
|
|
bool bootable,
|
|
virBitmapPtr qemuCaps);
|
|
char *qemuBuildFSStr(virDomainFSDefPtr fs,
|
|
virBitmapPtr qemuCaps);
|
|
|
|
/* Current, best practice */
|
|
char * qemuBuildDriveDevStr(virDomainDefPtr def,
|
|
virDomainDiskDefPtr disk,
|
|
int bootindex,
|
|
virBitmapPtr qemuCaps);
|
|
char * qemuBuildFSDevStr(virDomainFSDefPtr fs,
|
|
virBitmapPtr qemuCaps);
|
|
/* Current, best practice */
|
|
char * qemuBuildControllerDevStr(virDomainDefPtr domainDef,
|
|
virDomainControllerDefPtr def,
|
|
virBitmapPtr qemuCaps,
|
|
int *nusbcontroller);
|
|
|
|
char * qemuBuildWatchdogDevStr(virDomainWatchdogDefPtr dev,
|
|
virBitmapPtr qemuCaps);
|
|
|
|
char * qemuBuildMemballoonDevStr(virDomainMemballoonDefPtr dev,
|
|
virBitmapPtr qemuCaps);
|
|
|
|
char * qemuBuildUSBInputDevStr(virDomainInputDefPtr dev,
|
|
virBitmapPtr qemuCaps);
|
|
|
|
char * qemuBuildSoundDevStr(virDomainSoundDefPtr sound,
|
|
virBitmapPtr qemuCaps);
|
|
|
|
/* Legacy, pre device support */
|
|
char * qemuBuildPCIHostdevPCIDevStr(virDomainHostdevDefPtr dev);
|
|
/* Current, best practice */
|
|
char * qemuBuildPCIHostdevDevStr(virDomainHostdevDefPtr dev,
|
|
const char *configfd,
|
|
virBitmapPtr qemuCaps);
|
|
|
|
int qemuOpenPCIConfig(virDomainHostdevDefPtr dev);
|
|
|
|
/* Legacy, pre device support */
|
|
char * qemuBuildUSBHostdevUsbDevStr(virDomainHostdevDefPtr dev);
|
|
/* Current, best practice */
|
|
char * qemuBuildUSBHostdevDevStr(virDomainHostdevDefPtr dev,
|
|
virBitmapPtr qemuCaps);
|
|
|
|
char * qemuBuildHubDevStr(virDomainHubDefPtr dev, virBitmapPtr qemuCaps);
|
|
char * qemuBuildRedirdevDevStr(virDomainRedirdevDefPtr dev, virBitmapPtr qemuCaps);
|
|
|
|
|
|
int qemuNetworkIfaceConnect(virDomainDefPtr def,
|
|
virConnectPtr conn,
|
|
struct qemud_driver *driver,
|
|
virDomainNetDefPtr net,
|
|
virBitmapPtr qemuCaps)
|
|
ATTRIBUTE_NONNULL(2);
|
|
|
|
int qemuPhysIfaceConnect(virDomainDefPtr def,
|
|
struct qemud_driver *driver,
|
|
virDomainNetDefPtr net,
|
|
virBitmapPtr qemuCaps,
|
|
enum virNetDevVPortProfileOp vmop);
|
|
|
|
int qemuOpenVhostNet(virDomainDefPtr def,
|
|
virDomainNetDefPtr net,
|
|
virBitmapPtr qemuCaps,
|
|
int *vhostfd);
|
|
|
|
int qemudCanonicalizeMachine(struct qemud_driver *driver,
|
|
virDomainDefPtr def);
|
|
|
|
/*
|
|
* NB: def->name can be NULL upon return and the caller
|
|
* *must* decide how to fill in a name in this case
|
|
*/
|
|
virDomainDefPtr qemuParseCommandLine(virCapsPtr caps,
|
|
const char **progenv,
|
|
const char **progargv,
|
|
char **pidfile,
|
|
virDomainChrSourceDefPtr *monConfig,
|
|
bool *monJSON);
|
|
virDomainDefPtr qemuParseCommandLineString(virCapsPtr caps,
|
|
const char *args,
|
|
char **pidfile,
|
|
virDomainChrSourceDefPtr *monConfig,
|
|
bool *monJSON);
|
|
virDomainDefPtr qemuParseCommandLinePid(virCapsPtr caps,
|
|
pid_t pid,
|
|
char **pidfile,
|
|
virDomainChrSourceDefPtr *monConfig,
|
|
bool *monJSON);
|
|
|
|
int qemuDomainAssignAddresses(virDomainDefPtr def);
|
|
int qemuDomainAssignSpaprVIOAddresses(virDomainDefPtr def);
|
|
|
|
int qemuDomainAssignPCIAddresses(virDomainDefPtr def);
|
|
qemuDomainPCIAddressSetPtr qemuDomainPCIAddressSetCreate(virDomainDefPtr def);
|
|
int qemuDomainPCIAddressReserveFunction(qemuDomainPCIAddressSetPtr addrs,
|
|
int slot, int function);
|
|
int qemuDomainPCIAddressReserveSlot(qemuDomainPCIAddressSetPtr addrs,
|
|
int slot);
|
|
int qemuDomainPCIAddressReserveAddr(qemuDomainPCIAddressSetPtr addrs,
|
|
virDomainDeviceInfoPtr dev);
|
|
int qemuDomainPCIAddressSetNextAddr(qemuDomainPCIAddressSetPtr addrs,
|
|
virDomainDeviceInfoPtr dev);
|
|
int qemuDomainPCIAddressEnsureAddr(qemuDomainPCIAddressSetPtr addrs,
|
|
virDomainDeviceInfoPtr dev);
|
|
int qemuDomainPCIAddressReleaseAddr(qemuDomainPCIAddressSetPtr addrs,
|
|
virDomainDeviceInfoPtr dev);
|
|
int qemuDomainPCIAddressReleaseFunction(qemuDomainPCIAddressSetPtr addrs,
|
|
int slot, int function);
|
|
int qemuDomainPCIAddressReleaseSlot(qemuDomainPCIAddressSetPtr addrs, int slot);
|
|
|
|
void qemuDomainPCIAddressSetFree(qemuDomainPCIAddressSetPtr addrs);
|
|
int qemuAssignDevicePCISlots(virDomainDefPtr def, qemuDomainPCIAddressSetPtr addrs);
|
|
|
|
int qemuAssignDeviceAliases(virDomainDefPtr def, virBitmapPtr qemuCaps);
|
|
int qemuDomainNetVLAN(virDomainNetDefPtr def);
|
|
int qemuAssignDeviceNetAlias(virDomainDefPtr def, virDomainNetDefPtr net, int idx);
|
|
int qemuAssignDeviceDiskAlias(virDomainDefPtr vmdef,
|
|
virDomainDiskDefPtr def,
|
|
virBitmapPtr qemuCaps);
|
|
int qemuAssignDeviceHostdevAlias(virDomainDefPtr def, virDomainHostdevDefPtr hostdev, int idx);
|
|
int qemuAssignDeviceControllerAlias(virDomainControllerDefPtr controller);
|
|
int qemuAssignDeviceRedirdevAlias(virDomainDefPtr def, virDomainRedirdevDefPtr redirdev, int idx);
|
|
|
|
int
|
|
qemuParseKeywords(const char *str,
|
|
char ***retkeywords,
|
|
char ***retvalues,
|
|
int allowEmptyValue);
|
|
|
|
|
|
#endif /* __QEMU_COMMAND_H__*/
|