libvirt/src
Michal Privoznik 4e9d72be02 domain_conf: Unref video private data in virDomainVideoDefClear()
The private data for video definition is created in
virDomainVideoDefNew() and we attempt to free it in
virDomainVideoDefFree(). This seems to work, except
the free function calls clear function which zeroes
out the whole structure and thus virObjectUnref()
which is called on private data does nothing.

2,568 bytes in 107 blocks are definitely lost in loss record 207 of 213
   at 0x4A35476: calloc (vg_replace_malloc.c:752)
   by 0x50A6048: virAllocVar (viralloc.c:346)
   by 0x513CC5A: virObjectNew (virobject.c:243)
   by 0x4DC1DEE: qemuDomainVideoPrivateNew (qemu_domain.c:1337)
   by 0x51A6BD6: virDomainVideoDefNew (domain_conf.c:2831)
   by 0x51B9F06: virDomainVideoDefParseXML (domain_conf.c:15541)
   by 0x51CB761: virDomainDefParseXML (domain_conf.c:21158)
   by 0x51C5973: virDomainDefParseNode (domain_conf.c:21708)
   by 0x51C583A: virDomainDefParse (domain_conf.c:21663)
   by 0x51C58AE: virDomainDefParseFile (domain_conf.c:21688)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
2019-09-26 16:57:59 +02:00
..
access util: sanitize return values for virIdentity getters 2019-09-16 11:25:34 +01:00
admin util: sanitize return values for virIdentity getters 2019-09-16 11:25:34 +01:00
bhyve lib: Define and use autofree for virConfPtr 2019-09-10 09:34:37 +02:00
conf domain_conf: Unref video private data in virDomainVideoDefClear() 2019-09-26 16:57:59 +02:00
cpu conf: add support for Direct Mode for Hyper-V Synthetic timers 2019-08-19 11:38:28 +02:00
cpu_map cpu_map: Introduce IA32_ARCH_CAPABILITIES MSR features 2019-06-20 14:02:36 +02:00
esx build: force a UTF-8 locale for python 2019-09-24 15:46:22 +01:00
hyperv build: force a UTF-8 locale for python 2019-09-24 15:46:22 +01:00
interface build: ensure Makefile.inc.am is checked for long lines 2019-09-24 11:50:27 +01:00
keycodemapdb@6280c94f30 keycodemapdb: Update submodule 2019-04-15 16:18:00 +02:00
libxl build: ensure Makefile.inc.am is checked for long lines 2019-09-24 11:50:27 +01:00
locking util: remove some no-op thread functions 2019-09-19 12:50:21 +01:00
logging util: remove some no-op thread functions 2019-09-19 12:50:21 +01:00
lxc util: remove some no-op thread functions 2019-09-19 12:50:21 +01:00
network build: ensure Makefile.inc.am is checked for long lines 2019-09-24 11:50:27 +01:00
node_device build: ensure Makefile.inc.am is checked for long lines 2019-09-24 11:50:27 +01:00
nwfilter build: ensure Makefile.inc.am is checked for long lines 2019-09-24 11:50:27 +01:00
openvz qemu: Pass correct qemuCaps to virDomainDeviceDefPostParse 2019-08-09 13:55:54 +02:00
phyp qemu: Pass correct qemuCaps to virDomainDeviceDefPostParse 2019-08-09 13:55:54 +02:00
qemu qemu: driver: Remove unused cleanup labels in stats gathering functions 2019-09-25 13:02:48 +02:00
remote remote: fix enablement of IP networking in virtproxyd 2019-09-20 15:02:40 +01:00
rpc remote: pass identity across to newly opened daemons 2019-09-16 11:25:53 +01:00
secret build: ensure Makefile.inc.am is checked for long lines 2019-09-24 11:50:27 +01:00
security util: remove some no-op thread functions 2019-09-19 12:50:21 +01:00
storage build: ensure Makefile.inc.am is checked for long lines 2019-09-24 11:50:27 +01:00
test virStoragePoolObjListAdd: Turn boolean arg into flags 2019-08-22 17:09:05 +02:00
util util: typedparam: Simplify handling of lists of typed parameters 2019-09-25 13:02:48 +02:00
vbox util: xml: Add wrapper for xmlXPathNewContext 2019-09-19 14:31:15 +02:00
vmware lib: Grab write lock when modifying list of domains 2019-09-07 08:22:30 +02:00
vmx lib: Define and use autofree for virConfPtr 2019-09-10 09:34:37 +02:00
vz conf: add privateData to virDomainVideoDef 2019-09-24 13:19:08 -04:00
admin_protocol-structs
check-aclperms.pl
check-aclrules.pl qemu: delete methods which are no longer supported 2019-06-27 14:41:48 +01:00
check-driverimpls.pl maint: Drop dead code in check-driverimpls.pl 2019-07-10 11:46:22 -05:00
check-drivername.pl
check-symfile.pl
check-symsorting.pl
datatypes.c network: add public APIs for network port object 2019-06-17 15:19:54 +01:00
datatypes.h network: add public APIs for network port object 2019-06-17 15:19:54 +01:00
driver-hypervisor.h api: introduce virConnectSetIdentity for passing uid, gid, selinux info 2019-09-16 11:25:01 +01:00
driver-interface.h Use #pragma once in driver headers 2019-06-13 17:05:08 +02:00
driver-network.h network: add public APIs for network port object 2019-06-17 15:19:54 +01:00
driver-nodedev.h Use #pragma once in driver headers 2019-06-13 17:05:08 +02:00
driver-nwfilter.h Use #pragma once in driver headers 2019-06-13 17:05:08 +02:00
driver-secret.h Use #pragma once in driver headers 2019-06-13 17:05:08 +02:00
driver-state.h remote: in per-driver daemons ensure that state initialize succeeds 2019-08-09 14:06:31 +01:00
driver-storage.h Use #pragma once in driver headers 2019-06-13 17:05:08 +02:00
driver-stream.h Use #pragma once in driver headers 2019-06-13 17:05:08 +02:00
driver.c Fix names for abs_top_{src,build}dir variables 2019-03-14 10:05:28 +01:00
driver.h remote: enable connecting to the per-driver daemons 2019-08-09 14:06:31 +01:00
dtrace2systemtap.pl Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
internal.h build: bump min required gcc to 4.8 2019-08-07 14:26:12 +01:00
libvirt_admin_private.syms
libvirt_admin_public.syms
libvirt_atomic.syms
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_internal.h remote: in per-driver daemons ensure that state initialize succeeds 2019-08-09 14:06:31 +01:00
libvirt_libssh2.syms
libvirt_libssh.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms util: typedparam: Simplify handling of lists of typed parameters 2019-09-25 13:02:48 +02:00
libvirt_probes.d
libvirt_public.syms api: introduce virConnectSetIdentity for passing uid, gid, selinux info 2019-09-16 11:25:01 +01:00
libvirt_qemu_probes.d
libvirt_qemu.syms
libvirt_remote.syms remote: pass identity across to newly opened daemons 2019-09-16 11:25:53 +01:00
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms
libvirt-admin.c util: remove some no-op thread functions 2019-09-19 12:50:21 +01:00
libvirt-admin.conf
libvirt-domain-checkpoint.c backup: Introduce virDomainCheckpoint APIs 2019-07-26 16:48:58 -05:00
libvirt-domain-snapshot.c snapshot: Add VIR_DOMAIN_SNAPSHOT_CREATE_VALIDATE flag 2019-07-10 17:34:58 -05:00
libvirt-domain.c lib: Lessen restrictions on VIR_DOMAIN_START_AUTODESTROY 2019-09-25 08:38:51 +02:00
libvirt-host.c api: introduce virConnectSetIdentity for passing uid, gid, selinux info 2019-09-16 11:25:01 +01:00
libvirt-interface.c docs: Consistent spacing in *GetXMLDesc functions 2019-03-13 20:28:52 -05:00
libvirt-lxc.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
libvirt-lxc.pc.in
libvirt-network.c virNetworkGetDHCPLeases: fix docstring format 2019-06-20 15:49:19 +02:00
libvirt-nodedev.c
libvirt-nwfilter.c docs: Consistent spacing in *GetXMLDesc functions 2019-03-13 20:28:52 -05:00
libvirt-qemu.c Remove all Author(s): lines from source file headers 2018-12-13 16:08:38 +00:00
libvirt-qemu.pc.in
libvirt-secret.c
libvirt-storage.c storage: Add iscsi-direct pool list type flag 2019-07-13 17:40:09 +02:00
libvirt-stream.c
libvirt.c util: remove some no-op thread functions 2019-09-19 12:50:21 +01:00
libvirt.conf
libvirt.pc.in
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
Makefile.am xenapi: remove driver 2019-09-03 15:37:54 -06:00
qemu_protocol-structs
README xenapi: remove driver 2019-09-03 15:37:54 -06:00
remote_protocol-structs remote: pass identity across to newly opened daemons 2019-09-16 11:25:53 +01:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories