mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-30 01:43:23 +00:00
eca72d4759
The previously introduced virFile{Lock,Unlock} APIs provide a
way to acquire/release fcntl() locks on individual files. For
unknown reason though, the POSIX spec says that fcntl() locks
are released when *any* file handle referring to the same path
is closed. In the following sequence
threadA: fd1 = open("foo")
threadB: fd2 = open("foo")
threadA: virFileLock(fd1)
threadB: virFileLock(fd2)
threadB: close(fd2)
you'd expect threadA to come out holding a lock on 'foo', and
indeed it does hold a lock for a very short time. Unfortunately
when threadB does close(fd2) this releases the lock associated
with fd1. For the current libvirt use case for virFileLock -
pidfiles - this doesn't matter since the lock is acquired
at startup while single threaded an never released until
exit.
To provide a more generally useful API though, it is necessary
to introduce a slightly higher level abstraction, which is to
be referred to as a "lockspace". This is to be provided by
a virLockSpacePtr object in src/util/virlockspace.{c,h}. The
core idea is that the lockspace keeps track of what files are
already open+locked. This means that when a 2nd thread comes
along and tries to acquire a lock, it doesn't end up opening
and closing a new FD. The lockspace just checks the current
list of held locks and immediately returns VIR_ERR_RESOURCE_BUSY.
NB, the API as it stands is designed on the basis that the
files being locked are not being otherwise opened and used
by the application code. One approach to using this API is to
acquire locks based on a hash of the filepath.
eg to lock /var/lib/libvirt/images/foo.img the application
might do
virLockSpacePtr lockspace = virLockSpaceNew("/var/lib/libvirt/imagelocks");
lockname = md5sum("/var/lib/libvirt/images/foo.img");
virLockSpaceAcquireLock(lockspace, lockname);
NB, in this example, the caller should ensure that the path
is canonicalized before calculating the checksum.
It is also possible to do locks directly on resources by
using a NULL lockspace directory and then using the file
path as the lock name eg
virLockSpacePtr lockspace = virLockSpaceNew(NULL);
virLockSpaceAcquireLock(lockspace, "/var/lib/libvirt/images/foo.img");
This is only safe to do though if no other part of the process
will be opening the files. This will be the case when this
code is used inside the soon-to-be-reposted virlockd daemon
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
364 lines
8.8 KiB
C
364 lines
8.8 KiB
C
/*
|
|
* Copyright (C) 2011 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Author: Daniel P. Berrange <berrange@redhat.com>
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include <stdlib.h>
|
|
#include <signal.h>
|
|
#include <sys/stat.h>
|
|
|
|
#include "testutils.h"
|
|
#include "util.h"
|
|
#include "virterror_internal.h"
|
|
#include "memory.h"
|
|
#include "logging.h"
|
|
|
|
#include "virlockspace.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_RPC
|
|
|
|
#define LOCKSPACE_DIR abs_builddir "/virlockspacedata"
|
|
|
|
static int testLockSpaceCreate(const void *args ATTRIBUTE_UNUSED)
|
|
{
|
|
virLockSpacePtr lockspace;
|
|
int ret = -1;
|
|
|
|
rmdir(LOCKSPACE_DIR);
|
|
|
|
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
|
|
|
|
if (!virFileIsDir(LOCKSPACE_DIR))
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
virLockSpaceFree(lockspace);
|
|
rmdir(LOCKSPACE_DIR);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int testLockSpaceResourceLifecycle(const void *args ATTRIBUTE_UNUSED)
|
|
{
|
|
virLockSpacePtr lockspace;
|
|
int ret = -1;
|
|
|
|
rmdir(LOCKSPACE_DIR);
|
|
|
|
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
|
|
|
|
if (!virFileIsDir(LOCKSPACE_DIR))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceCreateResource(lockspace, "foo") < 0)
|
|
goto cleanup;
|
|
|
|
if (!virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceDeleteResource(lockspace, "foo") < 0)
|
|
goto cleanup;
|
|
|
|
if (virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
virLockSpaceFree(lockspace);
|
|
rmdir(LOCKSPACE_DIR);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int testLockSpaceResourceLockExcl(const void *args ATTRIBUTE_UNUSED)
|
|
{
|
|
virLockSpacePtr lockspace;
|
|
int ret = -1;
|
|
|
|
rmdir(LOCKSPACE_DIR);
|
|
|
|
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
|
|
|
|
if (!virFileIsDir(LOCKSPACE_DIR))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceCreateResource(lockspace, "foo") < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, "foo", geteuid(), 0) < 0)
|
|
goto cleanup;
|
|
|
|
if (!virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, "foo", geteuid(), 0) == 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceDeleteResource(lockspace, "foo") == 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceReleaseResource(lockspace, "foo", geteuid()) < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceDeleteResource(lockspace, "foo") < 0)
|
|
goto cleanup;
|
|
|
|
if (virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
virLockSpaceFree(lockspace);
|
|
rmdir(LOCKSPACE_DIR);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int testLockSpaceResourceLockExclAuto(const void *args ATTRIBUTE_UNUSED)
|
|
{
|
|
virLockSpacePtr lockspace;
|
|
int ret = -1;
|
|
|
|
rmdir(LOCKSPACE_DIR);
|
|
|
|
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
|
|
|
|
if (!virFileIsDir(LOCKSPACE_DIR))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceCreateResource(lockspace, "foo") < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, "foo", geteuid(),
|
|
VIR_LOCK_SPACE_ACQUIRE_AUTOCREATE) < 0)
|
|
goto cleanup;
|
|
|
|
if (!virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceReleaseResource(lockspace, "foo", geteuid()) < 0)
|
|
goto cleanup;
|
|
|
|
if (virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
virLockSpaceFree(lockspace);
|
|
rmdir(LOCKSPACE_DIR);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int testLockSpaceResourceLockShr(const void *args ATTRIBUTE_UNUSED)
|
|
{
|
|
virLockSpacePtr lockspace;
|
|
int ret = -1;
|
|
|
|
rmdir(LOCKSPACE_DIR);
|
|
|
|
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
|
|
|
|
if (!virFileIsDir(LOCKSPACE_DIR))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceCreateResource(lockspace, "foo") < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, "foo", geteuid(),
|
|
VIR_LOCK_SPACE_ACQUIRE_SHARED) < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, "foo", geteuid(), 0) == 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, "foo", geteuid(),
|
|
VIR_LOCK_SPACE_ACQUIRE_SHARED) < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceDeleteResource(lockspace, "foo") == 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceReleaseResource(lockspace, "foo", geteuid()) < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceDeleteResource(lockspace, "foo") == 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceReleaseResource(lockspace, "foo", geteuid()) < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceDeleteResource(lockspace, "foo") < 0)
|
|
goto cleanup;
|
|
|
|
if (virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
virLockSpaceFree(lockspace);
|
|
rmdir(LOCKSPACE_DIR);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int testLockSpaceResourceLockShrAuto(const void *args ATTRIBUTE_UNUSED)
|
|
{
|
|
virLockSpacePtr lockspace;
|
|
int ret = -1;
|
|
|
|
rmdir(LOCKSPACE_DIR);
|
|
|
|
lockspace = virLockSpaceNew(LOCKSPACE_DIR);
|
|
|
|
if (!virFileIsDir(LOCKSPACE_DIR))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceCreateResource(lockspace, "foo") < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, "foo", geteuid(),
|
|
VIR_LOCK_SPACE_ACQUIRE_SHARED |
|
|
VIR_LOCK_SPACE_ACQUIRE_AUTOCREATE) < 0)
|
|
goto cleanup;
|
|
|
|
if (!virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, "foo", geteuid(),
|
|
VIR_LOCK_SPACE_ACQUIRE_AUTOCREATE) == 0)
|
|
goto cleanup;
|
|
|
|
if (!virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, "foo", geteuid(),
|
|
VIR_LOCK_SPACE_ACQUIRE_SHARED |
|
|
VIR_LOCK_SPACE_ACQUIRE_AUTOCREATE) < 0)
|
|
goto cleanup;
|
|
|
|
if (!virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceReleaseResource(lockspace, "foo", geteuid()) < 0)
|
|
goto cleanup;
|
|
|
|
if (!virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceReleaseResource(lockspace, "foo", geteuid()) < 0)
|
|
goto cleanup;
|
|
|
|
if (virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
virLockSpaceFree(lockspace);
|
|
rmdir(LOCKSPACE_DIR);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int testLockSpaceResourceLockPath(const void *args ATTRIBUTE_UNUSED)
|
|
{
|
|
virLockSpacePtr lockspace;
|
|
int ret = -1;
|
|
|
|
rmdir(LOCKSPACE_DIR);
|
|
|
|
lockspace = virLockSpaceNew(NULL);
|
|
|
|
mkdir(LOCKSPACE_DIR, 0700);
|
|
|
|
if (virLockSpaceCreateResource(lockspace, LOCKSPACE_DIR "/foo") < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, LOCKSPACE_DIR "/foo", geteuid(), 0) < 0)
|
|
goto cleanup;
|
|
|
|
if (!virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceAcquireResource(lockspace, LOCKSPACE_DIR "/foo", geteuid(), 0) == 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceDeleteResource(lockspace, LOCKSPACE_DIR "/foo") == 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceReleaseResource(lockspace, LOCKSPACE_DIR "/foo", geteuid()) < 0)
|
|
goto cleanup;
|
|
|
|
if (virLockSpaceDeleteResource(lockspace, LOCKSPACE_DIR "/foo") < 0)
|
|
goto cleanup;
|
|
|
|
if (virFileExists(LOCKSPACE_DIR "/foo"))
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
virLockSpaceFree(lockspace);
|
|
rmdir(LOCKSPACE_DIR);
|
|
return ret;
|
|
}
|
|
|
|
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
|
|
signal(SIGPIPE, SIG_IGN);
|
|
|
|
if (virtTestRun("Lockspace creation", 1, testLockSpaceCreate, NULL) < 0)
|
|
ret = -1;
|
|
|
|
if (virtTestRun("Lockspace res lifecycle", 1, testLockSpaceResourceLifecycle, NULL) < 0)
|
|
ret = -1;
|
|
|
|
if (virtTestRun("Lockspace res lock excl", 1, testLockSpaceResourceLockExcl, NULL) < 0)
|
|
ret = -1;
|
|
|
|
if (virtTestRun("Lockspace res lock shr", 1, testLockSpaceResourceLockShr, NULL) < 0)
|
|
ret = -1;
|
|
|
|
if (virtTestRun("Lockspace res lock excl auto", 1, testLockSpaceResourceLockExclAuto, NULL) < 0)
|
|
ret = -1;
|
|
|
|
if (virtTestRun("Lockspace res lock shr auto", 1, testLockSpaceResourceLockShrAuto, NULL) < 0)
|
|
ret = -1;
|
|
|
|
if (virtTestRun("Lockspace res full path", 1, testLockSpaceResourceLockPath, NULL) < 0)
|
|
ret = -1;
|
|
|
|
return ret==0 ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
VIRT_TEST_MAIN(mymain)
|