libvirt/src
Michal Privoznik 52f50a7160 virEventPollDispatchHandles: Honour array boundaries
When dispatching events from the event loop, the array of registered
handles is searched to see what handles happened an event on. However,
the array is searched in weird way: the check for the array boundaries
is at the end, so we may touch the elements after the end of the
array:

==10434== Invalid read of size 4
==10434==    at 0x52D06B6: virEventPollDispatchHandles (vireventpoll.c:486)
==10434==    by 0x52D10E4: virEventPollRunOnce (vireventpoll.c:660)
==10434==    by 0x52CF207: virEventRunDefaultImpl (virevent.c:308)
==10434==    by 0x1639D1: virNetServerRun (virnetserver.c:1139)
==10434==    by 0x1220DC: main (libvirtd.c:1507)
==10434==  Address 0xc11ff04 is 4 bytes after a block of size 960 alloc'd
==10434==    at 0x4C2CA5E: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==10434==    by 0x52AD378: virReallocN (viralloc.c:245)
==10434==    by 0x52AD46E: virExpandN (viralloc.c:294)
==10434==    by 0x52AD5B1: virResizeN (viralloc.c:352)
==10434==    by 0x52CF2EC: virEventPollAddHandle (vireventpoll.c:116)
==10434==    by 0x52CEF5B: virEventAddHandle (virevent.c:78)
==10434==    by 0x11F69A90: nodeStateInitialize (node_device_udev.c:1797)
==10434==    by 0x53C3C89: virStateInitialize (libvirt.c:743)
==10434==    by 0x120563: daemonRunStateInit (libvirtd.c:919)
==10434==    by 0x5317719: virThreadHelper (virthread.c:197)
==10434==    by 0x8376F39: start_thread (in /lib64/libpthread-2.17.so)
==10434==    by 0x8A7F9FC: clone (in /lib64/libc-2.17.so)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2014-07-09 10:22:51 +02:00
..
access Introduce virDomain{Get,Set}Time APIs 2014-05-15 16:15:54 +02:00
bhyve Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
conf Allow updating names in DHCP hosts by matching IPs. 2014-07-09 09:23:02 +02:00
cpu Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
esx Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
hyperv Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
interface interface_backend_udev: Implement link speed & state 2014-06-11 09:57:45 +02:00
libxl libxl: fix crash in migrate confirm for transient domains 2014-07-08 17:14:50 -06:00
locking storage: Move readonly and shared flags to disk source from disk def 2014-07-08 14:27:19 +02:00
lxc LXC: fix an improper comments for lxcDomainDestroyFlags 2014-07-08 15:45:43 -06:00
network Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
node_device Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
nwfilter Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
openvz Use virStringReplace instead of openvz_replace 2014-07-03 10:41:15 +02:00
parallels Report errors in virCapabilitiesFormatXML 2014-07-03 10:43:39 +02:00
phyp Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
qemu qemu: raise an eror when using aio=native without cache=none 2014-07-08 15:27:10 -06:00
remote Free the return value of virFileFindResource 2014-07-07 08:32:11 +02:00
rpc Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
secret drivers: use virDirRead API 2014-04-28 17:52:45 -06:00
security storage: Move readonly and shared flags to disk source from disk def 2014-07-08 14:27:19 +02:00
storage storage: file: Tolerate NULL src when uninitializing the backend 2014-07-08 14:27:19 +02:00
test Report errors in virCapabilitiesFormatXML 2014-07-03 10:43:39 +02:00
uml Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
util virEventPollDispatchHandles: Honour array boundaries 2014-07-09 10:22:51 +02:00
vbox storage: Move readonly and shared flags to disk source from disk def 2014-07-08 14:27:19 +02:00
vmware vmware: make version parsing more robust 2014-06-11 14:56:18 +02:00
vmx Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
xen Use virBufferCheckError everywhere we report OOM error 2014-07-03 10:48:14 +02:00
xenapi xenapiConnectGetCapabilities: Remove unused 'cleanup' label 2014-07-03 12:21:00 +02:00
xenxs storage: Move readonly and shared flags to disk source from disk def 2014-07-08 14:27:19 +02:00
check-aclperms.pl
check-aclrules.pl maint: fix line numbers in check-aclrules reports 2014-02-10 14:07:22 -07:00
check-driverimpls.pl
check-drivername.pl
check-symfile.pl
check-symsorting.pl
datatypes.c Indent top-level labels by one space in the rest of src/ 2014-03-25 14:58:40 +01:00
datatypes.h datatypes: Fix comment of secret uuid 2014-05-05 10:20:51 +02:00
driver.c Use virFileFindResource to locate driver plugins 2014-04-25 11:59:46 +01:00
driver.h Introduce virConnectGetDomainCapabilities 2014-07-03 12:22:37 +02:00
dtrace2systemtap.pl
fdstream.c Use virFileFindResource to locate iohelper for fdstream 2014-04-25 11:59:46 +01:00
fdstream.h Use virFileFindResource to locate iohelper for fdstream 2014-04-25 11:59:46 +01:00
gnutls_1_0_compat.h
internal.h net-dhcp-leases: Add virsh support 2014-06-24 12:26:31 +01:00
libvirt_atomic.syms
libvirt_daemon.syms
libvirt_driver_modules.syms Use virFileFindResource to locate driver plugins 2014-04-25 11:59:46 +01:00
libvirt_esx.syms
libvirt_gnutls.syms
libvirt_internal.h event: server RPC protocol tweaks for domain lifecycle events 2014-02-12 10:48:15 -07:00
libvirt_libssh2.syms
libvirt_linux.syms Add test for linuxNodeGetCPUStats 2014-01-27 11:04:02 +01:00
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms util: cgroup: Add helper to convert device mode to string 2014-07-08 14:34:05 +02:00
libvirt_probes.d
libvirt_public.syms Introduce virConnectGetDomainCapabilities 2014-07-03 12:22:37 +02:00
libvirt_qemu_probes.d
libvirt_qemu.syms qemu: new API for tracking arbitrary monitor events 2014-03-20 11:25:37 -06:00
libvirt_remote.syms
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms
libvirt_xenxs.syms
libvirt-lxc.c Indent top-level labels by one space in the rest of src/ 2014-03-25 14:58:40 +01:00
libvirt-lxc.pc.in Add pkg-config files to allow deps to build against source tree 2014-06-23 16:17:55 +01:00
libvirt-qemu.c Indent top-level labels by one space in the rest of src/ 2014-03-25 14:58:40 +01:00
libvirt-qemu.pc.in Add pkg-config files to allow deps to build against source tree 2014-06-23 16:17:55 +01:00
libvirt.c Document the need to free vir*Ptr objects per-function 2014-07-09 09:22:20 +02:00
libvirt.conf
libvirt.pc.in Add pkg-config files to allow deps to build against source tree 2014-06-23 16:17:55 +01:00
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
Makefile.am Introduce domain_capabilities 2014-07-03 12:22:37 +02:00
nodeinfo.c virNumaGetPageInfo: Take huge pages into account 2014-06-24 11:50:31 +02:00
nodeinfo.h nodeinfo: Implement nodeGetFreePages 2014-06-19 15:10:50 +02:00
nodeinfopriv.h nodeinfo: Introduce @arch to linuxNodeInfoCPUPopulate 2014-06-20 15:46:52 +02:00
qemu_protocol-structs qemu: wire up RPC for qemu monitor events 2014-03-20 11:25:37 -06:00
README bhyve: add basic documentation 2014-03-01 23:44:58 +04:00
remote_protocol-structs Introduce virConnectGetDomainCapabilities 2014-07-03 12:22:37 +02:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories