libvirt/tests/virtestmock.c
Andrea Bolognani 530cecdb7b tests: Fix mode_t usage with va_arg()
Clang complains about it:

  error: second argument to 'va_arg' is of promotable type
  'mode_t' (aka 'unsigned short'); this va_arg has undefined
  behavior because arguments will be promoted to 'int'
  [-Werror,-Wvarargs]

    mode = va_arg(ap, mode_t);
                      ^~~~~~

Work around the issue by passing int to va_arg() and casting
its return value to mode_t afterwards.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
2018-05-03 18:23:30 +02:00

324 lines
7.6 KiB
C

/*
* Copyright (C) 2016 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see
* <http://www.gnu.org/licenses/>.
*
* Author: Michal Privoznik <mprivozn@redhat.com>
*/
#include <config.h>
#include "virmock.h"
#include <unistd.h>
#include <sys/types.h>
#include <fcntl.h>
#include <execinfo.h>
#include <sys/file.h>
#include <sys/stat.h>
#include "internal.h"
#include "configmake.h"
#include "virstring.h"
#include "viralloc.h"
#include "virfile.h"
/* stat can be a macro as follows:
*
* #define stat stat64
*
* This wouldn't fly with our mock. Make sure that the macro (and
* all its friends) are undefined. We don't want anybody mangling
* our code. */
#undef stat
#undef stat64
#undef __xstat
#undef __xstat64
#undef lstat
#undef lstat64
#undef __lxstat
#undef __lxstat64
static int (*real_open)(const char *path, int flags, ...);
static FILE *(*real_fopen)(const char *path, const char *mode);
static int (*real_access)(const char *path, int mode);
static int (*real_stat)(const char *path, struct stat *sb);
static int (*real_stat64)(const char *path, void *sb);
static int (*real___xstat)(int ver, const char *path, struct stat *sb);
static int (*real___xstat64)(int ver, const char *path, void *sb);
static int (*real_lstat)(const char *path, struct stat *sb);
static int (*real_lstat64)(const char *path, void *sb);
static int (*real___lxstat)(int ver, const char *path, struct stat *sb);
static int (*real___lxstat64)(int ver, const char *path, void *sb);
static const char *progname;
const char *output;
#define VIR_FILE_ACCESS_DEFAULT abs_builddir "/test_file_access.txt"
static void init_syms(void)
{
if (real_open)
return;
VIR_MOCK_REAL_INIT(open);
VIR_MOCK_REAL_INIT(fopen);
VIR_MOCK_REAL_INIT(access);
VIR_MOCK_REAL_INIT_ALT(stat, __xstat);
VIR_MOCK_REAL_INIT_ALT(stat64, __xstat64);
VIR_MOCK_REAL_INIT_ALT(lstat, __lxstat);
VIR_MOCK_REAL_INIT_ALT(lstat64, __lxstat64);
}
static void
printFile(const char *file)
{
FILE *fp;
const char *testname = getenv("VIR_TEST_MOCK_TESTNAME");
if (!progname) {
progname = getenv("VIR_TEST_MOCK_PROGNAME");
if (!progname)
return;
output = getenv("VIR_TEST_FILE_ACCESS_OUTPUT");
if (!output)
output = VIR_FILE_ACCESS_DEFAULT;
}
if (!(fp = real_fopen(output, "a"))) {
fprintf(stderr, "Unable to open %s: %s\n", output, strerror(errno));
abort();
}
if (flock(fileno(fp), LOCK_EX) < 0) {
fprintf(stderr, "Unable to lock %s: %s\n", output, strerror(errno));
fclose(fp);
abort();
}
/* Now append the following line into the output file:
* $file: $progname $testname */
fprintf(fp, "%s: %s", file, progname);
if (testname)
fprintf(fp, ": %s", testname);
fputc('\n', fp);
flock(fileno(fp), LOCK_UN);
fclose(fp);
}
static void
checkPath(const char *path)
{
char *fullPath = NULL;
char *relPath = NULL;
char *crippledPath = NULL;
if (path[0] != '/' &&
virAsprintfQuiet(&relPath, "./%s", path) < 0)
goto error;
/* Le sigh. virFileCanonicalizePath() expects @path to exist, otherwise
* it will return an error. So if we are called over an non-existent
* file, this could return an error. In that case do our best and hope
* we will catch possible errors. */
if ((fullPath = virFileCanonicalizePath(relPath ? relPath : path))) {
path = fullPath;
} else {
/* Yeah, our worst nightmares just became true. Path does
* not exist. Cut off the last component and retry. */
if (VIR_STRDUP_QUIET(crippledPath, relPath ? relPath : path) < 0)
goto error;
virFileRemoveLastComponent(crippledPath);
if ((fullPath = virFileCanonicalizePath(crippledPath)))
path = fullPath;
}
if (!STRPREFIX(path, abs_topsrcdir) &&
!STRPREFIX(path, abs_topbuilddir)) {
printFile(path);
}
VIR_FREE(crippledPath);
VIR_FREE(relPath);
VIR_FREE(fullPath);
return;
error:
fprintf(stderr, "Out of memory\n");
abort();
}
int open(const char *path, int flags, ...)
{
int ret;
init_syms();
checkPath(path);
if (flags & O_CREAT) {
va_list ap;
mode_t mode;
va_start(ap, flags);
mode = (mode_t) va_arg(ap, int);
va_end(ap);
ret = real_open(path, flags, mode);
} else {
ret = real_open(path, flags);
}
return ret;
}
FILE *fopen(const char *path, const char *mode)
{
init_syms();
checkPath(path);
return real_fopen(path, mode);
}
int access(const char *path, int mode)
{
init_syms();
checkPath(path);
return real_access(path, mode);
}
/* Okay, the following ifdef rain forest may look messy at a
* first glance. But here's the thing: during run time linking of
* a binary, stat() may not be acutally needing symbol stat. It
* might as well not had been stat() in the first place (see the
* reasoning at the beginning of this file). However, if we would
* expose stat symbol here, we will poison the well and trick
* dynamic linker into thinking we are some old binary that still
* uses the symbol. So whenever code from upper layers calls
* stat(), the control would get here, but real_stat can actually
* be a NULL pointer because newer glibc have __xstat instead.
* Worse, it can have __xstat64 instead __xstat.
*
* Anyway, these ifdefs are there to implement the following
* preference function:
*
* stat < stat64 < __xstat < __xstat64
*
* It's the same story with lstat.
* Also, I feel sorry for you that you had to read this.
*/
#if defined(HAVE_STAT) && !defined(HAVE___XSTAT)
int stat(const char *path, struct stat *sb)
{
init_syms();
checkPath(path);
return real_stat(path, sb);
}
#endif
#if defined(HAVE_STAT64) && !defined(HAVE___XSTAT64)
int stat64(const char *path, struct stat64 *sb)
{
init_syms();
checkPath(path);
return real_stat64(path, sb);
}
#endif
#if defined(HAVE___XSTAT) && !defined(HAVE___XSTAT64)
int
__xstat(int ver, const char *path, struct stat *sb)
{
init_syms();
checkPath(path);
return real___xstat(ver, path, sb);
}
#endif
#if defined(HAVE___XSTAT64)
int
__xstat64(int ver, const char *path, struct stat64 *sb)
{
init_syms();
checkPath(path);
return real___xstat64(ver, path, sb);
}
#endif
#if defined(HAVE_LSTAT) && !defined(HAVE___LXSTAT)
int
lstat(const char *path, struct stat *sb)
{
init_syms();
checkPath(path);
return real_lstat(path, sb);
}
#endif
#if defined(HAVE_LSTAT64) && !defined(HAVE___LXSTAT64)
int
lstat64(const char *path, struct stat64 *sb)
{
init_syms();
checkPath(path);
return real_lstat64(path, sb);
}
#endif
#if defined(HAVE___LXSTAT) && !defined(HAVE___LXSTAT64)
int
__lxstat(int ver, const char *path, struct stat *sb)
{
init_syms();
checkPath(path);
return real___lxstat(ver, path, sb);
}
#endif
#if defined(HAVE___LXSTAT64)
int
__lxstat64(int ver, const char *path, struct stat64 *sb)
{
init_syms();
checkPath(path);
return real___lxstat64(ver, path, sb);
}
#endif