mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 21:55:25 +00:00
570d0f6387
https://bugzilla.redhat.com/show_bug.cgi?id=1087104 Commit id 'c6212539' explicitly allowed a negative value to be used for offset and length as a shorthand for the largest value after commit id 'f18c02ec' modified virStrToLong_ui() to essentially disallow a negative value. However, allowing a negative value for offset ONLY worked if the negative value was -1 since the eventual lseek() does allow a -1 to mean the end of the file. Providing other negative values resulted in errors such as: $ virsh vol-download --pool default qcow3-vol2 /home/vm-images/raw \ --offset -2 --length -1000 error: cannot download from volume qcow3-vol2 error: Unable to seek /home/vm-images/qcow3-vol2 to 18446744073709551614: Invalid argument $ Thus, it seems unreasonable to expect or allow a negative value for offset since the only benefit is to lseek() to the end of the file and then only take advantage of how the OS would handle such a seek. For the purposes of upload or download of volume data, that seems to be a no-op. Therefore, disallow a negative value for offset. Additionally, modify the man page for vol-upload and vol-download to provide more details regarding the valid values for both offset and length. |
||
|---|---|---|
| .. | ||
| wireshark | ||
| libvirt_win_icon_16x16.ico | ||
| libvirt_win_icon_32x32.ico | ||
| libvirt_win_icon_48x48.ico | ||
| libvirt_win_icon_64x64.ico | ||
| libvirt-guests.init.in | ||
| libvirt-guests.service.in | ||
| libvirt-guests.sh.in | ||
| libvirt-guests.sysconf | ||
| Makefile.am | ||
| virsh_win_icon.rc | ||
| virsh-console.c | ||
| virsh-console.h | ||
| virsh-domain-monitor.c | ||
| virsh-domain-monitor.h | ||
| virsh-domain.c | ||
| virsh-domain.h | ||
| virsh-edit.c | ||
| virsh-host.c | ||
| virsh-host.h | ||
| virsh-interface.c | ||
| virsh-interface.h | ||
| virsh-network.c | ||
| virsh-network.h | ||
| virsh-nodedev.c | ||
| virsh-nodedev.h | ||
| virsh-nwfilter.c | ||
| virsh-nwfilter.h | ||
| virsh-pool.c | ||
| virsh-pool.h | ||
| virsh-secret.c | ||
| virsh-secret.h | ||
| virsh-snapshot.c | ||
| virsh-snapshot.h | ||
| virsh-volume.c | ||
| virsh-volume.h | ||
| virsh.c | ||
| virsh.h | ||
| virsh.pod | ||
| virt-host-validate-common.c | ||
| virt-host-validate-common.h | ||
| virt-host-validate-lxc.c | ||
| virt-host-validate-lxc.h | ||
| virt-host-validate-qemu.c | ||
| virt-host-validate-qemu.h | ||
| virt-host-validate.c | ||
| virt-login-shell.c | ||
| virt-login-shell.conf | ||
| virt-login-shell.pod | ||
| virt-pki-validate.in | ||
| virt-sanlock-cleanup.in | ||
| virt-xml-validate.in | ||