libvirt/tests
Eric Blake 575914cf3d qemu: avoid adding "" in smbios arguments
The log lists things like -smbios type=1,vendor="Red Hat", which
is great for shell parsing, but not so great when you realize that
execve() then passes those literal "" on as part of the command
line argument, such that qemu sets SMBIOS with extra literal quotes.

The eventual addition of virCommand is needed before we have the API
to shell-quote a string representation of a command line, so that the
log can still be pasted into a shell, but without inserting extra
bytes into the execve() arguments.

* src/qemu/qemu_conf.c (qemuBuildSmbiosBiosStr)
(qemuBuildSmbiosSystemStr): Qemu doesn't like quotes around uuid
arguments, and the remaining quotes are passed literally to
smbios, making <smbios mode='host'/> inaccurate.  Removing the
quotes makes the log harder to parse, but that can be fixed later
with virCommand improvements.
* tests/qemuxml2argvdata/qemuxml2argv-smbios.args: 'Fix' test; it
will need fixing again once virCommand learns how to shell-quote a
potential command line.
2010-12-07 08:35:05 -07:00
..
capabilityschemadata Add a more featureful qemu capabilities test data 2009-09-10 12:25:42 +01:00
commanddata Introduce new APIs for spawning processes 2010-12-02 16:00:44 -07:00
confdata maint: simplify some ignore files 2010-06-15 07:31:10 -06:00
cputestdata tests: Add unit tests for internal CPU APIs 2010-12-01 14:12:54 +01:00
domainschemadata schema: Move timer element inside clock 2010-11-09 15:35:43 +01:00
domainsnapshotxml2xmlin Domain snapshot RNG and tests. 2010-05-20 13:50:03 -04:00
domainsnapshotxml2xmlout Domain snapshot RNG and tests. 2010-05-20 13:50:03 -04:00
interfaceschemadata Update interface.rng and xml test files to match netcf 0.1.5 2010-01-19 21:13:03 +01:00
networkxml2xmlin Add support for an external TFTP boot server 2009-10-28 15:57:49 +01:00
networkxml2xmlout Add support for an external TFTP boot server 2009-10-28 15:57:49 +01:00
nodedevschemadata nodedev: Add removable storage 'media_label' prop 2009-12-14 14:58:23 +01:00
nodeinfodata Get thread and socket information in virsh nodeinfo. 2010-03-08 09:26:04 -05:00
nwfilterxml2xmlin nwfilter: Add test case for testing the state attribute 2010-10-07 06:43:35 -04:00
nwfilterxml2xmlout nwfilter: Add test case for testing the state attribute 2010-10-07 06:43:35 -04:00
qemuhelpdata qemu: Fix detection of drive readonly option 2010-10-26 10:31:50 +02:00
qemuxml2argvdata qemu: avoid adding "" in smbios arguments 2010-12-07 08:35:05 -07:00
qemuxml2xmloutdata qemu: virtio console support 2010-07-28 16:48:00 -04:00
sexpr2xmldata vcpu: improve vcpu support in xen command line 2010-10-19 10:06:45 -06:00
storagepoolxml2xmlin storage: add support for Vendor and Model in XML 2010-08-19 15:58:43 -06:00
storagepoolxml2xmlout storage: add support for Vendor and Model in XML 2010-08-19 15:58:43 -06:00
storagevolxml2xmlin tests: Add storage volume XML 2 XML tests. 2009-10-16 10:52:27 -04:00
storagevolxml2xmlout tests: Add storage volume XML 2 XML tests. 2009-10-16 10:52:27 -04:00
vmx2xmldata esx: Support SMBIOS host mode 2010-11-11 19:18:19 +01:00
xencapsdata maint: simplify some ignore files 2010-06-15 07:31:10 -06:00
xmconfigdata conf: Fix parsing python style triple quotes 2010-11-22 16:37:21 -05:00
xml2sexprdata xend: Escape reserved sexpr characters 2010-11-22 16:43:29 -05:00
xml2vmxdata esx: Support SMBIOS host mode 2010-11-11 19:18:19 +01:00
.gitignore Introduce new APIs for spawning processes 2010-12-02 16:00:44 -07:00
.valgrind.supp Supress annoying libcap-ng errors from valgrind 2009-11-26 12:07:17 +00:00
capabilityschematest Make test suite output less verbose 2010-01-15 16:28:05 +00:00
commandhelper.c tests: Don't ignore return value of getcwd() 2010-12-06 10:12:01 +01:00
commandtest.c Introduce new APIs for spawning processes 2010-12-02 16:00:44 -07:00
conftest.c avoid calling exit with a constant; use EXIT_* instead 2009-12-15 17:46:04 +01:00
cpuset tests: use GPLv2+, not GPLv3 2010-05-12 08:41:10 +02:00
cputest.c tests: Add unit tests for internal CPU APIs 2010-12-01 14:12:54 +01:00
daemon-conf tests: fix daemon-conf testing failure 2010-11-03 11:43:11 +01:00
define-dev-segfault domain conf: Track <console> target type 2010-07-28 16:47:59 -04:00
domainschematest tests: Test qemuxml2xml when expected xml changes 2010-07-28 16:47:56 -04:00
domainsnapshotschematest Domain snapshot RNG and tests. 2010-05-20 13:50:03 -04:00
esxutilstest.c esx: Handle non-UTF-8 encoded VMX files 2010-10-19 16:29:12 +02:00
eventtest.c Make test suite output less verbose 2010-01-15 16:28:05 +00:00
int-overflow Fix up "make check" 2009-10-07 12:18:13 +02:00
interfaceschematest Make test suite output less verbose 2010-01-15 16:28:05 +00:00
interfacexml2xmltest.c Remove virConnectPtr from interface XML APIs 2010-02-10 13:32:48 +00:00
libvirtd-fail Fix up "make check" 2009-10-07 12:18:13 +02:00
libvirtd-pool Fix up "make check" 2009-10-07 12:18:13 +02:00
Makefile.am Introduce new APIs for spawning processes 2010-12-02 16:00:44 -07:00
networkschematest Make test suite output less verbose 2010-01-15 16:28:05 +00:00
networkxml2xmltest.c Remove virConnectPtr from network XML APis 2010-02-10 13:31:28 +00:00
nodedevschematest Make test suite output less verbose 2010-01-15 16:28:05 +00:00
nodedevxml2xmltest.c Remove virConnectPtr from all node device XML APIs 2010-02-10 13:32:01 +00:00
nodeinfotest.c deprecate fclose() and introduce VIR_{FORCE_}FCLOSE() 2010-11-16 21:13:29 -05:00
nwfilterschematest nwfilter: Add filter schema for nwfilter XML, extend domain XML schema 2010-04-06 11:09:46 -04:00
nwfilterxml2xmltest.c tests: Fix detection of expected errors 2010-11-29 16:35:20 +01:00
object-locking.ml build: import latest gnulib 2010-04-02 10:18:55 -06:00
oomtrace.pl Generic test suite helpers for OOM testing 2008-05-29 15:21:45 +00:00
qemuargv2xmltest.c vcpu: improve vcpu support in qemu command line 2010-10-19 10:06:33 -06:00
qemuhelptest.c Misc test case fixes for SPICE 2010-11-09 13:52:20 +00:00
qemuxml2argvtest.c qemu: convert to virCommand 2010-12-02 16:00:47 -07:00
qemuxml2xmltest.c Implement QEMU/KVM QXL video card support in QEMU driver 2010-11-09 11:46:45 +00:00
qparamtest.c build: enable redundant-const check 2009-02-03 13:08:59 +00:00
read-bufsiz build: use portable sed expressions 2010-09-14 08:42:10 -06:00
read-non-seekable tests: use GPLv2+, not GPLv3 2010-05-12 08:41:10 +02:00
reconnect.c avoid calling exit with a constant; use EXIT_* instead 2009-12-15 17:46:04 +01:00
schematestutils.sh schematestutils.sh: improve shell portability: avoid "echo -e" 2010-04-14 17:34:12 +02:00
secaatest.c secaatest: Fix compilation 2010-07-24 17:15:11 +02:00
seclabeltest.c Disable all disk probing in QEMU driver & add config option to re-enable 2010-07-19 18:25:13 +01:00
sexpr2xmltest.c vcpu: improve vcpu support in xen command line 2010-10-19 10:06:45 -06:00
sockettest.c Add test suite for virSocket APIs 2010-10-22 11:59:37 +01:00
start tests: use GPLv2+, not GPLv3 2010-05-12 08:41:10 +02:00
statstest.c Fix statstest when driver modules are enabled 2010-10-19 17:31:30 +01:00
storagepoolschematest Make test suite output less verbose 2010-01-15 16:28:05 +00:00
storagepoolxml2xmltest.c storage: add support for Vendor and Model in XML 2010-08-19 15:58:43 -06:00
storagevolschematest Make test suite output less verbose 2010-01-15 16:28:05 +00:00
storagevolxml2xmltest.c Remove virConnectPtr from storage APIs & driver 2010-02-10 13:32:11 +00:00
test_conf.sh Make test suite output less verbose 2010-01-15 16:28:05 +00:00
test-lib.sh build: don't use "test cond1 -o cond2": it's not portable 2010-03-25 09:28:24 +01:00
testutils.c tests: Fix dispatching internal error reports 2010-11-23 12:15:14 -05:00
testutils.h tests: silence qemuargv2xmltest noise 2010-09-16 10:45:33 -06:00
testutilsqemu.c capabilities, cpu: use new array API 2010-11-18 12:21:58 -07:00
testutilsqemu.h remove all trailing blank lines 2009-07-16 15:06:42 +02:00
testutilsxen.c Fix crashes in Xen capabilities code 2009-07-27 16:45:01 +01:00
testutilsxen.h remove all trailing blank lines 2009-07-16 15:06:42 +02:00
undefine tests: use GPLv2+, not GPLv3 2010-05-12 08:41:10 +02:00
vcpupin tests: use GPLv2+, not GPLv3 2010-05-12 08:41:10 +02:00
virbuftest.c tests: Fix preprocessor indentation 2010-09-13 13:35:04 +02:00
virsh-all tests: use GPLv2+, not GPLv3 2010-05-12 08:41:10 +02:00
virsh-schedinfo tests: use GPLv2+, not GPLv3 2010-05-12 08:41:10 +02:00
virsh-synopsis tests: use GPLv2+, not GPLv3 2010-05-12 08:41:10 +02:00
virshtest.c virsh: add tests for recent cli improvements 2010-10-15 14:25:39 -06:00
virt-aa-helper-test virt-aa-helper-test cleanups 2010-09-30 15:01:36 -06:00
vmx2xmltest.c esx: Support SMBIOS host mode 2010-11-11 19:18:19 +01:00
xencapstest.c deprecate fclose() and introduce VIR_{FORCE_}FCLOSE() 2010-11-16 21:13:29 -05:00
xmconfigtest.c vcpu: improve vcpu support in xen command line 2010-10-19 10:06:45 -06:00
xml2sexprtest.c xend: Escape reserved sexpr characters 2010-11-22 16:43:29 -05:00
xml2vmxtest.c esx: Support SMBIOS host mode 2010-11-11 19:18:19 +01:00