Laine Stump 5b5f12cffa util: avoid getting stuck on macvtapN name created outside libvirt ...

After the patches that added tracking of in-use macvtap names (commit
370608, first appearing in libvirt-1.3.2), if the function to allocate
a new macvtap device came to a device name created outside libvirt, it
would retry the same device name MACVLAN_MAX_ID (8191) times before
finally giving up in failure.

The problem was that virBitmapNextClearBit was always being called
with "0" rather than the value most recently checked (which would
increment each time through the loop), so it would always return the
same id (since we dutifully release that id after failing to create a
new device using it).

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1321546

Signed-off-by: Laine Stump <laine@laine.org>

2016-03-28 12:52:50 -04:00

..

iohelper.c

Indent top-level labels by one space in src/util/

2014-03-25 14:58:40 +01:00

keymaps.csv

…

viralloc.c

maint: avoid static zero init in core files

2014-10-29 09:55:09 -06:00

viralloc.h

util: forbid freeing const pointers

2014-07-16 06:48:53 -06:00

virarch.c

Add virLogSource variables to all source files

2014-03-18 14:29:22 +00:00

virarch.h

util: Add space before comment end marker

2015-09-14 11:32:44 +02:00

viratomic.c

Change file names in comments to match the files they are in

2014-03-10 14:26:04 +01:00

viratomic.h

…

viraudit.c

audit: use bool for audit log choice

2014-10-29 09:55:09 -06:00

viraudit.h

audit: use bool for audit log choice

2014-10-29 09:55:09 -06:00

virauth.c

Remove unnecessary curly brackets in src/util/

2014-11-14 17:13:35 +01:00

virauth.h

…

virauthconfig.c

Indent top-level labels by one space in src/util/

2014-03-25 14:58:40 +01:00

virauthconfig.h

…

virbitmap.c

util: bitmap: Introduce bitmap subtraction

2016-02-05 16:21:45 +01:00

virbitmap.h

util: bitmap: Introduce bitmap subtraction

2016-02-05 16:21:45 +01:00

virbuffer.c

util: buffer: Sanitize comment for virBufferAddBuffer

2016-01-25 17:53:08 +01:00

virbuffer.h

util: buffer: Add support for adding text blocks with indentation

2015-03-25 15:42:52 +01:00

vircgroup.c

qemu_cgroup: use virCgroupAddTask instead of virCgroupMoveTask

2016-03-01 14:07:27 +00:00

vircgroup.h

qemu_cgroup: use virCgroupAddTask instead of virCgroupMoveTask

2016-03-01 14:07:27 +00:00

vircgrouppriv.h

tests: Add tests for virCgroupDetectMounts

2015-03-18 09:53:24 +01:00

virclosecallbacks.c

util: Add a return value to void hash iterators

2016-02-17 12:46:34 +01:00

virclosecallbacks.h

conf: Split virDomainObjList into a separate file

2015-11-30 13:55:10 +01:00

vircommand.c

Drop inline keyword from some functions.

2016-03-03 14:39:57 +01:00

vircommand.h

utils: Implement virCommandPassFDGetFDIndex

2015-03-05 18:57:06 -05:00

vircommandpriv.h

Add ability to register callback for virCommand dry run

2014-03-19 10:47:58 +00:00

virconf.c

libvirt: Move config getters to util

2015-11-30 09:36:19 +01:00

virconf.h

libvirt: Move config getters to util

2015-11-30 09:36:19 +01:00

vircrypto.c

vircrypto: fix Invalid write in virCryptoHashString()

2014-03-12 16:01:30 -06:00

vircrypto.h

Add helper APIs for generating cryptographic hashes

2014-03-10 16:39:18 +00:00

virdbus.c

dbus: Don't unref NULL messages

2016-02-11 11:35:02 +01:00

virdbus.h

dbus: Don't unref NULL messages

2016-02-11 11:35:02 +01:00

virdbuspriv.h

build: fix build when not using dbus

2014-11-20 08:48:19 -07:00

virdnsmasq.c

Drop paths.h include

2016-03-18 09:43:45 +01:00

virdnsmasq.h

…

virebtables.c

Convert ebtables code over to use firewall APIs

2014-04-25 15:44:09 +01:00

virebtables.h

Remove unused ebtablesRemoveForwardPolicyReject method

2014-03-11 11:01:52 +00:00

virendian.h

…

virerror.c

virerror: Introduce new error type NO_SERVER

2016-03-11 12:58:41 +01:00

virerror.h

Introduce virErrorCopyNew

2015-07-10 11:47:13 +02:00

virevent.c

docs: event impl. registration before hypervisor connection

2015-10-15 19:50:58 -04:00

virevent.h

…

vireventpoll.c

util: make it more robust to calculate timeout value

2015-05-27 16:59:18 +02:00

vireventpoll.h

Change file names in comments to match the files they are in

2014-03-10 14:26:04 +01:00

virfile.c

nss: Implement _nss_libvirt_gethostbyname3_r

2016-03-18 17:29:53 +01:00

virfile.h

virfile: Rename virFileUnlink to virFileRemove

2015-09-21 08:24:16 -04:00

virfirewall.c

dbus: Don't unref NULL messages

2016-02-11 11:35:02 +01:00

virfirewall.h

test: fix nwfilter tests following changes in virfirewall.c

2014-12-22 16:57:21 -05:00

virfirewallpriv.h

Introduce an object for managing firewall rulesets

2014-04-25 15:44:09 +01:00

virgic.c

gic: Introduce virGICVersion enumeration

2016-02-16 14:58:58 +01:00

virgic.h

gic: Introduce VIR_GIC_VERSION_DEFAULT alias

2016-02-19 18:24:58 +01:00

virhash.c

util: Refactor virHashForEach so it returns as soon as an iterator fails

2016-02-17 12:46:34 +01:00

virhash.h

util: Refactor virHashForEach so it returns as soon as an iterator fails

2016-02-17 12:46:34 +01:00

virhashcode.c

…

virhashcode.h

…

virhook.c

virhook: do not save the return value of virBuildPath

2016-02-11 08:05:17 +01:00

virhook.h

qemu: hook: Provide hook when restoring a domain save image

2014-09-22 17:11:56 +02:00

virhostdev.c

hostdev: Use actual device when reattaching

2016-03-23 11:38:20 +01:00

virhostdev.h

hostdev: Rename virHostdevUpdateDomainActiveDevices()

2015-10-26 13:50:35 +01:00

viridentity.c

util: identity: Harden virIdentitySetCurrent()

2015-03-25 13:37:41 +01:00

viridentity.h

Add typesafe APIs for virIdentity attributes

2014-09-24 15:29:22 +01:00

virinitctl.c

Add support for /run/initctl

2014-10-22 13:09:49 +01:00

virinitctl.h

util: use typedefs for enums in "src/util/" directory

2014-05-05 14:30:01 -06:00

viriptables.c

Drop paths.h include

2016-03-18 09:43:45 +01:00

viriptables.h

Convert bridge driver over to use new firewall APIs

2014-04-25 15:44:09 +01:00

viriscsi.c

viriscsi: Need to sendtargets on Initiator IQN

2014-12-10 06:58:37 -05:00

viriscsi.h

util: Sanitize ATTRIBUTE_NONNULL use in viriscsi.h

2014-03-25 08:26:39 +01:00

virjson.c

virJSONValueArraySize: return ssize_t

2015-10-09 15:25:08 +02:00

virjson.h

virJSONValueArraySize: return ssize_t

2015-10-09 15:25:08 +02:00

virkeycode-mapgen.py

…

virkeycode.c

…

virkeycode.h

…

virkeyfile.c

hash: add common utility functions

2014-04-07 06:14:45 -06:00

virkeyfile.h

…

virkmod.c

Typos: Get rid of dependan(t|cies)

2015-04-02 16:05:32 +02:00

virkmod.h

…

virlease.c

nss: Implement _nss_libvirt_gethostbyname3_r

2016-03-18 17:29:53 +01:00

virlease.h

Export virLease* functions for leases file handling

2016-03-18 17:29:53 +01:00

virlockspace.c

virJSONValueArraySize: return ssize_t

2015-10-09 15:25:08 +02:00

virlockspace.h

…

virlog.c

virlog: Refactor virLogParseFilters

2016-03-24 16:39:28 +01:00

virlog.h

virlog: Introduce Type{To,From}String for virLogDestination

2016-03-16 14:24:15 +01:00

virmacaddr.c

util: Functions to update host network device's multicast filter

2014-10-28 14:14:25 -04:00

virmacaddr.h

util: Functions to update host network device's multicast filter

2014-10-28 14:14:25 -04:00

virnetdev.c

netdev: Use virNetDevIsVirtualFunction() properly

2016-02-25 17:09:52 +01:00

virnetdev.h

nodedev: report maxCount for virtual_functions capability

2015-11-24 12:31:04 -05:00

virnetdevbandwidth.c

virnetdevbandwidth: Compute quantum value

2016-02-05 16:43:19 +01:00

virnetdevbandwidth.h

virNetDevBandwidthUpdateRate: turn class_id into integer

2015-08-11 16:10:32 +02:00

virnetdevbridge.c

util: fallback to ioctl(SIOCBRDELBR) if netlink RTM_DELLINK fails

2015-08-28 16:39:30 -04:00

virnetdevbridge.h

util: functions to manage bridge fdb (forwarding database)

2014-12-08 14:39:12 -05:00

virnetdevmacvlan.c

util: avoid getting stuck on macvtapN name created outside libvirt

2016-03-28 12:52:50 -04:00

virnetdevmacvlan.h

util: keep/use a bitmap of in-use macvtap devices

2016-01-26 12:20:04 -05:00

virnetdevmidonet.c

util: functions to support binding/unbinding midonet virtualports

2015-03-17 12:56:37 -04:00

virnetdevmidonet.h

util: functions to support binding/unbinding midonet virtualports

2015-03-17 12:56:37 -04:00

virnetdevopenvswitch.c

virnetdevopenvswitch: Don't call strlen() twice on the same string

2016-01-27 13:01:24 +01:00

virnetdevopenvswitch.h

…

virnetdevtap.c

network: Add midonet virtual port type support to qemu

2015-03-17 13:10:17 -04:00

virnetdevtap.h

Change int to size_t in size var for tap/vhost FDs

2015-01-15 11:07:13 +00:00

virnetdevveth.c

Cleanup "/sys/class/net" usage

2015-04-15 16:43:28 +02:00

virnetdevveth.h

…

virnetdevvlan.c

…

virnetdevvlan.h

…

virnetdevvportprofile.c

util: clean up and expand 802.1QbX negotiation logging

2016-02-14 11:29:41 -05:00

virnetdevvportprofile.h

util: functions to support binding/unbinding midonet virtualports

2015-03-17 12:56:37 -04:00

virnetlink.c

util: increase libnl buffer size

2016-01-26 12:20:04 -05:00

virnetlink.h

util: fallback to ioctl(SIOCBRDELBR) if netlink RTM_DELLINK fails

2015-08-28 16:39:30 -04:00

virnodesuspend.c

build: Don't use code with dbus_message_unref when built without dbus

2014-04-14 18:19:36 +02:00

virnodesuspend.h

…

virnuma.c

util: Produce friendlier error message to user

2015-10-21 16:19:42 -04:00

virnuma.h

util: Add virNumaGetHostNodeset

2014-12-16 11:15:27 +01:00

virobject.c

util: Make the virDomainListFree helper more universal

2015-05-11 08:28:53 +02:00

virobject.h

util: Make the virDomainListFree helper more universal

2015-05-11 08:28:53 +02:00

virpci.c

nodedev: Expose PCI header type

2016-03-18 17:35:06 +01:00

virpci.h

nodedev: Expose PCI header type

2016-03-18 17:35:06 +01:00

virpidfile.c

network: escape quotes for dsmasq conf contents

2015-06-09 13:56:00 -04:00

virpidfile.h

util: Introduce virPidFileForceCleanupPath

2014-11-03 16:43:23 +01:00

virpolkit.c

util: Cleanup error path for virPolkitAgentCreate

2016-03-02 13:59:37 -05:00

virpolkit.h

util: Introduce API's for Polkit text authentication

2016-03-01 06:50:16 -05:00

virportallocator.c

Introduce virBitmapIsBitSet

2015-03-13 15:31:33 +01:00

virportallocator.h

util: Allow port allocator to skip bind() check

2014-09-11 15:40:14 -06:00

virprobe.h

Log dtrace/systemd probes at INFO level instead of DEBUG

2015-01-15 11:07:13 +00:00

virprocess.c

util: Use virBitmapIsBitSet in freebsd impl of virProcessSetAffinity

2016-02-19 15:23:54 +01:00

virprocess.h

process: Add virProcessGetMaxMemLock()

2015-12-17 10:12:47 +01:00

virrandom.c

build: include correct header for time()

2015-04-14 13:24:51 -06:00

virrandom.h

…

virrotatingfile.c

rotatingfile: mark log files as close-on-exec

2015-12-04 18:18:39 +00:00

virrotatingfile.h

util: Avoid variable named 'truncate' shadowing global declaration

2015-11-30 15:32:47 +01:00

virscsi.c

Convert SCSI logical unit from unsigned int to unsigned long long

2015-06-22 16:03:33 -04:00

virscsi.h

Convert SCSI logical unit from unsigned int to unsigned long long

2015-06-22 16:03:33 -04:00

virseclabel.c

virseclabel: Resolve Coverity FORWARD_NULL issue

2014-07-14 05:44:20 -04:00

virseclabel.h

virSecurityDeviceLabelDef: substitute 'norelabel' with 'relabel'

2014-07-11 10:36:02 +02:00

virsexpr.c

Remove unnecessary curly brackets in src/util/

2014-11-14 17:13:35 +01:00

virsexpr.h

…

virsocketaddr.c

util: Add virSocketAddrSetIPv[46]AddrNetOrder and use it

2016-03-21 11:28:33 +01:00

virsocketaddr.h

util: Add virSocketAddrSetIPv[46]AddrNetOrder and use it

2016-03-21 11:28:33 +01:00

virstats.c

maint: clean up _virDomainInterfaceStats

2014-09-17 11:28:48 -06:00

virstats.h

maint: clean up _virDomainInterfaceStats

2014-09-17 11:28:48 -06:00

virstorageencryption.c

Remove unnecessary curly brackets in src/util/

2014-11-14 17:13:35 +01:00

virstorageencryption.h

storage: encryption: Add deep copy function for storage encryption

2014-06-20 09:14:46 +02:00

virstoragefile.c

Spell VMware with a lowercase w

2016-02-15 15:35:48 +01:00

virstoragefile.h

qemu: Fix reporting of physical capacity for block devices

2015-08-07 13:28:50 +02:00

virstring.c

virStringListLength: Ensure const correctness

2016-02-09 15:44:58 -05:00

virstring.h

virStringListLength: Ensure const correctness

2016-02-09 15:44:58 -05:00

virsysinfo.c

virSysinfo: Introduce SMBIOS type 2 support

2015-06-18 10:10:26 +02:00

virsysinfo.h

virSysinfo: Introduce SMBIOS type 2 support

2015-06-18 10:10:26 +02:00

virsystemd.c

dbus: Don't unref NULL messages

2016-02-11 11:35:02 +01:00

virsystemd.h

systemd: Modernize machine naming

2016-02-05 16:11:50 +01:00

virthread.c

virCondWaitUntil: calculate timespec correctly

2015-04-16 15:39:22 +02:00

virthread.h

virThread: Set thread job

2015-03-25 10:00:53 +01:00

virthreadjob.c

Add support for tracking thread jobs

2015-03-25 10:00:53 +01:00

virthreadjob.h

Add support for tracking thread jobs

2015-03-25 10:00:53 +01:00

virthreadpool.c

threadpool: Switch to detached threads

2015-05-21 14:35:02 +02:00

virthreadpool.h

virThreadPool: Set thread worker name

2015-03-25 10:00:53 +01:00

virtime.c

Renamed internal __mon_yday into mon_yday to avoid conflicts

2014-10-28 14:44:18 -06:00

virtime.h

util: virTimeFieldsThenRaw never returns negative

2014-07-25 12:06:07 +02:00

virtpm.c

tpm: adapt sysfs cancel path for new TPM driver

2015-11-17 20:52:13 -05:00

virtpm.h

…

virtypedparam.c

util: Export remoteSerializeTypedParameters internally via util

2016-02-03 15:46:45 +01:00

virtypedparam.h

util: Export remoteSerializeTypedParameters internally via util

2016-02-03 15:46:45 +01:00

viruri.c

livirt: Move URI alias matching to util

2015-11-30 09:44:28 +01:00

viruri.h

livirt: Move URI alias matching to util

2015-11-30 09:44:28 +01:00

virusb.c

usb: Remove redundant comment

2014-07-03 10:41:15 +02:00

virusb.h

add 'driver' info to used_by

2014-03-04 12:24:13 +00:00

virutil.c

Drop paths.h include

2016-03-18 09:43:45 +01:00

virutil.h

util: TristateBool and TristateSwitch are interchangeable

2016-02-22 15:13:56 +01:00

viruuid.c

Use K&R style for curly braces in src/util/

2014-03-20 17:16:18 +01:00

viruuid.h

…

virxdrdefs.h

Unify int types handling in protocol files

2016-01-11 19:56:06 +03:00

virxml.c

Add virXMLValidateAgainstSchema helper method

2015-01-15 14:02:50 +00:00

virxml.h

Add virXMLValidateAgainstSchema helper method

2015-01-15 14:02:50 +00:00