mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-02 11:21:12 +00:00
5ba372306a
* src/domain_conf.c src/domain_conf.h src/qemu_conf.c src/qemu_driver.c: patch from Guido Günther allowing to add disk as USB devices * docs/libvirt.rng: extend the schemas for the new value * tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml tests/qemuxml2argvtest.c tests/qemuxml2xmltest.c: add a specific test to the regression suite Daniel
1254 lines
40 KiB
C
1254 lines
40 KiB
C
/*
|
|
* config.c: VM configuration management
|
|
*
|
|
* Copyright (C) 2006, 2007, 2008 Red Hat, Inc.
|
|
* Copyright (C) 2006 Daniel P. Berrange
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
* Author: Daniel P. Berrange <berrange@redhat.com>
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#ifdef WITH_QEMU
|
|
|
|
#include <dirent.h>
|
|
#include <string.h>
|
|
#include <limits.h>
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <unistd.h>
|
|
#include <errno.h>
|
|
#include <fcntl.h>
|
|
#include <sys/wait.h>
|
|
#include <arpa/inet.h>
|
|
#include <sys/utsname.h>
|
|
|
|
#if HAVE_NUMACTL
|
|
#include <numa.h>
|
|
#endif
|
|
|
|
#include "qemu_conf.h"
|
|
#include "uuid.h"
|
|
#include "buf.h"
|
|
#include "conf.h"
|
|
#include "util.h"
|
|
#include "memory.h"
|
|
#include "verify.h"
|
|
|
|
VIR_ENUM_DECL(virDomainDiskQEMUBus)
|
|
VIR_ENUM_IMPL(virDomainDiskQEMUBus, VIR_DOMAIN_DISK_BUS_LAST,
|
|
"ide",
|
|
"floppy",
|
|
"scsi",
|
|
"virtio",
|
|
"xen",
|
|
"usb")
|
|
|
|
|
|
#define qemudLog(level, msg...) fprintf(stderr, msg)
|
|
|
|
void qemudReportError(virConnectPtr conn,
|
|
virDomainPtr dom,
|
|
virNetworkPtr net,
|
|
int code, const char *fmt, ...) {
|
|
va_list args;
|
|
char errorMessage[1024];
|
|
const char *virerr;
|
|
|
|
if (fmt) {
|
|
va_start(args, fmt);
|
|
vsnprintf(errorMessage, sizeof(errorMessage)-1, fmt, args);
|
|
va_end(args);
|
|
} else {
|
|
errorMessage[0] = '\0';
|
|
}
|
|
|
|
virerr = __virErrorMsg(code, (errorMessage[0] ? errorMessage : NULL));
|
|
__virRaiseError(conn, dom, net, VIR_FROM_QEMU, code, VIR_ERR_ERROR,
|
|
virerr, errorMessage, NULL, -1, -1, virerr, errorMessage);
|
|
}
|
|
|
|
int qemudLoadDriverConfig(struct qemud_driver *driver,
|
|
const char *filename) {
|
|
virConfPtr conf;
|
|
virConfValuePtr p;
|
|
|
|
/* Setup 2 critical defaults */
|
|
if (!(driver->vncListen = strdup("127.0.0.1"))) {
|
|
qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
|
|
"%s", _("failed to allocate vncListen"));
|
|
return -1;
|
|
}
|
|
if (!(driver->vncTLSx509certdir = strdup(SYSCONF_DIR "/pki/libvirt-vnc"))) {
|
|
qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
|
|
"%s", _("failed to allocate vncTLSx509certdir"));
|
|
return -1;
|
|
}
|
|
|
|
/* Just check the file is readable before opening it, otherwise
|
|
* libvirt emits an error.
|
|
*/
|
|
if (access (filename, R_OK) == -1) return 0;
|
|
|
|
conf = virConfReadFile (filename);
|
|
if (!conf) return 0;
|
|
|
|
|
|
#define CHECK_TYPE(name,typ) if (p && p->type != (typ)) { \
|
|
qemudReportError(NULL, NULL, NULL, VIR_ERR_INTERNAL_ERROR, \
|
|
"remoteReadConfigFile: %s: %s: expected type " #typ "\n", \
|
|
filename, (name)); \
|
|
virConfFree(conf); \
|
|
return -1; \
|
|
}
|
|
|
|
p = virConfGetValue (conf, "vnc_tls");
|
|
CHECK_TYPE ("vnc_tls", VIR_CONF_LONG);
|
|
if (p) driver->vncTLS = p->l;
|
|
|
|
p = virConfGetValue (conf, "vnc_tls_x509_verify");
|
|
CHECK_TYPE ("vnc_tls_x509_verify", VIR_CONF_LONG);
|
|
if (p) driver->vncTLSx509verify = p->l;
|
|
|
|
p = virConfGetValue (conf, "vnc_tls_x509_cert_dir");
|
|
CHECK_TYPE ("vnc_tls_x509_cert_dir", VIR_CONF_STRING);
|
|
if (p && p->str) {
|
|
VIR_FREE(driver->vncTLSx509certdir);
|
|
if (!(driver->vncTLSx509certdir = strdup(p->str))) {
|
|
qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
|
|
"%s", _("failed to allocate vncTLSx509certdir"));
|
|
virConfFree(conf);
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
p = virConfGetValue (conf, "vnc_listen");
|
|
CHECK_TYPE ("vnc_listen", VIR_CONF_STRING);
|
|
if (p && p->str) {
|
|
if (!(driver->vncListen = strdup(p->str))) {
|
|
qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY,
|
|
"%s", _("failed to allocate vncTLSx509certdir"));
|
|
virConfFree(conf);
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
virConfFree (conf);
|
|
return 0;
|
|
}
|
|
|
|
/* The list of possible machine types for various architectures,
|
|
as supported by QEMU - taken from 'qemu -M ?' for each arch */
|
|
static const char *const arch_info_hvm_x86_machines[] = {
|
|
"pc", "isapc"
|
|
};
|
|
static const char *const arch_info_hvm_mips_machines[] = {
|
|
"mips"
|
|
};
|
|
static const char *const arch_info_hvm_sparc_machines[] = {
|
|
"sun4m"
|
|
};
|
|
static const char *const arch_info_hvm_ppc_machines[] = {
|
|
"g3bw", "mac99", "prep"
|
|
};
|
|
|
|
static const char *const arch_info_xen_x86_machines[] = {
|
|
"xenner"
|
|
};
|
|
|
|
struct qemu_feature_flags {
|
|
const char *name;
|
|
const int default_on;
|
|
const int toggle;
|
|
};
|
|
|
|
struct qemu_arch_info {
|
|
const char *arch;
|
|
int wordsize;
|
|
const char *const *machines;
|
|
int nmachines;
|
|
const char *binary;
|
|
const struct qemu_feature_flags *flags;
|
|
int nflags;
|
|
};
|
|
|
|
/* Feature flags for the architecture info */
|
|
static const struct qemu_feature_flags const arch_info_i686_flags [] = {
|
|
{ "pae", 1, 0 },
|
|
{ "nonpae", 1, 0 },
|
|
{ "acpi", 1, 1 },
|
|
{ "apic", 1, 0 },
|
|
};
|
|
|
|
static const struct qemu_feature_flags const arch_info_x86_64_flags [] = {
|
|
{ "acpi", 1, 1 },
|
|
{ "apic", 1, 0 },
|
|
};
|
|
|
|
/* The archicture tables for supported QEMU archs */
|
|
static const struct qemu_arch_info const arch_info_hvm[] = {
|
|
{ "i686", 32, arch_info_hvm_x86_machines, 2,
|
|
"/usr/bin/qemu", arch_info_i686_flags, 4 },
|
|
{ "x86_64", 64, arch_info_hvm_x86_machines, 2,
|
|
"/usr/bin/qemu-system-x86_64", arch_info_x86_64_flags, 2 },
|
|
{ "mips", 32, arch_info_hvm_mips_machines, 1,
|
|
"/usr/bin/qemu-system-mips", NULL, 0 },
|
|
{ "mipsel", 32, arch_info_hvm_mips_machines, 1,
|
|
"/usr/bin/qemu-system-mipsel", NULL, 0 },
|
|
{ "sparc", 32, arch_info_hvm_sparc_machines, 1,
|
|
"/usr/bin/qemu-system-sparc", NULL, 0 },
|
|
{ "ppc", 32, arch_info_hvm_ppc_machines, 3,
|
|
"/usr/bin/qemu-system-ppc", NULL, 0 },
|
|
};
|
|
|
|
static const struct qemu_arch_info const arch_info_xen[] = {
|
|
{ "i686", 32, arch_info_xen_x86_machines, 1,
|
|
"/usr/bin/xenner", arch_info_i686_flags, 4 },
|
|
{ "x86_64", 64, arch_info_xen_x86_machines, 1,
|
|
"/usr/bin/xenner", arch_info_x86_64_flags, 2 },
|
|
};
|
|
|
|
static int
|
|
qemudCapsInitGuest(virCapsPtr caps,
|
|
const char *hostmachine,
|
|
const struct qemu_arch_info *info,
|
|
int hvm) {
|
|
virCapsGuestPtr guest;
|
|
int i;
|
|
|
|
if ((guest = virCapabilitiesAddGuest(caps,
|
|
hvm ? "hvm" : "xen",
|
|
info->arch,
|
|
info->wordsize,
|
|
info->binary,
|
|
NULL,
|
|
info->nmachines,
|
|
info->machines)) == NULL)
|
|
return -1;
|
|
|
|
if (hvm) {
|
|
/* Check for existance of base emulator */
|
|
if (access(info->binary, X_OK) == 0 &&
|
|
virCapabilitiesAddGuestDomain(guest,
|
|
"qemu",
|
|
NULL,
|
|
NULL,
|
|
0,
|
|
NULL) == NULL)
|
|
return -1;
|
|
|
|
/* If guest & host match, then we can accelerate */
|
|
if (STREQ(info->arch, hostmachine)) {
|
|
if (access("/dev/kqemu", F_OK) == 0 &&
|
|
virCapabilitiesAddGuestDomain(guest,
|
|
"kqemu",
|
|
NULL,
|
|
NULL,
|
|
0,
|
|
NULL) == NULL)
|
|
return -1;
|
|
|
|
if (access("/dev/kvm", F_OK) == 0 &&
|
|
virCapabilitiesAddGuestDomain(guest,
|
|
"kvm",
|
|
"/usr/bin/qemu-kvm",
|
|
NULL,
|
|
0,
|
|
NULL) == NULL)
|
|
return -1;
|
|
}
|
|
} else {
|
|
if (virCapabilitiesAddGuestDomain(guest,
|
|
"kvm",
|
|
NULL,
|
|
NULL,
|
|
0,
|
|
NULL) == NULL)
|
|
return -1;
|
|
}
|
|
|
|
if (info->nflags) {
|
|
for (i = 0 ; i < info->nflags ; i++) {
|
|
if (virCapabilitiesAddGuestFeature(guest,
|
|
info->flags[i].name,
|
|
info->flags[i].default_on,
|
|
info->flags[i].toggle) == NULL)
|
|
return -1;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
#if HAVE_NUMACTL
|
|
#define MAX_CPUS 4096
|
|
#define MAX_CPUS_MASK_SIZE (sizeof(unsigned long))
|
|
#define MAX_CPUS_MASK_LEN (MAX_CPUS / MAX_CPUS_MASK_SIZE)
|
|
#define MAX_CPUS_MASK_BYTES (MAX_CPUS / 8)
|
|
|
|
#define MASK_CPU_ISSET(mask, cpu) \
|
|
(((mask)[((cpu) / MAX_CPUS_MASK_SIZE)] >> ((cpu) % MAX_CPUS_MASK_SIZE)) & 1)
|
|
|
|
static int
|
|
qemudCapsInitNUMA(virCapsPtr caps)
|
|
{
|
|
int n, i;
|
|
unsigned long *mask = NULL;
|
|
int ncpus;
|
|
int *cpus = NULL;
|
|
int ret = -1;
|
|
|
|
if (numa_available() < 0)
|
|
return 0;
|
|
|
|
if (VIR_ALLOC_N(mask, MAX_CPUS_MASK_LEN) < 0)
|
|
goto cleanup;
|
|
|
|
for (n = 0 ; n <= numa_max_node() ; n++) {
|
|
if (numa_node_to_cpus(n, mask, MAX_CPUS_MASK_BYTES) < 0)
|
|
goto cleanup;
|
|
|
|
for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++)
|
|
if (MASK_CPU_ISSET(mask, i))
|
|
ncpus++;
|
|
|
|
if (VIR_ALLOC_N(cpus, ncpus) < 0)
|
|
goto cleanup;
|
|
|
|
for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++)
|
|
if (MASK_CPU_ISSET(mask, i))
|
|
cpus[ncpus++] = i;
|
|
|
|
if (virCapabilitiesAddHostNUMACell(caps,
|
|
n,
|
|
ncpus,
|
|
cpus) < 0)
|
|
goto cleanup;
|
|
|
|
VIR_FREE(cpus);
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
VIR_FREE(cpus);
|
|
VIR_FREE(mask);
|
|
return ret;
|
|
}
|
|
#else
|
|
static int qemudCapsInitNUMA(virCapsPtr caps ATTRIBUTE_UNUSED) { return 0; }
|
|
#endif
|
|
|
|
virCapsPtr qemudCapsInit(void) {
|
|
struct utsname utsname;
|
|
virCapsPtr caps;
|
|
int i;
|
|
|
|
/* Really, this never fails - look at the man-page. */
|
|
uname (&utsname);
|
|
|
|
if ((caps = virCapabilitiesNew(utsname.machine,
|
|
0, 0)) == NULL)
|
|
goto no_memory;
|
|
|
|
if (qemudCapsInitNUMA(caps) < 0)
|
|
goto no_memory;
|
|
|
|
for (i = 0 ; i < (sizeof(arch_info_hvm)/sizeof(arch_info_hvm[0])) ; i++)
|
|
if (qemudCapsInitGuest(caps,
|
|
utsname.machine,
|
|
&arch_info_hvm[i], 1) < 0)
|
|
goto no_memory;
|
|
|
|
if (access("/usr/bin/xenner", X_OK) == 0 &&
|
|
access("/dev/kvm", F_OK) == 0) {
|
|
for (i = 0 ; i < (sizeof(arch_info_xen)/sizeof(arch_info_xen[0])) ; i++)
|
|
/* Allow Xen 32-on-32, 32-on-64 and 64-on-64 */
|
|
if (STREQ(arch_info_xen[i].arch, utsname.machine) ||
|
|
(STREQ(utsname.machine, "x86_64") &&
|
|
STREQ(arch_info_xen[i].arch, "i686"))) {
|
|
if (qemudCapsInitGuest(caps,
|
|
utsname.machine,
|
|
&arch_info_xen[i], 0) < 0)
|
|
goto no_memory;
|
|
}
|
|
}
|
|
|
|
return caps;
|
|
|
|
no_memory:
|
|
virCapabilitiesFree(caps);
|
|
return NULL;
|
|
}
|
|
|
|
|
|
int qemudExtractVersionInfo(const char *qemu, int *version, int *flags) {
|
|
pid_t child;
|
|
int newstdout[2];
|
|
|
|
if (flags)
|
|
*flags = 0;
|
|
if (version)
|
|
*version = 0;
|
|
|
|
if (pipe(newstdout) < 0) {
|
|
return -1;
|
|
}
|
|
|
|
if ((child = fork()) < 0) {
|
|
close(newstdout[0]);
|
|
close(newstdout[1]);
|
|
return -1;
|
|
}
|
|
|
|
if (child == 0) { /* Kid */
|
|
/* Just in case QEMU is translated someday we force to C locale.. */
|
|
const char *const qemuenv[] = { "LANG=C", NULL };
|
|
|
|
if (close(STDIN_FILENO) < 0)
|
|
goto cleanup1;
|
|
if (close(STDERR_FILENO) < 0)
|
|
goto cleanup1;
|
|
if (close(newstdout[0]) < 0)
|
|
goto cleanup1;
|
|
if (dup2(newstdout[1], STDOUT_FILENO) < 0)
|
|
goto cleanup1;
|
|
|
|
/* Passing -help, rather than relying on no-args which doesn't
|
|
always work */
|
|
execle(qemu, qemu, "-help", (char*)NULL, qemuenv);
|
|
|
|
cleanup1:
|
|
_exit(-1); /* Just in case */
|
|
} else { /* Parent */
|
|
char help[8192]; /* Ought to be enough to hold QEMU help screen */
|
|
int got = 0, ret = -1;
|
|
int major, minor, micro;
|
|
int ver;
|
|
|
|
if (close(newstdout[1]) < 0)
|
|
goto cleanup2;
|
|
|
|
while (got < (sizeof(help)-1)) {
|
|
int len;
|
|
if ((len = read(newstdout[0], help+got, sizeof(help)-got-1)) <= 0) {
|
|
if (!len)
|
|
break;
|
|
if (errno == EINTR)
|
|
continue;
|
|
goto cleanup2;
|
|
}
|
|
got += len;
|
|
}
|
|
help[got] = '\0';
|
|
|
|
if (sscanf(help, "QEMU PC emulator version %d.%d.%d", &major,&minor, µ) != 3) {
|
|
goto cleanup2;
|
|
}
|
|
|
|
ver = (major * 1000 * 1000) + (minor * 1000) + micro;
|
|
if (version)
|
|
*version = ver;
|
|
if (flags) {
|
|
if (strstr(help, "-no-kqemu"))
|
|
*flags |= QEMUD_CMD_FLAG_KQEMU;
|
|
if (strstr(help, "-no-reboot"))
|
|
*flags |= QEMUD_CMD_FLAG_NO_REBOOT;
|
|
if (strstr(help, "-name"))
|
|
*flags |= QEMUD_CMD_FLAG_NAME;
|
|
if (strstr(help, "-drive"))
|
|
*flags |= QEMUD_CMD_FLAG_DRIVE;
|
|
if (strstr(help, "boot=on"))
|
|
*flags |= QEMUD_CMD_FLAG_DRIVE_BOOT;
|
|
if (ver >= 9000)
|
|
*flags |= QEMUD_CMD_FLAG_VNC_COLON;
|
|
}
|
|
ret = 0;
|
|
|
|
qemudDebug("Version %d %d %d Cooked version: %d, with flags ? %d",
|
|
major, minor, micro, *version, *flags);
|
|
|
|
cleanup2:
|
|
if (close(newstdout[0]) < 0)
|
|
ret = -1;
|
|
|
|
rewait:
|
|
if (waitpid(child, &got, 0) != child) {
|
|
if (errno == EINTR) {
|
|
goto rewait;
|
|
}
|
|
qemudLog(QEMUD_ERR,
|
|
_("Unexpected exit status from qemu %d pid %lu"),
|
|
got, (unsigned long)child);
|
|
ret = -1;
|
|
}
|
|
/* Check & log unexpected exit status, but don't fail,
|
|
* as there's really no need to throw an error if we did
|
|
* actually read a valid version number above */
|
|
if (WEXITSTATUS(got) != 0) {
|
|
qemudLog(QEMUD_WARN,
|
|
_("Unexpected exit status '%d', qemu probably failed"),
|
|
got);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
int qemudExtractVersion(virConnectPtr conn,
|
|
struct qemud_driver *driver) {
|
|
const char *binary;
|
|
struct stat sb;
|
|
int ignored;
|
|
|
|
if (driver->qemuVersion > 0)
|
|
return 0;
|
|
|
|
if ((binary = virCapabilitiesDefaultGuestEmulator(driver->caps,
|
|
"hvm",
|
|
"i686",
|
|
"qemu")) == NULL)
|
|
return -1;
|
|
|
|
if (stat(binary, &sb) < 0) {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("Cannot find QEMU binary %s: %s"), binary,
|
|
strerror(errno));
|
|
return -1;
|
|
}
|
|
|
|
if (qemudExtractVersionInfo(binary, &driver->qemuVersion, &ignored) < 0) {
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
static char *
|
|
qemudNetworkIfaceConnect(virConnectPtr conn,
|
|
struct qemud_driver *driver,
|
|
int **tapfds,
|
|
int *ntapfds,
|
|
virDomainNetDefPtr net,
|
|
int vlan)
|
|
{
|
|
virNetworkObjPtr network = NULL;
|
|
char *brname;
|
|
char tapfdstr[4+3+32+7];
|
|
char *retval = NULL;
|
|
int err;
|
|
int tapfd = -1;
|
|
|
|
if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
|
|
if (!(network = virNetworkFindByName(driver->networks, net->data.network.name))) {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("Network '%s' not found"),
|
|
net->data.network.name);
|
|
goto error;
|
|
} else if (network->def->bridge == NULL) {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("Network '%s' not active"),
|
|
net->data.network.name);
|
|
goto error;
|
|
}
|
|
brname = network->def->bridge;
|
|
} else if (net->type == VIR_DOMAIN_NET_TYPE_BRIDGE) {
|
|
brname = net->data.bridge.brname;
|
|
} else {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("Network type %d is not supported"), net->type);
|
|
goto error;
|
|
}
|
|
|
|
if (!net->ifname ||
|
|
STRPREFIX(net->ifname, "vnet") ||
|
|
strchr(net->ifname, '%')) {
|
|
VIR_FREE(net->ifname);
|
|
if (!(net->ifname = strdup("vnet%d"))) {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY, NULL);
|
|
goto error;
|
|
}
|
|
}
|
|
|
|
if (!driver->brctl && (err = brInit(&driver->brctl))) {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("cannot initialize bridge support: %s"),
|
|
strerror(err));
|
|
goto error;
|
|
}
|
|
|
|
if ((err = brAddTap(driver->brctl, brname,
|
|
&net->ifname, &tapfd))) {
|
|
if (errno == ENOTSUP) {
|
|
/* In this particular case, give a better diagnostic. */
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("Failed to add tap interface to bridge. "
|
|
"%s is not a bridge device"), brname);
|
|
} else {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("Failed to add tap interface '%s' "
|
|
"to bridge '%s' : %s"),
|
|
net->ifname, brname, strerror(err));
|
|
}
|
|
goto error;
|
|
}
|
|
|
|
snprintf(tapfdstr, sizeof(tapfdstr),
|
|
"tap,fd=%d,script=,vlan=%d,ifname=%s",
|
|
tapfd, vlan, net->ifname);
|
|
|
|
if (!(retval = strdup(tapfdstr)))
|
|
goto no_memory;
|
|
|
|
if (VIR_REALLOC_N(*tapfds, (*ntapfds)+1) < 0)
|
|
goto no_memory;
|
|
|
|
(*tapfds)[(*ntapfds)++] = tapfd;
|
|
|
|
return retval;
|
|
|
|
no_memory:
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY,
|
|
"%s", _("failed to allocate space for tapfds string"));
|
|
error:
|
|
VIR_FREE(retval);
|
|
if (tapfd != -1)
|
|
close(tapfd);
|
|
return NULL;
|
|
}
|
|
|
|
static int qemudBuildCommandLineChrDevStr(virDomainChrDefPtr dev,
|
|
char *buf,
|
|
int buflen)
|
|
{
|
|
switch (dev->type) {
|
|
case VIR_DOMAIN_CHR_TYPE_NULL:
|
|
strncpy(buf, "null", buflen);
|
|
buf[buflen-1] = '\0';
|
|
break;
|
|
|
|
case VIR_DOMAIN_CHR_TYPE_VC:
|
|
strncpy(buf, "vc", buflen);
|
|
buf[buflen-1] = '\0';
|
|
break;
|
|
|
|
case VIR_DOMAIN_CHR_TYPE_PTY:
|
|
strncpy(buf, "pty", buflen);
|
|
buf[buflen-1] = '\0';
|
|
break;
|
|
|
|
case VIR_DOMAIN_CHR_TYPE_DEV:
|
|
if (snprintf(buf, buflen, "%s",
|
|
dev->data.file.path) >= buflen)
|
|
return -1;
|
|
break;
|
|
|
|
case VIR_DOMAIN_CHR_TYPE_FILE:
|
|
if (snprintf(buf, buflen, "file:%s",
|
|
dev->data.file.path) >= buflen)
|
|
return -1;
|
|
break;
|
|
|
|
case VIR_DOMAIN_CHR_TYPE_PIPE:
|
|
if (snprintf(buf, buflen, "pipe:%s",
|
|
dev->data.file.path) >= buflen)
|
|
return -1;
|
|
break;
|
|
|
|
case VIR_DOMAIN_CHR_TYPE_STDIO:
|
|
strncpy(buf, "stdio", buflen);
|
|
buf[buflen-1] = '\0';
|
|
break;
|
|
|
|
case VIR_DOMAIN_CHR_TYPE_UDP:
|
|
if (snprintf(buf, buflen, "udp:%s:%s@%s:%s",
|
|
dev->data.udp.connectHost,
|
|
dev->data.udp.connectService,
|
|
dev->data.udp.bindHost,
|
|
dev->data.udp.bindService) >= buflen)
|
|
return -1;
|
|
break;
|
|
|
|
case VIR_DOMAIN_CHR_TYPE_TCP:
|
|
if (snprintf(buf, buflen, "%s:%s:%s%s",
|
|
dev->data.tcp.protocol == VIR_DOMAIN_CHR_TCP_PROTOCOL_TELNET ? "telnet" : "tcp",
|
|
dev->data.tcp.host,
|
|
dev->data.tcp.service,
|
|
dev->data.tcp.listen ? ",listen" : "") >= buflen)
|
|
return -1;
|
|
break;
|
|
|
|
case VIR_DOMAIN_CHR_TYPE_UNIX:
|
|
if (snprintf(buf, buflen, "unix:%s%s",
|
|
dev->data.nix.path,
|
|
dev->data.nix.listen ? ",listen" : "") >= buflen)
|
|
return -1;
|
|
break;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/*
|
|
* Constructs a argv suitable for launching qemu with config defined
|
|
* for a given virtual machine.
|
|
*/
|
|
int qemudBuildCommandLine(virConnectPtr conn,
|
|
struct qemud_driver *driver,
|
|
virDomainObjPtr vm,
|
|
int qemuCmdFlags,
|
|
char ***retargv,
|
|
int **tapfds,
|
|
int *ntapfds,
|
|
const char *migrateFrom) {
|
|
int i;
|
|
char memory[50];
|
|
char vcpus[50];
|
|
char boot[VIR_DOMAIN_BOOT_LAST];
|
|
virDomainDiskDefPtr disk = vm->def->disks;
|
|
virDomainNetDefPtr net = vm->def->nets;
|
|
virDomainInputDefPtr input = vm->def->inputs;
|
|
virDomainSoundDefPtr sound = vm->def->sounds;
|
|
virDomainHostdevDefPtr hostdev = vm->def->hostdevs;
|
|
virDomainChrDefPtr serial = vm->def->serials;
|
|
virDomainChrDefPtr parallel = vm->def->parallels;
|
|
struct utsname ut;
|
|
int disableKQEMU = 0;
|
|
int qargc = 0, qarga = 0;
|
|
char **qargv = NULL;
|
|
|
|
uname(&ut);
|
|
|
|
/* Nasty hack make i?86 look like i686 to simplify next comparison */
|
|
if (ut.machine[0] == 'i' &&
|
|
ut.machine[2] == '8' &&
|
|
ut.machine[3] == '6' &&
|
|
!ut.machine[4])
|
|
ut.machine[1] = '6';
|
|
|
|
/* Need to explicitly disable KQEMU if
|
|
* 1. Arch matches host arch
|
|
* 2. Guest is 'qemu'
|
|
* 3. The qemu binary has the -no-kqemu flag
|
|
*/
|
|
if ((qemuCmdFlags & QEMUD_CMD_FLAG_KQEMU) &&
|
|
STREQ(ut.machine, vm->def->os.arch) &&
|
|
vm->def->virtType == VIR_DOMAIN_VIRT_QEMU)
|
|
disableKQEMU = 1;
|
|
|
|
#define ADD_ARG_SPACE \
|
|
do { \
|
|
if (qargc == qarga) { \
|
|
qarga += 10; \
|
|
if (VIR_REALLOC_N(qargv, qarga) < 0) \
|
|
goto no_memory; \
|
|
} \
|
|
} while (0)
|
|
|
|
#define ADD_ARG(thisarg) \
|
|
do { \
|
|
ADD_ARG_SPACE; \
|
|
qargv[qargc++] = thisarg; \
|
|
} while (0)
|
|
|
|
#define ADD_ARG_LIT(thisarg) \
|
|
do { \
|
|
ADD_ARG_SPACE; \
|
|
if ((qargv[qargc++] = strdup(thisarg)) == NULL) \
|
|
goto no_memory; \
|
|
} while (0)
|
|
|
|
#define ADD_USBDISK(thisarg) \
|
|
do { \
|
|
ADD_ARG_LIT("-usbdevice"); \
|
|
ADD_ARG_SPACE; \
|
|
if ((asprintf(&qargv[qargc++], "disk:%s", thisarg)) == -1) { \
|
|
qargv[qargc-1] = NULL; \
|
|
goto no_memory; \
|
|
} \
|
|
} while (0)
|
|
|
|
snprintf(memory, sizeof(memory), "%lu", vm->def->memory/1024);
|
|
snprintf(vcpus, sizeof(vcpus), "%lu", vm->def->vcpus);
|
|
|
|
|
|
ADD_ARG_LIT(vm->def->emulator);
|
|
ADD_ARG_LIT("-S");
|
|
ADD_ARG_LIT("-M");
|
|
ADD_ARG_LIT(vm->def->os.machine);
|
|
if (disableKQEMU)
|
|
ADD_ARG_LIT("-no-kqemu");
|
|
ADD_ARG_LIT("-m");
|
|
ADD_ARG_LIT(memory);
|
|
ADD_ARG_LIT("-smp");
|
|
ADD_ARG_LIT(vcpus);
|
|
|
|
if (qemuCmdFlags & QEMUD_CMD_FLAG_NAME) {
|
|
ADD_ARG_LIT("-name");
|
|
ADD_ARG_LIT(vm->def->name);
|
|
}
|
|
/*
|
|
* NB, -nographic *MUST* come before any serial, or monitor
|
|
* or parallel port flags due to QEMU craziness, where it
|
|
* decides to change the serial port & monitor to be on stdout
|
|
* if you ask for nographic. So we have to make sure we override
|
|
* these defaults ourselves...
|
|
*/
|
|
if (!vm->def->graphics)
|
|
ADD_ARG_LIT("-nographic");
|
|
|
|
ADD_ARG_LIT("-monitor");
|
|
ADD_ARG_LIT("pty");
|
|
|
|
if (vm->def->localtime)
|
|
ADD_ARG_LIT("-localtime");
|
|
|
|
if ((qemuCmdFlags & QEMUD_CMD_FLAG_NO_REBOOT) &&
|
|
vm->def->onReboot != VIR_DOMAIN_LIFECYCLE_RESTART)
|
|
ADD_ARG_LIT("-no-reboot");
|
|
|
|
if (!(vm->def->features & (1 << VIR_DOMAIN_FEATURE_ACPI)))
|
|
ADD_ARG_LIT("-no-acpi");
|
|
|
|
if (!vm->def->os.bootloader) {
|
|
for (i = 0 ; i < vm->def->os.nBootDevs ; i++) {
|
|
switch (vm->def->os.bootDevs[i]) {
|
|
case VIR_DOMAIN_BOOT_CDROM:
|
|
boot[i] = 'd';
|
|
break;
|
|
case VIR_DOMAIN_BOOT_FLOPPY:
|
|
boot[i] = 'a';
|
|
break;
|
|
case VIR_DOMAIN_BOOT_DISK:
|
|
boot[i] = 'c';
|
|
break;
|
|
case VIR_DOMAIN_BOOT_NET:
|
|
boot[i] = 'n';
|
|
break;
|
|
default:
|
|
boot[i] = 'c';
|
|
break;
|
|
}
|
|
}
|
|
boot[vm->def->os.nBootDevs] = '\0';
|
|
ADD_ARG_LIT("-boot");
|
|
ADD_ARG_LIT(boot);
|
|
|
|
if (vm->def->os.kernel) {
|
|
ADD_ARG_LIT("-kernel");
|
|
ADD_ARG_LIT(vm->def->os.kernel);
|
|
}
|
|
if (vm->def->os.initrd) {
|
|
ADD_ARG_LIT("-initrd");
|
|
ADD_ARG_LIT(vm->def->os.initrd);
|
|
}
|
|
if (vm->def->os.cmdline) {
|
|
ADD_ARG_LIT("-append");
|
|
ADD_ARG_LIT(vm->def->os.cmdline);
|
|
}
|
|
} else {
|
|
ADD_ARG_LIT("-bootloader");
|
|
ADD_ARG_LIT(vm->def->os.bootloader);
|
|
}
|
|
|
|
/* If QEMU supports -drive param instead of old -hda, -hdb, -cdrom .. */
|
|
if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE) {
|
|
int bootCD = 0, bootFloppy = 0, bootDisk = 0;
|
|
|
|
/* If QEMU supports boot=on for -drive param... */
|
|
if (qemuCmdFlags & QEMUD_CMD_FLAG_DRIVE_BOOT) {
|
|
for (i = 0 ; i < vm->def->os.nBootDevs ; i++) {
|
|
switch (vm->def->os.bootDevs[i]) {
|
|
case VIR_DOMAIN_BOOT_CDROM:
|
|
bootCD = 1;
|
|
break;
|
|
case VIR_DOMAIN_BOOT_FLOPPY:
|
|
bootFloppy = 1;
|
|
break;
|
|
case VIR_DOMAIN_BOOT_DISK:
|
|
bootDisk = 1;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
while (disk) {
|
|
char opt[PATH_MAX];
|
|
const char *media = NULL;
|
|
int bootable = 0;
|
|
int idx = virDiskNameToIndex(disk->dst);
|
|
const char *bus = virDomainDiskQEMUBusTypeToString(disk->bus);
|
|
|
|
if (disk->bus == VIR_DOMAIN_DISK_BUS_USB) {
|
|
if (disk->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
|
|
ADD_USBDISK(disk->src);
|
|
} else {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("unsupported usb disk type for '%s'"), disk->src);
|
|
goto error;
|
|
}
|
|
disk = disk->next;
|
|
continue;
|
|
}
|
|
|
|
if (idx < 0) {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("unsupported disk type '%s'"), disk->dst);
|
|
goto error;
|
|
}
|
|
|
|
switch (disk->device) {
|
|
case VIR_DOMAIN_DISK_DEVICE_CDROM:
|
|
bootable = bootCD;
|
|
bootCD = 0;
|
|
media = "media=cdrom,";
|
|
break;
|
|
case VIR_DOMAIN_DISK_DEVICE_FLOPPY:
|
|
bootable = bootFloppy;
|
|
bootFloppy = 0;
|
|
break;
|
|
case VIR_DOMAIN_DISK_DEVICE_DISK:
|
|
bootable = bootDisk;
|
|
bootDisk = 0;
|
|
break;
|
|
}
|
|
|
|
snprintf(opt, PATH_MAX, "file=%s,if=%s,%sindex=%d%s",
|
|
disk->src ? disk->src : "", bus,
|
|
media ? media : "",
|
|
idx,
|
|
bootable &&
|
|
disk->device == VIR_DOMAIN_DISK_DEVICE_DISK
|
|
? ",boot=on" : "");
|
|
|
|
ADD_ARG_LIT("-drive");
|
|
ADD_ARG_LIT(opt);
|
|
disk = disk->next;
|
|
}
|
|
} else {
|
|
while (disk) {
|
|
char dev[NAME_MAX];
|
|
char file[PATH_MAX];
|
|
|
|
if (disk->bus == VIR_DOMAIN_DISK_BUS_USB) {
|
|
if (disk->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
|
|
ADD_USBDISK(disk->src);
|
|
} else {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("unsupported usb disk type for '%s'"), disk->src);
|
|
goto error;
|
|
}
|
|
disk = disk->next;
|
|
continue;
|
|
}
|
|
|
|
if (STREQ(disk->dst, "hdc") &&
|
|
disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) {
|
|
if (disk->src) {
|
|
snprintf(dev, NAME_MAX, "-%s", "cdrom");
|
|
} else {
|
|
disk = disk->next;
|
|
continue;
|
|
}
|
|
} else {
|
|
if (STRPREFIX(disk->dst, "hd") ||
|
|
STRPREFIX(disk->dst, "fd")) {
|
|
snprintf(dev, NAME_MAX, "-%s", disk->dst);
|
|
} else {
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
_("unsupported disk type '%s'"), disk->dst);
|
|
goto error;
|
|
}
|
|
}
|
|
|
|
snprintf(file, PATH_MAX, "%s", disk->src);
|
|
|
|
ADD_ARG_LIT(dev);
|
|
ADD_ARG_LIT(file);
|
|
|
|
disk = disk->next;
|
|
}
|
|
}
|
|
|
|
if (!net) {
|
|
ADD_ARG_LIT("-net");
|
|
ADD_ARG_LIT("none");
|
|
} else {
|
|
int vlan = 0;
|
|
while (net) {
|
|
char nic[100];
|
|
|
|
if (snprintf(nic, sizeof(nic),
|
|
"nic,macaddr=%02x:%02x:%02x:%02x:%02x:%02x,vlan=%d%s%s",
|
|
net->mac[0], net->mac[1],
|
|
net->mac[2], net->mac[3],
|
|
net->mac[4], net->mac[5],
|
|
vlan,
|
|
(net->model ? ",model=" : ""),
|
|
(net->model ? net->model : "")) >= sizeof(nic))
|
|
goto error;
|
|
|
|
ADD_ARG_LIT("-net");
|
|
ADD_ARG_LIT(nic);
|
|
ADD_ARG_LIT("-net");
|
|
|
|
switch (net->type) {
|
|
case VIR_DOMAIN_NET_TYPE_NETWORK:
|
|
case VIR_DOMAIN_NET_TYPE_BRIDGE:
|
|
{
|
|
char *tap = qemudNetworkIfaceConnect(conn, driver,
|
|
tapfds, ntapfds,
|
|
net, vlan);
|
|
if (tap == NULL)
|
|
goto error;
|
|
ADD_ARG(tap);
|
|
break;
|
|
}
|
|
|
|
case VIR_DOMAIN_NET_TYPE_ETHERNET:
|
|
{
|
|
char arg[PATH_MAX];
|
|
if (snprintf(arg, PATH_MAX-1, "tap,ifname=%s,script=%s,vlan=%d",
|
|
net->ifname,
|
|
net->data.ethernet.script,
|
|
vlan) >= (PATH_MAX-1))
|
|
goto error;
|
|
|
|
ADD_ARG_LIT(arg);
|
|
}
|
|
break;
|
|
|
|
case VIR_DOMAIN_NET_TYPE_CLIENT:
|
|
case VIR_DOMAIN_NET_TYPE_SERVER:
|
|
case VIR_DOMAIN_NET_TYPE_MCAST:
|
|
{
|
|
char arg[PATH_MAX];
|
|
const char *mode = NULL;
|
|
switch (net->type) {
|
|
case VIR_DOMAIN_NET_TYPE_CLIENT:
|
|
mode = "connect";
|
|
break;
|
|
case VIR_DOMAIN_NET_TYPE_SERVER:
|
|
mode = "listen";
|
|
break;
|
|
case VIR_DOMAIN_NET_TYPE_MCAST:
|
|
mode = "mcast";
|
|
break;
|
|
}
|
|
if (snprintf(arg, PATH_MAX-1, "socket,%s=%s:%d,vlan=%d",
|
|
mode,
|
|
net->data.socket.address,
|
|
net->data.socket.port,
|
|
vlan) >= (PATH_MAX-1))
|
|
goto error;
|
|
|
|
ADD_ARG_LIT(arg);
|
|
}
|
|
break;
|
|
|
|
case VIR_DOMAIN_NET_TYPE_USER:
|
|
default:
|
|
{
|
|
char arg[PATH_MAX];
|
|
if (snprintf(arg, PATH_MAX-1, "user,vlan=%d", vlan) >= (PATH_MAX-1))
|
|
goto error;
|
|
|
|
ADD_ARG_LIT(arg);
|
|
}
|
|
}
|
|
|
|
net = net->next;
|
|
vlan++;
|
|
}
|
|
}
|
|
|
|
if (!serial) {
|
|
ADD_ARG_LIT("-serial");
|
|
ADD_ARG_LIT("none");
|
|
} else {
|
|
while (serial) {
|
|
char buf[4096];
|
|
|
|
if (qemudBuildCommandLineChrDevStr(serial, buf, sizeof(buf)) < 0)
|
|
goto error;
|
|
|
|
ADD_ARG_LIT("-serial");
|
|
ADD_ARG_LIT(buf);
|
|
|
|
serial = serial->next;
|
|
}
|
|
}
|
|
|
|
if (!parallel) {
|
|
ADD_ARG_LIT("-parallel");
|
|
ADD_ARG_LIT("none");
|
|
} else {
|
|
while (parallel) {
|
|
char buf[4096];
|
|
|
|
if (qemudBuildCommandLineChrDevStr(parallel, buf, sizeof(buf)) < 0)
|
|
goto error;
|
|
|
|
ADD_ARG_LIT("-parallel");
|
|
ADD_ARG_LIT(buf);
|
|
|
|
parallel = parallel->next;
|
|
}
|
|
}
|
|
|
|
ADD_ARG_LIT("-usb");
|
|
while (input) {
|
|
if (input->bus == VIR_DOMAIN_INPUT_BUS_USB) {
|
|
ADD_ARG_LIT("-usbdevice");
|
|
ADD_ARG_LIT(input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE ? "mouse" : "tablet");
|
|
}
|
|
|
|
input = input->next;
|
|
}
|
|
|
|
if (vm->def->graphics &&
|
|
vm->def->graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC) {
|
|
char vncdisplay[PATH_MAX];
|
|
int ret;
|
|
|
|
if (qemuCmdFlags & QEMUD_CMD_FLAG_VNC_COLON) {
|
|
char options[PATH_MAX] = "";
|
|
if (driver->vncTLS) {
|
|
strcat(options, ",tls");
|
|
if (driver->vncTLSx509verify) {
|
|
strcat(options, ",x509verify=");
|
|
} else {
|
|
strcat(options, ",x509=");
|
|
}
|
|
strncat(options, driver->vncTLSx509certdir,
|
|
sizeof(options) - (strlen(driver->vncTLSx509certdir)-1));
|
|
options[sizeof(options)-1] = '\0';
|
|
}
|
|
ret = snprintf(vncdisplay, sizeof(vncdisplay), "%s:%d%s",
|
|
(vm->def->graphics->data.vnc.listenAddr ?
|
|
vm->def->graphics->data.vnc.listenAddr :
|
|
(driver->vncListen ? driver->vncListen : "")),
|
|
vm->def->graphics->data.vnc.port - 5900,
|
|
options);
|
|
} else {
|
|
ret = snprintf(vncdisplay, sizeof(vncdisplay), "%d",
|
|
vm->def->graphics->data.vnc.port - 5900);
|
|
}
|
|
if (ret < 0 || ret >= (int)sizeof(vncdisplay))
|
|
goto error;
|
|
|
|
ADD_ARG_LIT("-vnc");
|
|
ADD_ARG_LIT(vncdisplay);
|
|
if (vm->def->graphics->data.vnc.keymap) {
|
|
ADD_ARG_LIT("-k");
|
|
ADD_ARG_LIT(vm->def->graphics->data.vnc.keymap);
|
|
}
|
|
} else if (vm->def->graphics &&
|
|
vm->def->graphics->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL) {
|
|
/* SDL is the default. no args needed */
|
|
}
|
|
|
|
/* Add sound hardware */
|
|
if (sound) {
|
|
int size = 100;
|
|
char *modstr;
|
|
if (VIR_ALLOC_N(modstr, size+1) < 0)
|
|
goto no_memory;
|
|
|
|
while(sound && size > 0) {
|
|
const char *model = virDomainSoundModelTypeToString(sound->model);
|
|
if (!model) {
|
|
VIR_FREE(modstr);
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
|
|
"%s", _("invalid sound model"));
|
|
goto error;
|
|
}
|
|
strncat(modstr, model, size);
|
|
size -= strlen(model);
|
|
sound = sound->next;
|
|
if (sound)
|
|
strncat(modstr, ",", size--);
|
|
}
|
|
ADD_ARG_LIT("-soundhw");
|
|
ADD_ARG(modstr);
|
|
}
|
|
|
|
/* Add host passthrough hardware */
|
|
while (hostdev) {
|
|
int ret;
|
|
char* usbdev;
|
|
|
|
if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS &&
|
|
hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) {
|
|
if(hostdev->source.subsys.usb.vendor) {
|
|
ret = asprintf(&usbdev, "host:%.4x:%.4x",
|
|
hostdev->source.subsys.usb.vendor,
|
|
hostdev->source.subsys.usb.product);
|
|
|
|
} else {
|
|
ret = asprintf(&usbdev, "host:%.3d.%.3d",
|
|
hostdev->source.subsys.usb.bus,
|
|
hostdev->source.subsys.usb.device);
|
|
}
|
|
if (ret < 0) {
|
|
usbdev = NULL;
|
|
goto error;
|
|
}
|
|
ADD_ARG_LIT("-usbdevice");
|
|
ADD_ARG_LIT(usbdev);
|
|
VIR_FREE(usbdev);
|
|
}
|
|
hostdev = hostdev->next;
|
|
}
|
|
|
|
if (migrateFrom) {
|
|
ADD_ARG_LIT("-incoming");
|
|
ADD_ARG_LIT(migrateFrom);
|
|
}
|
|
|
|
ADD_ARG(NULL);
|
|
|
|
*retargv = qargv;
|
|
return 0;
|
|
|
|
no_memory:
|
|
qemudReportError(conn, NULL, NULL, VIR_ERR_NO_MEMORY,
|
|
"%s", _("failed to allocate space for argv string"));
|
|
error:
|
|
if (tapfds &&
|
|
*tapfds) {
|
|
for (i = 0; ntapfds; i++)
|
|
close((*tapfds)[i]);
|
|
VIR_FREE(*tapfds);
|
|
*ntapfds = 0;
|
|
}
|
|
if (qargv) {
|
|
for (i = 0 ; i < qargc ; i++)
|
|
VIR_FREE((qargv)[i]);
|
|
VIR_FREE(qargv);
|
|
}
|
|
return -1;
|
|
|
|
#undef ADD_ARG
|
|
#undef ADD_ARG_LIT
|
|
#undef ADD_ARG_SPACE
|
|
}
|
|
|
|
|
|
#endif /* WITH_QEMU */
|