mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-02 11:21:12 +00:00
0b856db8ab
Remove unused variable. Fix for [1]
[1] 821dd6d8
: storage: Use VIR_AUTOFREE for storage backends
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
174 lines
4.4 KiB
C
174 lines
4.4 KiB
C
#include <config.h>
|
|
|
|
#include "viralloc.h"
|
|
#include "virerror.h"
|
|
#include "virfile.h"
|
|
#include "storage_backend_vstorage.h"
|
|
#include "virlog.h"
|
|
#include "virstring.h"
|
|
#include <mntent.h>
|
|
#include <pwd.h>
|
|
#include <grp.h>
|
|
#include "storage_util.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_STORAGE
|
|
|
|
VIR_LOG_INIT("storage.storage_backend_vstorage");
|
|
|
|
|
|
/**
|
|
* @pool storage pool to build
|
|
* @flags controls the pool formatting behaviour
|
|
*
|
|
* Does not support @flags, if provided an error will occur.
|
|
*
|
|
* Returns 0 on success, -1 on error
|
|
*/
|
|
static int
|
|
virStorageBackendVzPoolBuild(virStoragePoolObjPtr pool,
|
|
unsigned int flags)
|
|
{
|
|
virCheckFlags(0, -1);
|
|
|
|
return virStorageBackendBuildLocal(pool);
|
|
}
|
|
|
|
|
|
static int
|
|
virStorageBackendVzPoolStart(virStoragePoolObjPtr pool)
|
|
{
|
|
virStoragePoolDefPtr def = virStoragePoolObjGetDef(pool);
|
|
VIR_AUTOFREE(char *) grp_name = NULL;
|
|
VIR_AUTOFREE(char *) usr_name = NULL;
|
|
VIR_AUTOFREE(char *) mode = NULL;
|
|
VIR_AUTOPTR(virCommand) cmd = NULL;
|
|
|
|
/* Check the permissions */
|
|
if (def->target.perms.mode == (mode_t)-1)
|
|
def->target.perms.mode = VIR_STORAGE_DEFAULT_POOL_PERM_MODE;
|
|
if (def->target.perms.uid == (uid_t)-1)
|
|
def->target.perms.uid = geteuid();
|
|
if (def->target.perms.gid == (gid_t)-1)
|
|
def->target.perms.gid = getegid();
|
|
|
|
/* Convert ids to names because vstorage uses names */
|
|
|
|
if (!(grp_name = virGetGroupName(def->target.perms.gid)))
|
|
return -1;
|
|
|
|
if (!(usr_name = virGetUserName(def->target.perms.uid)))
|
|
return -1;
|
|
|
|
if (virAsprintf(&mode, "%o", def->target.perms.mode) < 0)
|
|
return -1;
|
|
|
|
cmd = virCommandNewArgList(VSTORAGE_MOUNT,
|
|
"-c", def->source.name,
|
|
def->target.path,
|
|
"-m", mode,
|
|
"-g", grp_name, "-u", usr_name,
|
|
NULL);
|
|
|
|
return virCommandRun(cmd, NULL);
|
|
}
|
|
|
|
|
|
static int
|
|
virStorageBackendVzIsMounted(virStoragePoolObjPtr pool)
|
|
{
|
|
int ret = -1;
|
|
virStoragePoolDefPtr def = virStoragePoolObjGetDef(pool);
|
|
FILE *mtab;
|
|
struct mntent ent;
|
|
char buf[1024];
|
|
VIR_AUTOFREE(char *) cluster = NULL;
|
|
|
|
if (virAsprintf(&cluster, "vstorage://%s", def->source.name) < 0)
|
|
return -1;
|
|
|
|
if ((mtab = fopen(_PATH_MOUNTED, "r")) == NULL) {
|
|
virReportSystemError(errno,
|
|
_("cannot read mount list '%s'"),
|
|
_PATH_MOUNTED);
|
|
goto cleanup;
|
|
}
|
|
|
|
while ((getmntent_r(mtab, &ent, buf, sizeof(buf))) != NULL) {
|
|
|
|
if (STREQ(ent.mnt_dir, def->target.path) &&
|
|
STREQ(ent.mnt_fsname, cluster)) {
|
|
ret = 1;
|
|
goto cleanup;
|
|
}
|
|
}
|
|
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
VIR_FORCE_FCLOSE(mtab);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static int
|
|
virStorageBackendVzPoolStop(virStoragePoolObjPtr pool)
|
|
{
|
|
virStoragePoolDefPtr def = virStoragePoolObjGetDef(pool);
|
|
int rc;
|
|
VIR_AUTOPTR(virCommand) cmd = NULL;
|
|
|
|
/* Short-circuit if already unmounted */
|
|
if ((rc = virStorageBackendVzIsMounted(pool)) != 1)
|
|
return rc;
|
|
|
|
cmd = virCommandNewArgList(UMOUNT, def->target.path, NULL);
|
|
return virCommandRun(cmd, NULL);
|
|
}
|
|
|
|
|
|
/*
|
|
* Check whether the cluster is mounted
|
|
*/
|
|
static int
|
|
virStorageBackendVzCheck(virStoragePoolObjPtr pool,
|
|
bool *isActive)
|
|
{
|
|
int ret = -1;
|
|
*isActive = false;
|
|
if ((ret = virStorageBackendVzIsMounted(pool)) != 0) {
|
|
if (ret < 0)
|
|
return -1;
|
|
*isActive = true;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
|
|
virStorageBackend virStorageBackendVstorage = {
|
|
.type = VIR_STORAGE_POOL_VSTORAGE,
|
|
|
|
.buildPool = virStorageBackendVzPoolBuild,
|
|
.startPool = virStorageBackendVzPoolStart,
|
|
.stopPool = virStorageBackendVzPoolStop,
|
|
.deletePool = virStorageBackendDeleteLocal,
|
|
.refreshPool = virStorageBackendRefreshLocal,
|
|
.checkPool = virStorageBackendVzCheck,
|
|
.buildVol = virStorageBackendVolBuildLocal,
|
|
.buildVolFrom = virStorageBackendVolBuildFromLocal,
|
|
.createVol = virStorageBackendVolCreateLocal,
|
|
.refreshVol = virStorageBackendVolRefreshLocal,
|
|
.deleteVol = virStorageBackendVolDeleteLocal,
|
|
.resizeVol = virStorageBackendVolResizeLocal,
|
|
.uploadVol = virStorageBackendVolUploadLocal,
|
|
.downloadVol = virStorageBackendVolDownloadLocal,
|
|
.wipeVol = virStorageBackendVolWipeLocal,
|
|
};
|
|
|
|
|
|
int
|
|
virStorageBackendVstorageRegister(void)
|
|
{
|
|
return virStorageBackendRegister(&virStorageBackendVstorage);
|
|
}
|