mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-12 12:55:46 +00:00
Our coding style expects a long line to be broken into shorter lines which are then aligned on the first character, for instance: "some string that's broken " "into multiple lines" However, one can argue that there are few cases where shifting the alignment makes the code more readable. And this is the case of expected cmd line for DO_TEST_SET() where a long cmd line can be aligned on the arguments rather than the binary: TC " filter ..." " police ..." Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
166 lines
5.9 KiB
C
166 lines
5.9 KiB
C
/*
|
|
* Copyright (C) 2014 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "testutils.h"
|
|
#define LIBVIRT_VIRCOMMANDPRIV_H_ALLOW
|
|
#include "vircommandpriv.h"
|
|
#include "virnetdevbandwidth.h"
|
|
#include "netdev_bandwidth_conf.c"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_NONE
|
|
|
|
struct testSetStruct {
|
|
const char *band;
|
|
const char *exp_cmd;
|
|
const char *iface;
|
|
const bool hierarchical_class;
|
|
};
|
|
|
|
static int
|
|
testVirNetDevBandwidthParse(virNetDevBandwidth **var,
|
|
const char *xml)
|
|
{
|
|
g_autoptr(xmlDoc) doc = NULL;
|
|
g_autoptr(xmlXPathContext) ctxt = NULL;
|
|
|
|
if (!xml)
|
|
return 0;
|
|
|
|
if (!(doc = virXMLParseStringCtxt((xml),
|
|
"bandwidth definition",
|
|
&ctxt)))
|
|
return -1;
|
|
|
|
return virNetDevBandwidthParse(var,
|
|
NULL,
|
|
ctxt->node,
|
|
true);
|
|
}
|
|
|
|
static int
|
|
testVirNetDevBandwidthSet(const void *data)
|
|
{
|
|
const struct testSetStruct *info = data;
|
|
const char *iface = info->iface;
|
|
g_autoptr(virNetDevBandwidth) band = NULL;
|
|
g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER;
|
|
g_autofree char *actual_cmd = NULL;
|
|
g_autoptr(virCommandDryRunToken) dryRunToken = virCommandDryRunTokenNew();
|
|
|
|
if (testVirNetDevBandwidthParse(&band, info->band) < 0)
|
|
return -1;
|
|
|
|
if (!iface)
|
|
iface = "eth0";
|
|
|
|
virCommandSetDryRun(dryRunToken, &buf, false, false, NULL, NULL);
|
|
|
|
if (virNetDevBandwidthSet(iface, band, info->hierarchical_class, true) < 0)
|
|
return -1;
|
|
|
|
if (!(actual_cmd = virBufferContentAndReset(&buf))) {
|
|
/* This is interesting, no command has been executed.
|
|
* Maybe that's expected, actually. */
|
|
}
|
|
|
|
if (STRNEQ_NULLABLE(info->exp_cmd, actual_cmd)) {
|
|
virTestDifference(stderr,
|
|
NULLSTR(info->exp_cmd),
|
|
NULLSTR(actual_cmd));
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
|
|
#define DO_TEST_SET(Band, Exp_cmd, ...) \
|
|
do { \
|
|
struct testSetStruct data = {.band = Band, \
|
|
.exp_cmd = Exp_cmd, \
|
|
__VA_ARGS__}; \
|
|
if (virTestRun("virNetDevBandwidthSet", \
|
|
testVirNetDevBandwidthSet, \
|
|
&data) < 0) \
|
|
ret = -1; \
|
|
} while (0)
|
|
|
|
|
|
DO_TEST_SET(NULL, NULL);
|
|
|
|
DO_TEST_SET("<bandwidth/>", NULL);
|
|
|
|
DO_TEST_SET("<bandwidth>"
|
|
" <inbound average='1024'/>"
|
|
"</bandwidth>",
|
|
TC " qdisc del dev eth0 root\n"
|
|
TC " qdisc del dev eth0 ingress\n"
|
|
TC " qdisc add dev eth0 root handle 1: htb default 1\n"
|
|
TC " class add dev eth0 parent 1: classid 1:1 htb rate 1024kbps quantum 87\n"
|
|
TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb 10\n"
|
|
TC " filter add dev eth0 parent 1:0 protocol all prio 1 handle 1 fw flowid 1\n");
|
|
|
|
DO_TEST_SET("<bandwidth>"
|
|
" <outbound average='1024'/>"
|
|
"</bandwidth>",
|
|
TC " qdisc del dev eth0 root\n"
|
|
TC " qdisc del dev eth0 ingress\n"
|
|
TC " qdisc add dev eth0 ingress\n"
|
|
TC " filter add dev eth0 parent ffff: protocol all u32 match u32 0 0"
|
|
" police rate 1024kbps burst 1024kb mtu 64kb drop flowid :1\n");
|
|
|
|
DO_TEST_SET("<bandwidth>"
|
|
" <inbound average='1' peak='2' floor='3' burst='4'/>"
|
|
" <outbound average='5' peak='6' burst='7'/>"
|
|
"</bandwidth>",
|
|
TC " qdisc del dev eth0 root\n"
|
|
TC " qdisc del dev eth0 ingress\n"
|
|
TC " qdisc add dev eth0 root handle 1: htb default 1\n"
|
|
TC " class add dev eth0 parent 1: classid 1:1 htb rate 1kbps ceil 2kbps burst 4kb quantum 1\n"
|
|
TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb 10\n"
|
|
TC " filter add dev eth0 parent 1:0 protocol all prio 1 handle 1 fw flowid 1\n"
|
|
TC " qdisc add dev eth0 ingress\n"
|
|
TC " filter add dev eth0 parent ffff: protocol all u32 match u32 0 0"
|
|
" police rate 5kbps burst 7kb mtu 64kb drop flowid :1\n");
|
|
|
|
DO_TEST_SET("<bandwidth>"
|
|
" <inbound average='4294967295'/>"
|
|
" <outbound average='4294967295'/>"
|
|
"</bandwidth>",
|
|
TC " qdisc del dev eth0 root\n"
|
|
TC " qdisc del dev eth0 ingress\n"
|
|
TC " qdisc add dev eth0 root handle 1: htb default 1\n"
|
|
TC " class add dev eth0 parent 1: classid 1:1 htb rate 4294967295kbps quantum 366503875\n"
|
|
TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb 10\n"
|
|
TC " filter add dev eth0 parent 1:0 protocol all prio 1 handle 1 fw flowid 1\n"
|
|
TC " qdisc add dev eth0 ingress\n"
|
|
TC " filter add dev eth0 parent ffff: protocol all u32 match"
|
|
" u32 0 0 police rate 4294967295kbps burst 4194303kb mtu 64kb"
|
|
" drop flowid :1\n");
|
|
|
|
return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
|
|
}
|
|
|
|
VIR_TEST_MAIN_PRELOAD(mymain, VIR_TEST_MOCK("virnetdevbandwidth"))
|