Dmitrii Shcherbakov
600f580d62
PCI VPD: Skip fields with invalid values
...
While invalid values need to be ignored when presenting VPD data to the
user, it would be good to attempt to parse a valid portion of the VPD
instead of marking it invalid as a whole.
Based on a mailing list discussion, the set of accepted characters is
extended to the set of printable ASCII characters.
https://listman.redhat.com/archives/libvir-list/2021-October/msg01043.html
The particular example encountered on real hardware was multi-faceted:
* "N/A" strings present in read-only fields. This would not be a useful
valid value for a field (especially if a unique serial number is
expected), however, it was decided to delegate handling of those kinds
of values to higher-level software;
* "4W/1W PCIeG2x4" - looks like some vendors use even more printable
characters in the ASCII range than we currently allow. Since the
PCI/PCIe VPD specs mention alphanumeric characters without specifying
the full character set, it looks like this is ambiguous for vendors
and they tend to use printable ASCII characters;
* 0xFF bytes present in VPD-W field values. Those bytes do not map to
printable ASCII code points and were probably used by the vendor as
placeholders. Ignoring the whole VPD because of that would be too
strict.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Dmitrii Shcherbakov <dmitrii.shcherbakov@canonical.com>
2021-11-02 13:43:23 +00:00
..
2020-10-19 11:50:49 +02:00
2021-03-20 07:53:45 +04:00
2021-04-21 14:20:03 +02:00
2021-02-08 18:50:47 +04:00
2021-04-12 15:55:10 +02:00
2021-05-07 18:02:48 +02:00
2021-10-20 16:52:45 +02:00
2020-10-20 09:05:10 +02:00
2021-08-17 13:50:38 +02:00
2021-07-20 16:43:46 +02:00
2020-09-18 08:51:47 +02:00
2020-11-24 14:21:08 -05:00
2021-07-16 14:50:57 +02:00
2021-07-16 14:50:57 +02:00
2021-07-16 14:50:57 +02:00
2021-09-14 14:24:07 -05:00
2021-10-21 17:34:04 +01:00
2021-10-21 17:34:04 +01:00
2021-01-04 15:33:31 +01:00
2021-04-12 15:55:10 +02:00
2020-10-20 09:05:10 +02:00
2021-08-20 15:43:17 +02:00
2021-11-01 17:37:15 +01:00
2020-11-20 12:09:51 +00:00
2021-03-09 22:58:30 +00:00
2021-01-08 15:27:00 +01:00
2021-03-09 22:58:30 +00:00
2021-11-01 16:14:53 +01:00
2021-05-03 12:14:44 +02:00
2021-09-23 14:48:51 +02:00
2021-10-22 07:00:44 +02:00
2021-08-25 15:32:44 +02:00
2020-11-06 09:14:01 +01:00
2021-10-25 14:06:15 +02:00
2021-11-02 09:23:53 +01:00
2021-11-02 09:23:53 +01:00
2021-01-08 09:18:21 +01:00
2021-04-12 15:55:10 +02:00
2021-05-21 14:00:43 +02:00
2021-05-21 14:00:43 +02:00
2021-05-21 14:00:43 +02:00
2021-07-15 14:50:48 +02:00
2021-02-10 13:37:12 +01:00
2020-10-05 10:28:43 +01:00
2021-09-09 15:29:00 +02:00
2021-08-19 13:32:10 +02:00
2020-12-07 15:38:31 -07:00
2020-12-07 15:38:31 -07:00
2021-04-01 13:36:35 +02:00
2021-04-13 17:00:38 +02:00
2021-09-08 15:13:12 +02:00
2021-10-25 12:48:46 +02:00
2021-04-21 14:20:03 +02:00
2021-02-08 18:50:47 +04:00
2021-03-05 15:33:34 +01:00
2021-05-24 20:26:20 +02:00
2021-09-09 18:06:13 +02:00
2021-10-01 10:58:27 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-08 15:31:01 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-11-02 10:52:18 +01:00
2021-05-18 09:09:37 -06:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-10-21 17:34:04 +01:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-14 14:24:07 -05:00
2021-10-21 17:34:04 +01:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-10-18 12:09:33 +02:00
2021-09-09 18:06:13 +02:00
2021-05-18 10:02:24 +02:00
2021-09-09 18:06:13 +02:00
2021-10-25 16:11:49 +02:00
2021-04-13 17:00:38 +02:00
2021-08-20 15:19:35 +02:00
2021-04-13 17:00:38 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-04-13 17:00:38 +02:00
2021-04-13 17:00:38 +02:00
2021-04-13 17:00:38 +02:00
2021-04-13 17:00:38 +02:00
2021-09-21 12:25:42 +02:00
2021-11-01 16:14:53 +01:00
2021-10-22 07:00:44 +02:00
2021-10-18 14:00:58 +02:00
2021-11-01 16:14:53 +01:00
2021-10-25 12:48:46 +02:00
2021-04-13 17:00:38 +02:00
2021-10-25 12:48:46 +02:00
2021-05-18 13:18:05 +02:00
2021-02-11 17:05:33 +01:00
2021-08-26 09:16:44 +02:00
2021-02-11 17:05:34 +01:00
2021-10-25 12:48:46 +02:00
2021-10-25 23:18:41 -04:00
2021-10-25 23:18:41 -04:00
2021-09-09 18:06:13 +02:00
2021-05-17 09:25:32 +02:00
2021-09-09 18:06:13 +02:00
2021-05-10 13:32:43 +02:00
2021-09-09 18:06:13 +02:00
2021-08-16 14:22:38 +02:00
2021-09-09 18:06:13 +02:00
2021-05-17 09:25:32 +02:00
2021-04-13 17:00:38 +02:00
2021-05-21 14:00:43 +02:00
2021-05-21 14:00:43 +02:00
2021-04-13 17:00:38 +02:00
2020-09-23 11:30:05 +02:00
2021-11-01 16:08:26 +01:00
2021-10-21 17:34:04 +01:00
2021-04-13 17:00:38 +02:00
2021-11-01 16:08:26 +01:00
2021-04-13 17:00:38 +02:00
2021-11-01 16:08:26 +01:00
2021-08-23 14:43:57 +02:00
2021-11-01 17:37:15 +01:00
2021-10-18 14:00:58 +02:00
2021-11-01 16:08:26 +01:00
2021-04-13 17:00:38 +02:00
2021-09-09 18:06:13 +02:00
2021-03-22 12:44:18 +01:00
2021-04-13 17:00:38 +02:00
2021-05-17 09:25:32 +02:00
2021-04-13 17:00:38 +02:00
2021-06-15 11:03:56 +02:00
2021-09-09 18:06:13 +02:00
2021-04-13 17:00:38 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-22 14:53:55 +02:00
2021-05-24 20:26:20 +02:00
2021-05-17 09:25:32 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-08-06 08:53:25 +02:00
2021-04-21 14:18:51 +02:00
2021-09-21 14:09:44 +02:00
2020-09-17 18:19:56 +02:00
2021-09-09 18:06:13 +02:00
2021-04-13 17:00:38 +02:00
2020-11-09 12:25:49 +01:00
2021-05-13 11:07:16 +01:00
2021-09-09 18:06:13 +02:00
2021-04-13 17:00:38 +02:00
2021-09-09 18:06:13 +02:00
2021-04-13 17:00:38 +02:00
2021-05-17 09:25:32 +02:00
2021-09-09 18:06:13 +02:00
2020-11-27 16:28:31 +01:00
2021-02-10 11:03:39 +01:00
2021-09-09 18:06:13 +02:00
2021-08-20 16:43:20 +02:00
2021-11-01 15:56:47 +01:00
2021-04-13 17:00:38 +02:00
2021-04-13 17:00:38 +02:00
2021-10-25 12:48:46 +02:00
2021-10-15 16:03:22 +02:00
2021-04-13 17:00:38 +02:00
2021-09-09 18:06:13 +02:00
2021-04-13 17:00:38 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-10-25 12:48:46 +02:00
2021-10-21 17:34:04 +01:00
2021-11-02 13:43:23 +00:00
2020-10-02 12:43:15 +02:00
2021-04-13 17:00:38 +02:00
2021-03-08 22:41:40 +01:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-04-13 17:00:38 +02:00
2021-09-09 18:06:13 +02:00
2021-03-22 12:05:18 +01:00
2020-11-23 14:44:39 +01:00
2021-01-06 09:25:07 +01:00
2021-06-02 16:43:57 +02:00
2020-11-23 14:44:39 +01:00
2020-11-23 14:44:39 +01:00
2020-11-23 14:44:39 +01:00
2021-01-06 09:25:07 +01:00
2020-11-23 14:44:39 +01:00
2021-01-06 09:25:07 +01:00
2021-09-23 13:41:39 +02:00
2021-09-17 14:28:00 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-10-25 12:48:46 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-11-01 16:08:26 +01:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-09-09 18:06:13 +02:00
2021-11-01 16:08:26 +01:00