mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-02 11:21:12 +00:00
3e2c3d8f6d
No thanks to 64-bit windows, with 64-bit pid_t, we have to avoid constructs like 'int pid'. Our API in libvirt-qemu cannot be changed without breaking ABI; but then again, libvirt-qemu can only be used on systems that support UNIX sockets, which rules out Windows (even if qemu could be compiled there) - so for all points on the call chain that interact with this API decision, we require a different variable name to make it clear that we audited the use for safety. Adding a syntax-check rule only solves half the battle; anywhere that uses printf on a pid_t still needs to be converted, but that will be a separate patch. * cfg.mk (sc_correct_id_types): New syntax check. * src/libvirt-qemu.c (virDomainQemuAttach): Document why we didn't use pid_t for pid, and validate for overflow. * include/libvirt/libvirt-qemu.h (virDomainQemuAttach): Tweak name for syntax check. * src/vmware/vmware_conf.c (vmwareExtractPid): Likewise. * src/driver.h (virDrvDomainQemuAttach): Likewise. * tools/virsh.c (cmdQemuAttach): Likewise. * src/remote/qemu_protocol.x (qemu_domain_attach_args): Likewise. * src/qemu_protocol-structs (qemu_domain_attach_args): Likewise. * src/util/cgroup.c (virCgroupPidCode, virCgroupKillInternal): Likewise. * src/qemu/qemu_command.c(qemuParseProcFileStrings): Likewise. (qemuParseCommandLinePid): Use pid_t for pid. * daemon/libvirtd.c (daemonForkIntoBackground): Likewise. * src/conf/domain_conf.h (_virDomainObj): Likewise. * src/probes.d (rpc_socket_new): Likewise. * src/qemu/qemu_command.h (qemuParseCommandLinePid): Likewise. * src/qemu/qemu_driver.c (qemudGetProcessInfo, qemuDomainAttach): Likewise. * src/qemu/qemu_process.c (qemuProcessAttach): Likewise. * src/qemu/qemu_process.h (qemuProcessAttach): Likewise. * src/uml/uml_driver.c (umlGetProcessInfo): Likewise. * src/util/virnetdev.h (virNetDevSetNamespace): Likewise. * src/util/virnetdev.c (virNetDevSetNamespace): Likewise. * tests/testutils.c (virtTestCaptureProgramOutput): Likewise. * src/conf/storage_conf.h (_virStoragePerms): Use mode_t, uid_t, and gid_t rather than int. * src/security/security_dac.c (virSecurityDACSetOwnership): Likewise. * src/conf/storage_conf.c (virStorageDefParsePerms): Avoid compiler warning.
186 lines
6.1 KiB
C
186 lines
6.1 KiB
C
/*
|
|
* libvirt-qemu.c: Interfaces for the libvirt library to handle qemu-specific
|
|
* APIs.
|
|
*
|
|
* Copyright (C) 2010-2012 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
* Author: Chris Lalancette <clalance@redhat.com>
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "virterror_internal.h"
|
|
#include "logging.h"
|
|
#include "datatypes.h"
|
|
#include "libvirt/libvirt-qemu.h"
|
|
|
|
#define virLibConnError(conn, error, info) \
|
|
virReportErrorHelper(VIR_FROM_NONE, error, NULL, __FUNCTION__, \
|
|
__LINE__, info)
|
|
|
|
#define virLibDomainError(domain, error, info) \
|
|
virReportErrorHelper(VIR_FROM_DOM, error, NULL, __FUNCTION__, \
|
|
__LINE__, info)
|
|
|
|
/**
|
|
* virDomainQemuMonitorCommand:
|
|
* @domain: a domain object
|
|
* @cmd: the qemu monitor command string
|
|
* @result: a string returned by @cmd
|
|
* @flags: bitwise-or of supported virDomainQemuMonitorCommandFlags
|
|
*
|
|
* This API is QEMU specific, so it will only work with hypervisor
|
|
* connections to the QEMU driver.
|
|
*
|
|
* Send an arbitrary monitor command @cmd to @domain through the
|
|
* qemu monitor. There are several requirements to safely and
|
|
* successfully use this API:
|
|
*
|
|
* - A @cmd that queries state without making any modifications is safe
|
|
* - A @cmd that alters state that is also tracked by libvirt is unsafe,
|
|
* and may cause libvirtd to crash
|
|
* - A @cmd that alters state not tracked by the current version of
|
|
* libvirt is possible as a means to test new qemu features before
|
|
* they have support in libvirt, but no guarantees are made to safety
|
|
*
|
|
* If VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP is set, the command is
|
|
* considered to be a human monitor command and libvirt will automatically
|
|
* convert it into QMP if needed. In that case the @result will also
|
|
* be converted back from QMP.
|
|
*
|
|
* If successful, @result will be filled with the string output of the
|
|
* @cmd, and the caller must free this string.
|
|
*
|
|
* Returns 0 in case of success, -1 in case of failure
|
|
*
|
|
*/
|
|
int
|
|
virDomainQemuMonitorCommand(virDomainPtr domain, const char *cmd,
|
|
char **result, unsigned int flags)
|
|
{
|
|
virConnectPtr conn;
|
|
|
|
VIR_DEBUG("domain=%p, cmd=%s, result=%p, flags=%x",
|
|
domain, cmd, result, flags);
|
|
|
|
virResetLastError();
|
|
|
|
if (!VIR_IS_CONNECTED_DOMAIN(domain)) {
|
|
virLibDomainError(NULL, VIR_ERR_INVALID_DOMAIN, __FUNCTION__);
|
|
virDispatchError(NULL);
|
|
return -1;
|
|
}
|
|
|
|
conn = domain->conn;
|
|
|
|
if (result == NULL) {
|
|
virLibDomainError(domain, VIR_ERR_INVALID_ARG, __FUNCTION__);
|
|
goto error;
|
|
}
|
|
|
|
if (conn->flags & VIR_CONNECT_RO) {
|
|
virLibDomainError(domain, VIR_ERR_OPERATION_DENIED, __FUNCTION__);
|
|
goto error;
|
|
}
|
|
|
|
if (conn->driver->qemuDomainMonitorCommand) {
|
|
int ret;
|
|
ret = conn->driver->qemuDomainMonitorCommand(domain, cmd, result,
|
|
flags);
|
|
if (ret < 0)
|
|
goto error;
|
|
return ret;
|
|
}
|
|
|
|
virLibConnError(conn, VIR_ERR_NO_SUPPORT, __FUNCTION__);
|
|
|
|
error:
|
|
virDispatchError(conn);
|
|
return -1;
|
|
}
|
|
|
|
/**
|
|
* virDomainQemuAttach:
|
|
* @conn: pointer to a hypervisor connection
|
|
* @pid_value: the UNIX process ID of the external QEMU process
|
|
* @flags: optional flags, currently unused
|
|
*
|
|
* This API is QEMU specific, so it will only work with hypervisor
|
|
* connections to the QEMU driver.
|
|
*
|
|
* This API will attach to an externally launched QEMU process
|
|
* identified by @pid. There are several requirements to successfully
|
|
* attach to an external QEMU process:
|
|
*
|
|
* - It must have been started with a monitor socket using the UNIX
|
|
* domain socket protocol.
|
|
* - No device hotplug/unplug, or other configuration changes can
|
|
* have been made via the monitor since it started.
|
|
* - The '-name' and '-uuid' arguments should have been set (not
|
|
* mandatory, but strongly recommended)
|
|
*
|
|
* To date, the only platforms we know of where pid_t is larger than
|
|
* unsigned int (64-bit Windows) also lack UNIX sockets, so the choice
|
|
* of @pid_value as an unsigned int should not present any difficulties.
|
|
*
|
|
* If successful, then the guest will appear in the list of running
|
|
* domains for this connection, and other APIs should operate
|
|
* normally (provided the above requirements were honored).
|
|
*
|
|
* Returns a new domain object on success, NULL otherwise
|
|
*/
|
|
virDomainPtr
|
|
virDomainQemuAttach(virConnectPtr conn,
|
|
unsigned int pid_value,
|
|
unsigned int flags)
|
|
{
|
|
pid_t pid = pid_value;
|
|
VIR_DEBUG("conn=%p, pid=%u, flags=%x", conn, pid_value, flags);
|
|
|
|
virResetLastError();
|
|
|
|
if (!VIR_IS_CONNECT(conn)) {
|
|
virLibConnError(NULL, VIR_ERR_INVALID_CONN, __FUNCTION__);
|
|
virDispatchError(NULL);
|
|
return NULL;
|
|
}
|
|
|
|
if (pid != pid_value || pid <= 1) {
|
|
virLibDomainError(domain, VIR_ERR_INVALID_ARG, __FUNCTION__);
|
|
goto error;
|
|
}
|
|
|
|
if (conn->flags & VIR_CONNECT_RO) {
|
|
virLibDomainError(domain, VIR_ERR_OPERATION_DENIED, __FUNCTION__);
|
|
goto error;
|
|
}
|
|
|
|
if (conn->driver->qemuDomainAttach) {
|
|
virDomainPtr ret;
|
|
ret = conn->driver->qemuDomainAttach(conn, pid_value, flags);
|
|
if (!ret)
|
|
goto error;
|
|
return ret;
|
|
}
|
|
|
|
virLibConnError(conn, VIR_ERR_NO_SUPPORT, __FUNCTION__);
|
|
|
|
error:
|
|
virDispatchError(conn);
|
|
return NULL;
|
|
}
|