mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-24 14:45:24 +00:00
f04de501bc
Since bugs due to double-closed file descriptors are difficult to track down in a multi-threaded system, I am introducing the VIR_CLOSE(fd) macro to help avoid mistakes here. There are lots of places where close() is being used. In this patch I am only cleaning up usage of close() in src/conf where the problems were. I also dare to declare close() as being deprecated in libvirt code base (HACKING).
47 lines
1.5 KiB
C
47 lines
1.5 KiB
C
/*
|
|
* files.h: safer file handling
|
|
*
|
|
* Copyright (C) 2010 IBM Corporation
|
|
* Copyright (C) 2010 Stefan Berger
|
|
* Copyright (C) 2010 RedHat, Inc.
|
|
* Copyright (C) 2010 Eric Blake
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
*/
|
|
|
|
|
|
#ifndef __VIR_FILES_H_
|
|
# define __VIR_FILES_H_
|
|
|
|
# include <stdbool.h>
|
|
|
|
# include "internal.h"
|
|
# include "ignore-value.h"
|
|
|
|
|
|
/* Don't call this directly - use the macros below */
|
|
int virClose(int *fdptr, bool preserve_errno) ATTRIBUTE_RETURN_CHECK;
|
|
|
|
/* For use on normal paths; caller must check return value,
|
|
and failure sets errno per close(). */
|
|
# define VIR_CLOSE(FD) virClose(&(FD), false)
|
|
|
|
/* For use on cleanup paths; errno is unaffected by close,
|
|
and no return value to worry about. */
|
|
# define VIR_FORCE_CLOSE(FD) ignore_value(virClose(&(FD), true))
|
|
|
|
#endif /* __VIR_FILES_H */
|