mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-14 01:59:14 +00:00
68b2596f83
If qemuDomainSnapshotDiscard() fails for any reason (rare, but possible with an ill-timed ENOMEM or if qemuDomainSnapshotForEachQcow2() has problems talking to the qemu guest monitor), then an attempt to retry the snapshot deletion API will crash because we didn't undo the effects of virDomainSnapshotDropParent() temporarily rearranging the internal list structures, and the second attempt to drop parents will dereference NULL. Fix it by instead noting that there are only two callers to qemuDomainSnapshotDiscard(), and only one of the two callers wants the parent to be updated; thus we can move the call to virDomainSnapshotDropParent() into a code path that only gets executed on success. Signed-off-by: Eric Blake <eblake@redhat.com> ACKed-by: Michal Privoznik <mprivozn@redhat.com> |
||
|---|---|---|
| .. | ||
| EVENTHANDLERS.txt | ||
| libvirtd_qemu.aug | ||
| Makefile.inc.am | ||
| MIGRATION.txt | ||
| qemu_agent.c | ||
| qemu_agent.h | ||
| qemu_alias.c | ||
| qemu_alias.h | ||
| qemu_block.c | ||
| qemu_block.h | ||
| qemu_blockjob.c | ||
| qemu_blockjob.h | ||
| qemu_capabilities.c | ||
| qemu_capabilities.h | ||
| qemu_capspriv.h | ||
| qemu_cgroup.c | ||
| qemu_cgroup.h | ||
| qemu_command.c | ||
| qemu_command.h | ||
| qemu_conf.c | ||
| qemu_conf.h | ||
| qemu_domain_address.c | ||
| qemu_domain_address.h | ||
| qemu_domain.c | ||
| qemu_domain.h | ||
| qemu_driver.c | ||
| qemu_driver.h | ||
| qemu_extdevice.c | ||
| qemu_extdevice.h | ||
| qemu_hostdev.c | ||
| qemu_hostdev.h | ||
| qemu_hotplug.c | ||
| qemu_hotplug.h | ||
| qemu_hotplugpriv.h | ||
| qemu_interface.c | ||
| qemu_interface.h | ||
| qemu_migration_cookie.c | ||
| qemu_migration_cookie.h | ||
| qemu_migration_params.c | ||
| qemu_migration_params.h | ||
| qemu_migration_paramspriv.h | ||
| qemu_migration.c | ||
| qemu_migration.h | ||
| qemu_monitor_json.c | ||
| qemu_monitor_json.h | ||
| qemu_monitor_priv.h | ||
| qemu_monitor_text.c | ||
| qemu_monitor_text.h | ||
| qemu_monitor.c | ||
| qemu_monitor.h | ||
| qemu_parse_command.c | ||
| qemu_parse_command.h | ||
| qemu_process.c | ||
| qemu_process.h | ||
| qemu_processpriv.h | ||
| qemu_qapi.c | ||
| qemu_qapi.h | ||
| qemu_security.c | ||
| qemu_security.h | ||
| qemu_tpm.c | ||
| qemu_tpm.h | ||
| qemu.conf | ||
| test_libvirtd_qemu.aug.in | ||
| THREADS.txt | ||