mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-07 18:35:46 +00:00
b63c7a0b39
Building with clang 3.8 triggers the following error:
CC virt_host_validate-virt-host-validate-qemu.o
virt-host-validate-qemu.c:36:11: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
char *kvmhint = _("Check that CPU and firmware supports virtualization "
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
virt-host-validate-qemu.c:46:17: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
kvmhint = _("Check that the 'kvm-intel' or 'kvm-amd' modules are "
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
Fix by using 'const' for kvmhint declaration.
134 lines
4.7 KiB
C
134 lines
4.7 KiB
C
/*
|
|
* virt-host-validate-qemu.c: Sanity check a QEMU hypervisor host
|
|
*
|
|
* Copyright (C) 2012 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#include <config.h>
|
|
#include <unistd.h>
|
|
|
|
#include "virt-host-validate-qemu.h"
|
|
#include "virt-host-validate-common.h"
|
|
#include "virarch.h"
|
|
#include "virbitmap.h"
|
|
|
|
int virHostValidateQEMU(void)
|
|
{
|
|
virBitmapPtr flags;
|
|
int ret = 0;
|
|
bool hasHwVirt = false;
|
|
bool hasVirtFlag = false;
|
|
const char *kvmhint = _("Check that CPU and firmware supports virtualization "
|
|
"and kvm module is loaded");
|
|
|
|
if (!(flags = virHostValidateGetCPUFlags()))
|
|
return -1;
|
|
|
|
switch (virArchFromHost()) {
|
|
case VIR_ARCH_I686:
|
|
case VIR_ARCH_X86_64:
|
|
hasVirtFlag = true;
|
|
kvmhint = _("Check that the 'kvm-intel' or 'kvm-amd' modules are "
|
|
"loaded & the BIOS has enabled virtualization");
|
|
if (virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SVM) ||
|
|
virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_VMX))
|
|
hasHwVirt = true;
|
|
break;
|
|
case VIR_ARCH_S390:
|
|
case VIR_ARCH_S390X:
|
|
hasVirtFlag = true;
|
|
if (virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SIE))
|
|
hasHwVirt = true;
|
|
break;
|
|
default:
|
|
hasHwVirt = false;
|
|
}
|
|
|
|
if (hasVirtFlag) {
|
|
virHostMsgCheck("QEMU", "%s", _("for hardware virtualization"));
|
|
if (hasHwVirt) {
|
|
virHostMsgPass();
|
|
} else {
|
|
virHostMsgFail(VIR_HOST_VALIDATE_FAIL,
|
|
_("Only emulated CPUs are available, performance will be significantly limited"));
|
|
ret = -1;
|
|
}
|
|
}
|
|
|
|
if (hasHwVirt || !hasVirtFlag) {
|
|
if (virHostValidateDeviceExists("QEMU", "/dev/kvm",
|
|
VIR_HOST_VALIDATE_FAIL,
|
|
kvmhint) <0)
|
|
ret = -1;
|
|
else if (virHostValidateDeviceAccessible("QEMU", "/dev/kvm",
|
|
VIR_HOST_VALIDATE_FAIL,
|
|
_("Check /dev/kvm is world writable or you are in "
|
|
"a group that is allowed to access it")) < 0)
|
|
ret = -1;
|
|
}
|
|
|
|
virBitmapFree(flags);
|
|
|
|
if (virHostValidateDeviceExists("QEMU", "/dev/vhost-net",
|
|
VIR_HOST_VALIDATE_WARN,
|
|
_("Load the 'vhost_net' module to improve performance "
|
|
"of virtio networking")) < 0)
|
|
ret = -1;
|
|
|
|
if (virHostValidateDeviceExists("QEMU", "/dev/net/tun",
|
|
VIR_HOST_VALIDATE_FAIL,
|
|
_("Load the 'tun' module to enable networking for QEMU guests")) < 0)
|
|
ret = -1;
|
|
|
|
if (virHostValidateCGroupController("QEMU", "memory",
|
|
VIR_HOST_VALIDATE_WARN,
|
|
"MEMCG") < 0)
|
|
ret = -1;
|
|
|
|
if (virHostValidateCGroupController("QEMU", "cpu",
|
|
VIR_HOST_VALIDATE_WARN,
|
|
"CGROUP_CPU") < 0)
|
|
ret = -1;
|
|
|
|
if (virHostValidateCGroupController("QEMU", "cpuacct",
|
|
VIR_HOST_VALIDATE_WARN,
|
|
"CGROUP_CPUACCT") < 0)
|
|
ret = -1;
|
|
|
|
if (virHostValidateCGroupController("QEMU", "cpuset",
|
|
VIR_HOST_VALIDATE_WARN,
|
|
"CPUSETS") < 0)
|
|
ret = -1;
|
|
|
|
if (virHostValidateCGroupController("QEMU", "devices",
|
|
VIR_HOST_VALIDATE_WARN,
|
|
"CGROUP_DEVICES") < 0)
|
|
ret = -1;
|
|
|
|
if (virHostValidateCGroupController("QEMU", "blkio",
|
|
VIR_HOST_VALIDATE_WARN,
|
|
"BLK_CGROUP") < 0)
|
|
ret = -1;
|
|
|
|
if (virHostValidateIOMMU("QEMU",
|
|
VIR_HOST_VALIDATE_WARN) < 0)
|
|
ret = -1;
|
|
|
|
return ret;
|
|
}
|