Laine Stump 9658e70f7d conf/openvz: eliminate incorrect/undocumented use of <source dev='blah'/> ... When support for <interface type='ethernet'> was added in commit 9a4b705f back in 2010, it erroneously looked at <source dev='blah'/> for a user-specified guest-side interface name. This was never documented though. (that attribute already existed at the time in the data.ethernet union member of virDomainNetDef, but apparently had no practical use - it was only used as a storage place for a NetDef's bridge name during qemuDomainXMLToNative(), but even then that was never used for anything). When support for similar guest-side device naming was added to the lxc driver several years later, it was put in a new subelement <guest dev='blah'/>. In the intervening years, since there was no validation that ethernet.dev was NULL in the other drivers that didn't actually use it, innocent souls who were adding other features assuming they needed to account for non-NULL ethernet.dev when really they didn't, so little bits of the usual pointless cargo-cult code showed up. This patch not only switches the openvz driver to use the documented <guest dev='blah'/> notation for naming the guest-side device (just in case anyone is still using the openvz driver), and logs an error if anyone tries to set <source dev='blah'/> for a type='ethernet' interface, it also removes the cargo-cult uses of ethernet.dev and <source dev='blah'/>, and eliminates if from the RNG and from virDomainNetDef. NB: I decided on this course of action after mentioning the inconsistency here: https://www.redhat.com/archives/libvir-list/2016-May/msg02038.html and getting encouragement do eliminate it in a later IRC discussion with danpb.		2016-06-26 19:33:08 -04:00
..
xml2sexpr-boot-grub.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-boot-grub.xml
xml2sexpr-bridge-ipaddr.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-bridge-ipaddr.xml
xml2sexpr-curmem.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-curmem.xml
xml2sexpr-disk-block-shareable.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-disk-block-shareable.xml
xml2sexpr-disk-block.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-disk-block.xml
xml2sexpr-disk-drv-blkback.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-disk-drv-blkback.xml
xml2sexpr-disk-drv-blktap2-raw.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-disk-drv-blktap2-raw.xml
xml2sexpr-disk-drv-blktap2.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-disk-drv-blktap2.xml
xml2sexpr-disk-drv-blktap-qcow.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-disk-drv-blktap-qcow.xml
xml2sexpr-disk-drv-blktap-raw.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-disk-drv-blktap-raw.xml
xml2sexpr-disk-drv-blktap.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-disk-drv-blktap.xml
xml2sexpr-disk-drv-loop.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-disk-drv-loop.xml
xml2sexpr-disk-file.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-disk-file.xml
xml2sexpr-escape.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-escape.xml
xml2sexpr-fv-force-hpet.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-force-hpet.xml
xml2sexpr-fv-force-nohpet.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-force-nohpet.xml
xml2sexpr-fv-kernel.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-kernel.xml
xml2sexpr-fv-localtime.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-localtime.xml
xml2sexpr-fv-net-netfront.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-net-netfront.xml
xml2sexpr-fv-net-rate.sexpr	xenconfig: support vif bandwidth in sexpr parser and formatter	2016-01-08 18:56:00 -07:00
xml2sexpr-fv-net-rate.xml	xenconfig: support vif bandwidth in sexpr parser and formatter	2016-01-08 18:56:00 -07:00
xml2sexpr-fv-parallel-tcp.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-parallel-tcp.xml
xml2sexpr-fv-serial-dev-2-ports.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-dev-2-ports.xml
xml2sexpr-fv-serial-dev-2nd-port.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-dev-2nd-port.xml
xml2sexpr-fv-serial-file.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-file.xml
xml2sexpr-fv-serial-null.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-null.xml
xml2sexpr-fv-serial-pipe.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-pipe.xml
xml2sexpr-fv-serial-pty.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-pty.xml
xml2sexpr-fv-serial-stdio.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-stdio.xml
xml2sexpr-fv-serial-tcp-telnet.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-tcp-telnet.xml
xml2sexpr-fv-serial-tcp.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-tcp.xml
xml2sexpr-fv-serial-udp.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-udp.xml
xml2sexpr-fv-serial-unix.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-serial-unix.xml
xml2sexpr-fv-sound.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-sound.xml
xml2sexpr-fv-usbmouse.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-usbmouse.xml
xml2sexpr-fv-usbtablet.sexpr
xml2sexpr-fv-usbtablet.xml
xml2sexpr-fv-utc.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-utc.xml
xml2sexpr-fv-v2.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-vncunused.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv-vncunused.xml
xml2sexpr-fv.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-fv.xml
xml2sexpr-net-bridged.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-net-bridged.xml
xml2sexpr-net-e1000.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-net-e1000.xml
xml2sexpr-net-routed.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-net-routed.xml	conf/openvz: eliminate incorrect/undocumented use of <source dev='blah'/>	2016-06-26 19:33:08 -04:00
xml2sexpr-no-source-cdrom.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-no-source-cdrom.xml
xml2sexpr-pci-devs.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-pci-devs.xml
xml2sexpr-pv-bootloader-cmdline.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-pv-bootloader-cmdline.xml
xml2sexpr-pv-bootloader.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-pv-bootloader.xml
xml2sexpr-pv-localtime.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-pv-localtime.xml
xml2sexpr-pv-vcpus.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-pv-vcpus.xml
xml2sexpr-pv-vfb-new-auto.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-pv-vfb-new-auto.xml
xml2sexpr-pv-vfb-new.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-pv-vfb-new.xml
xml2sexpr-pv.sexpr	Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests	2015-12-17 21:22:34 -07:00
xml2sexpr-pv.xml