mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-09 14:35:25 +00:00
6bd52b9caf
The virConnectPtr is passed around loads of nwfilter code in
order to provide it as a parameter to the callback registered
by the virt drivers. None of the virt drivers use this param
though, so it serves no purpose.
Avoiding the need to pass a virConnectPtr means that the
nwfilterStateReload method no longer needs to open a bogus
QEMU driver connection. This addresses a race condition that
can lead to a crash on startup.
The nwfilter driver starts before the QEMU driver and registers
some callbacks with DBus to detect firewalld reload. If the
firewalld reload happens while the QEMU driver is still starting
up though, the nwfilterStateReload method will open a connection
to the partially initialized QEMU driver and cause a crash.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit
|
||
---|---|---|
.. | ||
access | ||
conf | ||
cpu | ||
esx | ||
hyperv | ||
interface | ||
libxl | ||
locking | ||
lxc | ||
network | ||
node_device | ||
nwfilter | ||
openvz | ||
parallels | ||
phyp | ||
qemu | ||
remote | ||
rpc | ||
secret | ||
security | ||
storage | ||
test | ||
uml | ||
util | ||
vbox | ||
vmware | ||
vmx | ||
xen | ||
xenapi | ||
xenxs | ||
check-aclrules.pl | ||
check-driverimpls.pl | ||
check-drivername.pl | ||
check-symfile.pl | ||
check-symsorting.pl | ||
datatypes.c | ||
datatypes.h | ||
driver.c | ||
driver.h | ||
dtrace2systemtap.pl | ||
fdstream.c | ||
fdstream.h | ||
gnutls_1_0_compat.h | ||
internal.h | ||
libvirt_atomic.syms | ||
libvirt_daemon.syms | ||
libvirt_driver_modules.syms | ||
libvirt_esx.syms | ||
libvirt_gnutls.syms | ||
libvirt_internal.h | ||
libvirt_libssh2.syms | ||
libvirt_linux.syms | ||
libvirt_lxc.syms | ||
libvirt_openvz.syms | ||
libvirt_private.syms | ||
libvirt_probes.d | ||
libvirt_public.syms | ||
libvirt_qemu_probes.d | ||
libvirt_qemu.syms | ||
libvirt_sasl.syms | ||
libvirt_vmx.syms | ||
libvirt_xenxs.syms | ||
libvirt-lxc.c | ||
libvirt-qemu.c | ||
libvirt.c | ||
libvirt.conf | ||
lxc_protocol-structs | ||
Makefile.am | ||
nodeinfo.c | ||
nodeinfo.h | ||
qemu_protocol-structs | ||
README | ||
remote_protocol-structs | ||
virkeepaliveprotocol-structs | ||
virnetprotocol-structs |
libvirt library code README =========================== The directory provides the bulk of the libvirt codebase. Everything except for the libvirtd daemon and client tools. The build uses a large number of libtool convenience libraries - one for each child directory, and then links them together for the final libvirt.so, although some bits get linked directly to libvirtd daemon instead. The files directly in this directory are supporting the public API entry points & data structures. There are two core shared modules to be aware of: * util/ - a collection of shared APIs that can be used by any code. This directory is always in the include path for all things built * conf/ - APIs for parsing / manipulating all the official XML files used by the public API. This directory is only in the include path for driver implementation modules * vmx/ - VMware VMX config handling (used by esx/ and vmware/) Then there are the hypervisor implementations: * esx/ - VMware ESX and GSX support using vSphere API over SOAP * hyperv/ - Microsoft Hyper-V support using WinRM * lxc/ - Linux Native Containers * openvz/ - OpenVZ containers using cli tools * phyp/ - IBM Power Hypervisor using CLI tools over SSH * qemu/ - QEMU / KVM using qemu CLI/monitor * remote/ - Generic libvirt native RPC client * test/ - A "mock" driver for testing * uml/ - User Mode Linux * vbox/ - Virtual Box using native API * vmware/ - VMware Workstation and Player using the vmrun tool * xen/ - Xen using hypercalls, XenD SEXPR & XenStore * xenapi/ - Xen using libxenserver Finally some secondary drivers that are shared for several HVs. Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers. The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all implement the secondary drivers directly * cpu/ - CPU feature management * interface/ - Host network interface management * network/ - Virtual NAT networking * nwfilter/ - Network traffic filtering rules * node_device/ - Host device enumeration * secret/ - Secret management * security/ - Mandatory access control drivers * storage/ - Storage management drivers Since both the hypervisor and secondary drivers can be built as dlopen()able modules, it is *FORBIDDEN* to have build dependencies between these directories. Drivers are only allowed to depend on the public API, and the internal APIs in the util/ and conf/ directories