mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-16 11:09:24 +00:00
152c165d34
The snapshot-create operation of running guests saves the live XML and uses it to replace the active and inactive domain in case of revert. So, the config XML is ignored by the snapshot process. This commit changes it and adds the config XML in the snapshot XML as the <inactiveDomain> entry. In case of offline guest, the behavior remains the same and the config XML is saved in the snapshot XML as <domain> entry. The behavior of older snapshots of running guests, that don't have the new <inactiveDomain>, remains the same too. The revert, in this case, overrides both active and inactive domain with the <domain> entry. So, the <inactiveDomain> in the snapshot XML is not required to snapshot work, but it's useful to preserve the config XML of running guests. Signed-off-by: Maxiwell S. Garcia <maxiwell@linux.ibm.com> Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com> Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
87 lines
2.1 KiB
C
87 lines
2.1 KiB
C
/*
|
|
* moment_conf.c: domain snapshot/checkpoint base class
|
|
*
|
|
* Copyright (C) 2006-2019 Red Hat, Inc.
|
|
* Copyright (C) 2006-2008 Daniel P. Berrange
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include <sys/time.h>
|
|
|
|
#include "internal.h"
|
|
#include "moment_conf.h"
|
|
#include "domain_conf.h"
|
|
#include "virlog.h"
|
|
#include "viralloc.h"
|
|
#include "virstring.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_DOMAIN
|
|
|
|
VIR_LOG_INIT("conf.moment_conf");
|
|
|
|
static virClassPtr virDomainMomentDefClass;
|
|
static void virDomainMomentDefDispose(void *obj);
|
|
|
|
static int
|
|
virDomainMomentOnceInit(void)
|
|
{
|
|
if (!VIR_CLASS_NEW(virDomainMomentDef, virClassForObject()))
|
|
return -1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
VIR_ONCE_GLOBAL_INIT(virDomainMoment);
|
|
|
|
virClassPtr
|
|
virClassForDomainMomentDef(void)
|
|
{
|
|
if (virDomainMomentInitialize() < 0)
|
|
return NULL;
|
|
|
|
return virDomainMomentDefClass;
|
|
}
|
|
|
|
static void
|
|
virDomainMomentDefDispose(void *obj)
|
|
{
|
|
virDomainMomentDefPtr def = obj;
|
|
|
|
VIR_FREE(def->name);
|
|
VIR_FREE(def->description);
|
|
VIR_FREE(def->parent_name);
|
|
virDomainDefFree(def->dom);
|
|
virDomainDefFree(def->inactiveDom);
|
|
}
|
|
|
|
/* Provide defaults for creation time and moment name after parsing XML */
|
|
int
|
|
virDomainMomentDefPostParse(virDomainMomentDefPtr def)
|
|
{
|
|
struct timeval tv;
|
|
|
|
gettimeofday(&tv, NULL);
|
|
|
|
if (!def->name &&
|
|
virAsprintf(&def->name, "%lld", (long long)tv.tv_sec) < 0)
|
|
return -1;
|
|
|
|
def->creationTime = tv.tv_sec;
|
|
return 0;
|
|
}
|