mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-06 21:15:22 +00:00
45d6729f98
CVE-2012-3445, https://bugzilla.redhat.com/show_bug.cgi?id=844745
Daemon uses the following pattern when dispatching APIs with typed
parameters:
VIR_ALLOC_N(params, nparams);
virDomain*(dom, params, &nparams, flags);
virTypedParameterArrayClear(params, nparams);
In case nparams was originally set to 0, virDomain* API would fill it
with the number of typed parameters it can provide and we would use this
number (rather than zero) to clear params. Because VIR_ALLOC* returns
non-NULL pointer even if size is 0, the code would end up walking
through random memory. If we were lucky enough and the memory contained
7 (VIR_TYPED_PARAM_STRING) at the right place, we would try to free a
random pointer and crash.
Let's make sure params stays NULL when nparams is 0.
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| libvirtd.aug | ||
| libvirtd.c | ||
| libvirtd.conf | ||
| libvirtd.h | ||
| libvirtd.init.in | ||
| libvirtd.logrotate.in | ||
| libvirtd.lxc.logrotate.in | ||
| libvirtd.pod.in | ||
| libvirtd.policy-0 | ||
| libvirtd.policy-1 | ||
| libvirtd.qemu.logrotate.in | ||
| libvirtd.sasl | ||
| libvirtd.service.in | ||
| libvirtd.sysconf | ||
| libvirtd.sysctl | ||
| libvirtd.uml.logrotate.in | ||
| libvirtd.upstart | ||
| Makefile.am | ||
| remote.c | ||
| remote.h | ||
| stream.c | ||
| stream.h | ||
| test_libvirtd.aug | ||
| THREADS.txt | ||