libvirt/src
Maxim Nestratov 2f5e24ba00 nwfilter: fix lock order deadlock
Below is backtraces of two deadlocked threads:

thread #1:
 virDomainConfVMNWFilterTeardown
   virNWFilterTeardownFilter
       lock updateMutex <------------
       _virNWFilterTeardownFilter
            try to lock interface <----------

thread #2:
 learnIPAddressThread
    lock interface <-------
    virNWFilterInstantiateFilterLate
        try to lock updateMutex <----------

The problem is fixed by unlocking interface before calling
virNWFilterInstantiateFilterLate to avoid updateMutex and interface ordering
deadlocks. Otherwise we are going to instantiate the filter while holding
interface lock, which will try to lock updateMutex, and if some other thread
instantiating a filter in parallel is holding updateMutex and is trying to
lock interface, both will deadlock.
Also it is safe to unlock interface before virNWFilterInstantiateFilterLate
because learnIPAddressThread stopped capturing packets and applied necessary
rules on the interface, while instantiating a new filter doesn't require a
locked interface.

Signed-off-by: Maxim Nestratov <mnestratov@virtuozzo.com>
2016-05-24 15:24:37 +03:00
..
access
admin admin: Introduce virAdmServerSetClientLimits 2016-05-19 12:31:53 +02:00
bhyve bhyve: Replace VIR_ERROR with standard vir*Error in state driver init 2016-05-23 15:42:46 -04:00
conf qemu: auto-assign addresses when <address type='pci'/> is specified 2016-05-20 13:54:26 -04:00
cpu cpu: Fix documentation of cpuGetModels 2016-05-20 09:18:56 +02:00
esx esx: Avoid using vSphere SessionIsActive function 2016-02-18 19:28:35 +01:00
hyperv conf: add caps to virDomainDefFormat* 2016-02-04 12:38:26 +00:00
interface interface: let netcf pre-filter for active vs. inactive 2015-10-02 11:16:11 -04:00
libxl libxl: Replace VIR_ERROR with standard vir*Error in state driver init 2016-05-23 15:42:46 -04:00
locking More usage of virGetLastErrorMessage 2016-05-19 15:17:03 -04:00
logging More usage of virGetLastErrorMessage 2016-05-19 15:17:03 -04:00
lxc More usage of virGetLastErrorMessage 2016-05-19 15:17:03 -04:00
network network: log error when <bandwidth> is requested for hostdev interfaces 2016-05-13 10:02:20 -04:00
node_device Use virGetLastErrorMessage to avoid Coverity message 2016-05-09 19:33:56 -04:00
nwfilter nwfilter: fix lock order deadlock 2016-05-24 15:24:37 +03:00
openvz conf: domain: reject name containing '/' 2016-05-02 10:06:04 -04:00
phyp conf: domain: reject name containing '/' 2016-05-02 10:06:04 -04:00
qemu qemu: simplify addition of USB controller in qemuParseCommandLine 2016-05-23 15:26:57 -04:00
remote virnetsocket: Provide socket address format in a more standard form 2016-05-03 15:52:50 +02:00
rpc More usage of virGetLastErrorMessage 2016-05-19 15:17:03 -04:00
secret secret: Alter virSecretGetSecretString 2016-05-16 12:58:48 +02:00
security virt-aa-helper: remove replace_string and use virStringReplace instead 2016-05-13 17:42:57 +02:00
storage storage: Replace VIR_ERROR with standard vir*Error in state driver init 2016-05-23 15:42:46 -04:00
test conf: Extract code filling data for virDomainGetVcpuPinInfo 2016-03-09 10:09:16 +01:00
uml More usage of virGetLastErrorMessage 2016-05-19 15:17:03 -04:00
util util: fix build without GNUTLS 2016-05-22 08:53:58 +03:00
vbox graphics: rename gListen to glisten 2016-05-20 10:05:56 +02:00
vmware conf: refactor checking for unsupported memory devices 2016-03-09 10:09:16 +01:00
vmx graphics: rename gListen to glisten 2016-05-20 10:05:56 +02:00
vz vz: add error code for case if vm is already stopped 2016-05-23 20:06:17 +03:00
xen extract XEN_CONFIG_FORMAT_XM/XL to xen_common.h 2016-05-17 14:09:11 -06:00
xenapi headers: Remove unnecessary keyword extern from function declaration 2016-05-11 09:06:32 +02:00
xenconfig graphics: rename gListen to glisten 2016-05-20 10:05:56 +02:00
admin_protocol-structs admin: Introduce virAdmServerSetClientLimits 2016-05-19 12:31:53 +02:00
check-aclperms.pl
check-aclrules.pl
check-driverimpls.pl
check-drivername.pl
check-symfile.pl
check-symsorting.pl
datatypes.c admin: Introduce virAdmClient client-side object 2016-05-02 22:26:17 +02:00
datatypes.h admin: Introduce virAdmClient client-side object 2016-05-02 22:26:17 +02:00
driver-hypervisor.h virDomain{Get,Set}PerfEvents: Add @flags argument 2016-03-31 07:24:36 +02:00
driver-interface.h
driver-network.h
driver-nodedev.h
driver-nwfilter.h
driver-secret.h
driver-state.h
driver-storage.h
driver-stream.h
driver.c driver: log missing modules as INFO, not WARN 2016-03-17 16:50:05 -04:00
driver.h
dtrace2systemtap.pl
fdstream.c fdstream: don't raise error on SIGPIPE if abort requested 2016-05-02 10:13:05 -04:00
fdstream.h
gnutls_1_0_compat.h
internal.h build: add GCC 6.0 -Wlogical-op workaround 2016-04-11 12:09:14 +02:00
libvirt_admin_private.syms admin: Introduce virAdmServerSetClientLimits 2016-05-19 12:31:53 +02:00
libvirt_admin_public.syms admin: Introduce virAdmServerSetClientLimits 2016-05-19 12:31:53 +02:00
libvirt_atomic.syms
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_gnutls.syms
libvirt_internal.h daemon: add connection close rpc 2016-03-01 14:18:16 +00:00
libvirt_libssh2.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms util: Introduce virCryptoGenerateRandom 2016-05-20 11:09:05 -04:00
libvirt_probes.d
libvirt_public.syms perf: add new public APIs for perf event 2016-03-29 13:13:05 +01:00
libvirt_qemu_probes.d
libvirt_qemu.syms
libvirt_remote.syms virnetserver: Introduce server's client-related limits getters 2016-05-19 11:11:13 +02:00
libvirt_sasl.syms virneserverclient: Introduce virNetServerClientHasSASLSession 2016-05-03 15:52:50 +02:00
libvirt_vmware.syms
libvirt_vmx.syms
libvirt_xenconfig.syms xenconfig: support vif bandwidth in sexpr parser and formatter 2016-01-08 18:56:00 -07:00
libvirt_xenxlconfig.syms
libvirt-admin.c admin: Introduce virAdmServerSetClientLimits 2016-05-19 12:31:53 +02:00
libvirt-admin.conf admin: Introduce libvirt-admin.conf 2015-11-30 09:36:19 +01:00
libvirt-domain-snapshot.c
libvirt-domain.c perf: add support to perf event for MBM 2016-05-19 15:57:57 +02:00
libvirt-host.c close callback: move it to driver 2016-03-01 14:17:38 +00:00
libvirt-interface.c
libvirt-lxc.c
libvirt-lxc.pc.in
libvirt-network.c
libvirt-nodedev.c
libvirt-nwfilter.c
libvirt-qemu.c
libvirt-qemu.pc.in
libvirt-secret.c libvirt-secret: Fix typo 2015-10-15 11:31:27 +02:00
libvirt-storage.c virStorageVolWipe: Document that wiping journaled FS is useless 2015-12-24 18:02:58 +01:00
libvirt-stream.c virStream{Recv,Send}All: Increase client buffer 2016-05-02 07:56:38 +02:00
libvirt.c More usage of virGetLastErrorMessage 2016-05-19 15:17:03 -04:00
libvirt.conf admin: Distribute libvirt-admin.conf 2015-12-01 11:44:48 +01:00
libvirt.pc.in
lock_protocol-structs Fix make check with gcc version 5 2016-01-18 15:19:21 +01:00
lxc_monitor_protocol-structs
lxc_protocol-structs
Makefile.am makefile: fix build on systems where gnutls is not in /usr/include 2016-05-24 13:30:01 +02:00
nodeinfo.c sysconf: Include unistd.h 2015-12-24 18:03:50 +01:00
nodeinfo.h
nodeinfopriv.h
qemu_protocol-structs
README
remote_protocol-structs Add VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED event 2016-04-13 13:26:29 +02:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories