mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 22:25:25 +00:00
39d963d1c0
Coverity reported a memleak in the test added in 7efd5fd1b0. In case
the code will be broken and the code will actually parse a faulty bitmap
the resulting pointer would be leaked. Free it although that shouldn't
ever happen.
528 lines
11 KiB
C
528 lines
11 KiB
C
/*
|
|
* virbitmaptest.c: Test the bitmap code
|
|
*
|
|
* Copyright (C) 2013 Red Hat, Inc.
|
|
* Copyright (C) 2012 Fujitsu.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "testutils.h"
|
|
|
|
#include "virbitmap.h"
|
|
|
|
static int
|
|
test1(const void *data ATTRIBUTE_UNUSED)
|
|
{
|
|
virBitmapPtr bitmap;
|
|
int size;
|
|
int bit;
|
|
bool result;
|
|
int ret = -1;
|
|
|
|
size = 1024;
|
|
bit = 100;
|
|
if (!(bitmap = virBitmapNew(size)))
|
|
goto error;
|
|
|
|
if (virBitmapSetBit(bitmap, bit) < 0)
|
|
goto error;
|
|
|
|
if (virBitmapGetBit(bitmap, bit, &result) < 0)
|
|
goto error;
|
|
|
|
if (!result)
|
|
goto error;
|
|
|
|
if (virBitmapGetBit(bitmap, bit + 1, &result) < 0)
|
|
goto error;
|
|
|
|
if (result)
|
|
goto error;
|
|
|
|
ret = 0;
|
|
|
|
error:
|
|
virBitmapFree(bitmap);
|
|
return ret;
|
|
}
|
|
|
|
static int
|
|
testBit(virBitmapPtr bitmap,
|
|
unsigned int start,
|
|
unsigned int end,
|
|
bool expected)
|
|
{
|
|
size_t i;
|
|
bool result;
|
|
|
|
for (i = start; i <= end; i++) {
|
|
if (virBitmapGetBit(bitmap, i, &result) < 0)
|
|
return -1;
|
|
if (result == expected)
|
|
return 0;
|
|
}
|
|
|
|
return -1;
|
|
}
|
|
|
|
static int
|
|
test2(const void *data ATTRIBUTE_UNUSED)
|
|
{
|
|
const char *bitsString1 = "1-32,50,88-99,1021-1023";
|
|
char *bitsString2 = NULL;
|
|
virBitmapPtr bitmap = NULL;
|
|
int ret = -1;
|
|
int size = 1025;
|
|
|
|
if (virBitmapParse(bitsString1, 0, &bitmap, size) < 0)
|
|
goto error;
|
|
|
|
if (testBit(bitmap, 1, 32, true) < 0)
|
|
goto error;
|
|
if (testBit(bitmap, 50, 50, true) < 0)
|
|
goto error;
|
|
if (testBit(bitmap, 88, 99, true) < 0)
|
|
goto error;
|
|
if (testBit(bitmap, 1021, 1023, true) < 0)
|
|
goto error;
|
|
|
|
if (testBit(bitmap, 0, 0, false) < 0)
|
|
goto error;
|
|
if (testBit(bitmap, 33, 49, false) < 0)
|
|
goto error;
|
|
if (testBit(bitmap, 51, 87, false) < 0)
|
|
goto error;
|
|
if (testBit(bitmap, 100, 1020, false) < 0)
|
|
goto error;
|
|
|
|
if (virBitmapCountBits(bitmap) != 48)
|
|
goto error;
|
|
|
|
if (!(bitsString2 = virBitmapFormat(bitmap)))
|
|
goto error;
|
|
if (strcmp(bitsString1, bitsString2))
|
|
goto error;
|
|
|
|
virBitmapSetAll(bitmap);
|
|
if (testBit(bitmap, 0, size - 1, true) < 0)
|
|
goto error;
|
|
if (virBitmapCountBits(bitmap) != size)
|
|
goto error;
|
|
|
|
if (!virBitmapIsAllSet(bitmap))
|
|
goto error;
|
|
|
|
virBitmapClearAll(bitmap);
|
|
if (!virBitmapIsAllClear(bitmap))
|
|
goto error;
|
|
if (testBit(bitmap, 0, size - 1, false) < 0)
|
|
goto error;
|
|
if (virBitmapCountBits(bitmap) != 0)
|
|
goto error;
|
|
|
|
ret = 0;
|
|
|
|
error:
|
|
virBitmapFree(bitmap);
|
|
VIR_FREE(bitsString2);
|
|
return ret;
|
|
}
|
|
|
|
static int
|
|
test3(const void *data ATTRIBUTE_UNUSED)
|
|
{
|
|
virBitmapPtr bitmap = NULL;
|
|
int ret = -1;
|
|
int size = 5;
|
|
size_t i;
|
|
|
|
if ((bitmap = virBitmapNew(size)) == NULL)
|
|
goto error;
|
|
|
|
for (i = 0; i < size; i++)
|
|
ignore_value(virBitmapSetBit(bitmap, i));
|
|
|
|
if (!virBitmapIsAllSet(bitmap))
|
|
goto error;
|
|
|
|
virBitmapClearAll(bitmap);
|
|
if (!virBitmapIsAllClear(bitmap))
|
|
goto error;
|
|
ret = 0;
|
|
|
|
error:
|
|
virBitmapFree(bitmap);
|
|
return ret;
|
|
}
|
|
|
|
/* test for virBitmapNextSetBit, virBitmapNextClearBit */
|
|
static int
|
|
test4(const void *data ATTRIBUTE_UNUSED)
|
|
{
|
|
const char *bitsString = "0, 2-4, 6-10, 12, 14-18, 20, 22, 25";
|
|
int size = 40;
|
|
int bitsPos[] = {
|
|
0, 2, 3, 4, 6, 7, 8, 9, 10, 12,
|
|
14, 15, 16, 17, 18, 20, 22, 25
|
|
};
|
|
int bitsPosInv[] = {
|
|
1, 5, 11, 13, 19, 21, 23, 24, 26, 27,
|
|
28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39
|
|
};
|
|
virBitmapPtr bitmap = NULL;
|
|
ssize_t i, j;
|
|
|
|
if (ARRAY_CARDINALITY(bitsPos) + ARRAY_CARDINALITY(bitsPosInv) != size)
|
|
goto error;
|
|
|
|
/* 1. zero set */
|
|
|
|
bitmap = virBitmapNew(size);
|
|
if (!bitmap)
|
|
goto error;
|
|
|
|
if (virBitmapNextSetBit(bitmap, -1) != -1)
|
|
goto error;
|
|
|
|
for (i = 0; i < size; i++) {
|
|
if (virBitmapNextClearBit(bitmap, i - 1) != i)
|
|
goto error;
|
|
}
|
|
if (virBitmapNextClearBit(bitmap, i) != -1)
|
|
goto error;
|
|
|
|
if (!virBitmapIsAllClear(bitmap))
|
|
goto error;
|
|
|
|
virBitmapFree(bitmap);
|
|
bitmap = NULL;
|
|
|
|
/* 2. partial set */
|
|
|
|
if (virBitmapParse(bitsString, 0, &bitmap, size) < 0)
|
|
goto error;
|
|
if (!bitmap)
|
|
goto error;
|
|
|
|
j = 0;
|
|
i = -1;
|
|
|
|
while (j < ARRAY_CARDINALITY(bitsPos)) {
|
|
i = virBitmapNextSetBit(bitmap, i);
|
|
if (i != bitsPos[j++])
|
|
goto error;
|
|
}
|
|
|
|
if (virBitmapNextSetBit(bitmap, i) != -1)
|
|
goto error;
|
|
|
|
j = 0;
|
|
i = -1;
|
|
|
|
while (j < ARRAY_CARDINALITY(bitsPosInv)) {
|
|
i = virBitmapNextClearBit(bitmap, i);
|
|
if (i != bitsPosInv[j++])
|
|
goto error;
|
|
}
|
|
|
|
if (virBitmapNextClearBit(bitmap, i) != -1)
|
|
goto error;
|
|
|
|
/* 3. full set */
|
|
|
|
virBitmapSetAll(bitmap);
|
|
|
|
for (i = 0; i < size; i++) {
|
|
if (virBitmapNextSetBit(bitmap, i - 1) != i)
|
|
goto error;
|
|
}
|
|
if (virBitmapNextSetBit(bitmap, i) != -1)
|
|
goto error;
|
|
|
|
if (virBitmapNextClearBit(bitmap, -1) != -1)
|
|
goto error;
|
|
|
|
virBitmapFree(bitmap);
|
|
return 0;
|
|
|
|
error:
|
|
virBitmapFree(bitmap);
|
|
return -1;
|
|
}
|
|
|
|
/* test for virBitmapNewData/ToData */
|
|
static int
|
|
test5(const void *v ATTRIBUTE_UNUSED)
|
|
{
|
|
char data[] = {0x01, 0x02, 0x00, 0x00, 0x04};
|
|
unsigned char *data2 = NULL;
|
|
int len2;
|
|
int bits[] = {0, 9, 34};
|
|
virBitmapPtr bitmap;
|
|
size_t i;
|
|
ssize_t j;
|
|
int ret = -1;
|
|
|
|
bitmap = virBitmapNewData(data, sizeof(data));
|
|
if (!bitmap)
|
|
goto error;
|
|
|
|
i = 0;
|
|
j = -1;
|
|
while (i < sizeof(bits)/sizeof(int) &&
|
|
(j = virBitmapNextSetBit(bitmap, j)) >= 0) {
|
|
if (j != bits[i++])
|
|
goto error;
|
|
}
|
|
if (virBitmapNextSetBit(bitmap, j) > 0)
|
|
goto error;
|
|
|
|
ignore_value(virBitmapSetBit(bitmap, 2));
|
|
ignore_value(virBitmapSetBit(bitmap, 15));
|
|
|
|
if (virBitmapToData(bitmap, &data2, &len2) < 0)
|
|
goto error;
|
|
|
|
if (len2 != sizeof(data) ||
|
|
data2[0] != 0x05 ||
|
|
data2[1] != 0x82 ||
|
|
data2[2] != 0x00 ||
|
|
data2[3] != 0x00 ||
|
|
data2[4] != 0x04)
|
|
goto error;
|
|
|
|
ret = 0;
|
|
error:
|
|
virBitmapFree(bitmap);
|
|
VIR_FREE(data2);
|
|
return ret;
|
|
}
|
|
|
|
|
|
/* test for virBitmapFormat */
|
|
static int
|
|
test6(const void *v ATTRIBUTE_UNUSED)
|
|
{
|
|
virBitmapPtr bitmap = NULL;
|
|
char *str = NULL;
|
|
int size = 64;
|
|
int ret = -1;
|
|
|
|
bitmap = virBitmapNew(size);
|
|
if (!bitmap)
|
|
goto error;
|
|
|
|
str = virBitmapFormat(bitmap);
|
|
if (!str)
|
|
goto error;
|
|
|
|
if (!STREQ(str, ""))
|
|
goto error;
|
|
|
|
VIR_FREE(str);
|
|
|
|
ignore_value(virBitmapSetBit(bitmap, 0));
|
|
str = virBitmapFormat(bitmap);
|
|
if (!str)
|
|
goto error;
|
|
|
|
if (!STREQ(str, "0"))
|
|
goto error;
|
|
|
|
VIR_FREE(str);
|
|
|
|
ignore_value(virBitmapSetBit(bitmap, 4));
|
|
ignore_value(virBitmapSetBit(bitmap, 5));
|
|
str = virBitmapFormat(bitmap);
|
|
if (!str)
|
|
goto error;
|
|
|
|
if (!STREQ(str, "0,4-5"))
|
|
goto error;
|
|
|
|
VIR_FREE(str);
|
|
|
|
ignore_value(virBitmapSetBit(bitmap, 6));
|
|
str = virBitmapFormat(bitmap);
|
|
if (!str)
|
|
goto error;
|
|
|
|
if (!STREQ(str, "0,4-6"))
|
|
goto error;
|
|
|
|
VIR_FREE(str);
|
|
|
|
ignore_value(virBitmapSetBit(bitmap, 13));
|
|
ignore_value(virBitmapSetBit(bitmap, 14));
|
|
ignore_value(virBitmapSetBit(bitmap, 15));
|
|
ignore_value(virBitmapSetBit(bitmap, 16));
|
|
str = virBitmapFormat(bitmap);
|
|
if (!str)
|
|
goto error;
|
|
|
|
if (!STREQ(str, "0,4-6,13-16"))
|
|
goto error;
|
|
|
|
VIR_FREE(str);
|
|
|
|
ignore_value(virBitmapSetBit(bitmap, 62));
|
|
ignore_value(virBitmapSetBit(bitmap, 63));
|
|
str = virBitmapFormat(bitmap);
|
|
if (!str)
|
|
goto error;
|
|
|
|
if (!STREQ(str, "0,4-6,13-16,62-63"))
|
|
goto error;
|
|
|
|
|
|
ret = 0;
|
|
error:
|
|
virBitmapFree(bitmap);
|
|
VIR_FREE(str);
|
|
return ret;
|
|
}
|
|
|
|
static int
|
|
test7(const void *v ATTRIBUTE_UNUSED)
|
|
{
|
|
virBitmapPtr bitmap;
|
|
size_t i;
|
|
size_t maxBit[] = {
|
|
1, 8, 31, 32, 63, 64, 95, 96, 127, 128, 159, 160
|
|
};
|
|
size_t nmaxBit = 12;
|
|
|
|
for (i = 0; i < nmaxBit; i++) {
|
|
bitmap = virBitmapNew(maxBit[i]);
|
|
if (!bitmap)
|
|
goto error;
|
|
|
|
if (virBitmapIsAllSet(bitmap))
|
|
goto error;
|
|
|
|
ignore_value(virBitmapSetBit(bitmap, 1));
|
|
if (virBitmapIsAllSet(bitmap))
|
|
goto error;
|
|
|
|
virBitmapSetAll(bitmap);
|
|
if (!virBitmapIsAllSet(bitmap))
|
|
goto error;
|
|
|
|
virBitmapClearAll(bitmap);
|
|
if (!virBitmapIsAllClear(bitmap))
|
|
goto error;
|
|
|
|
virBitmapFree(bitmap);
|
|
}
|
|
|
|
return 0;
|
|
|
|
error:
|
|
virBitmapFree(bitmap);
|
|
return -1;
|
|
}
|
|
|
|
static int
|
|
test8(const void *v ATTRIBUTE_UNUSED)
|
|
{
|
|
virBitmapPtr bitmap = NULL;
|
|
char data[108] = {0x00,};
|
|
int ret = -1;
|
|
|
|
bitmap = virBitmapNewData(data, sizeof(data));
|
|
if (!bitmap)
|
|
goto cleanup;
|
|
|
|
if (!virBitmapIsAllClear(bitmap))
|
|
goto cleanup;
|
|
|
|
if (virBitmapSetBit(bitmap, 11) < 0)
|
|
goto cleanup;
|
|
|
|
if (virBitmapIsAllClear(bitmap))
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
cleanup:
|
|
virBitmapFree(bitmap);
|
|
return ret;
|
|
}
|
|
|
|
|
|
/* test out of bounds conditions on virBitmapParse */
|
|
static int
|
|
test9(const void *opaque ATTRIBUTE_UNUSED)
|
|
{
|
|
int ret = -1;
|
|
virBitmapPtr bitmap = NULL;
|
|
|
|
if (virBitmapParse("100000000", 0, &bitmap, 20) != -1)
|
|
goto cleanup;
|
|
|
|
if (bitmap)
|
|
goto cleanup;
|
|
|
|
if (virBitmapParse("1-1000000000", 0, &bitmap, 20) != -1)
|
|
goto cleanup;
|
|
|
|
if (bitmap)
|
|
goto cleanup;
|
|
|
|
if (virBitmapParse("1-10^10000000000", 0, &bitmap, 20) != -1)
|
|
goto cleanup;
|
|
|
|
if (bitmap)
|
|
goto cleanup;
|
|
|
|
ret = 0;
|
|
cleanup:
|
|
virBitmapFree(bitmap);
|
|
return ret;
|
|
|
|
}
|
|
|
|
static int
|
|
mymain(void)
|
|
{
|
|
int ret = 0;
|
|
|
|
if (virtTestRun("test1", 1, test1, NULL) < 0)
|
|
ret = -1;
|
|
if (virtTestRun("test2", 1, test2, NULL) < 0)
|
|
ret = -1;
|
|
if (virtTestRun("test3", 1, test3, NULL) < 0)
|
|
ret = -1;
|
|
if (virtTestRun("test4", 1, test4, NULL) < 0)
|
|
ret = -1;
|
|
if (virtTestRun("test5", 1, test5, NULL) < 0)
|
|
ret = -1;
|
|
if (virtTestRun("test6", 1, test6, NULL) < 0)
|
|
ret = -1;
|
|
if (virtTestRun("test7", 1, test7, NULL) < 0)
|
|
ret = -1;
|
|
if (virtTestRun("test8", 1, test8, NULL) < 0)
|
|
ret = -1;
|
|
if (virtTestRun("test9", 1, test9, NULL) < 0)
|
|
ret = -1;
|
|
|
|
return ret;
|
|
}
|
|
|
|
VIRT_TEST_MAIN(mymain)
|