libvirt/src/qemu
Michal Privoznik 752596b5dd qemuDomainChangeGraphics: Check listen address change by listen type
Currently, we have a bug when updating a graphics device. A graphics device can
have a listen address set. This address is either defined by user (in which case
it's type is VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS) or it can be inherited
from a network (in which case it's type is
VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK). However, in both cases we have a
listen address to process (e.g. during migration, as I've tried to fix in
7f15ebc7).
Later, when a user tries to update the graphics device (e.g. set a password),
we check if listen addresses match the original as qemu doesn't know how to
change listen address yet. Hence, users are required to not change the listen
address. The implementation then just dumps listen addresses and compare them.
Previously, while dumping the listen addresses, NULL was returned for NETWORK.
After my patch, this is no longer true, and we get a listen address for olddev
even if it is a type of NETWORK. So we have a real string on one side, the NULL
from user's XML on the other side and hence we think user wants to change the
listen address and we refuse it.

Therefore, we must take the type of listen address into account as well.
2013-06-20 19:41:53 +02:00
..
libvirtd_qemu.aug qemu: Add VNC WebSocket support 2013-05-15 09:48:05 +02:00
MIGRATION.txt
qemu_agent.c qemu_agent: Introduce helpers for agent based CPU hot(un)plug 2013-06-07 15:58:24 +02:00
qemu_agent.h qemu_agent: Introduce helpers for agent based CPU hot(un)plug 2013-06-07 15:58:24 +02:00
qemu_bridge_filter.c virutil: Move string related functions to virstring.c 2013-05-02 16:56:55 +02:00
qemu_bridge_filter.h Replace 'struct qemud_driver *' with virQEMUDriverPtr 2012-11-28 18:17:25 +00:00
qemu_capabilities.c qemu: set QEMU_CAPS_DEVICE_VIDEO_PRIMARY cap flag in QMP detection 2013-06-18 16:57:48 +08:00
qemu_capabilities.h qemu: change two-state int parameters to bool 2013-06-06 17:22:53 +02:00
qemu_cgroup.c qemu: Abstract code for the cpu controller setting into a helper 2013-06-05 19:25:48 +08:00
qemu_cgroup.h qemu: put usb cgroup setup in common function 2013-04-29 21:52:28 -04:00
qemu_command.c qemu: Report the offset from host UTC for RTC_CHANGE event 2013-06-07 14:45:08 +08:00
qemu_command.h qemu: Adapt qemuBuildInterfaceCommandLine to to multiqueue net 2013-05-22 17:24:27 +02:00
qemu_conf.c Adapt to VIR_STRDUP and VIR_STRNDUP in src/qemu/* 2013-05-23 09:56:38 +02:00
qemu_conf.h maint: don't use config.h in .h files 2013-06-05 05:53:25 -06:00
qemu_domain.c qemu: allow restore with non-migratable XML input 2013-06-13 16:58:30 +02:00
qemu_domain.h qemu: allow restore with non-migratable XML input 2013-06-13 16:58:30 +02:00
qemu_driver.c qemu: Resolve issue with GetScheduler APIs for non running domain 2013-06-19 15:01:48 -04:00
qemu_driver.h maint: fix up copyright notice inconsistencies 2012-09-20 16:30:55 -06:00
qemu_hostdev.c qemu: change two-state int parameters to bool 2013-06-06 17:22:53 +02:00
qemu_hostdev.h qemu: Introduce activeScsiHostdevs list for scsi host devices 2013-05-13 21:26:06 +08:00
qemu_hotplug.c qemuDomainChangeGraphics: Check listen address change by listen type 2013-06-20 19:41:53 +02:00
qemu_hotplug.h S390: Add hotplug support for s390 virtio devices 2013-03-13 18:13:09 -06:00
qemu_migration.c migration: Don't propagate VIR_MIGRATE_ABORT_ON_ERROR 2013-06-18 14:52:26 +02:00
qemu_migration.h migration: Make erroring out on I/O error controllable by flag 2013-06-18 14:52:26 +02:00
qemu_monitor_json.c qemu: Implement new QMP command for cpu hotplug 2013-06-07 16:19:20 +02:00
qemu_monitor_json.h qemu: Use bool instead of int in qemuMonitorSetCPU APIs 2013-06-07 15:57:03 +02:00
qemu_monitor_text.c qemu: Use bool instead of int in qemuMonitorSetCPU APIs 2013-06-07 15:57:03 +02:00
qemu_monitor_text.h qemu: Use bool instead of int in qemuMonitorSetCPU APIs 2013-06-07 15:57:03 +02:00
qemu_monitor.c qemu: Use bool instead of int in qemuMonitorSetCPU APIs 2013-06-07 15:57:03 +02:00
qemu_monitor.h qemu: Use bool instead of int in qemuMonitorSetCPU APIs 2013-06-07 15:57:03 +02:00
qemu_process.c qemu_migrate: Dispose listen address if set from config 2013-06-11 14:11:46 +02:00
qemu_process.h qemu: Move qemuSetUnprivSGIO into qemu_conf.c 2013-05-17 00:51:58 +08:00
qemu.conf qemu: Add VNC WebSocket support 2013-05-15 09:48:05 +02:00
test_libvirtd_qemu.aug.in qemu: Add VNC WebSocket support 2013-05-15 09:48:05 +02:00
THREADS.txt Remove qemuDriverLock from almost everywhere 2013-02-13 11:10:30 +00:00