mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-11-05 12:51:12 +00:00
31daccf5a5
https://bugzilla.redhat.com/show_bug.cgi?id=1569678 On some large systems (with ~400GB of RAM) it is possible for unsigned int to overflow in which case we report invalid number of 4K pages pool size. Switch to unsigned long long. We hit overflow in virNumaGetPages when doing: huge_page_sum += 1024 * page_size * page_avail; because although 'huge_page_sum' is an unsigned long long, the page_size and page_avail are both unsigned int, so the promotion to unsigned long long doesn't happen until the sum has been calculated, by which time we've already overflowed. Turning page_avail into a unsigned long long is not strictly needed until we need ability to represent more than 2^32 4k pages, which equates to 16 TB of RAM. That's not outside the realm of possibility, so makes sense that we change it to unsigned long long to avoid future problems. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
68 lines
2.5 KiB
C
68 lines
2.5 KiB
C
/*
|
|
* virnuma.h: helper APIs for managing numa
|
|
*
|
|
* Copyright (C) 2011-2014 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#ifndef __VIR_NUMA_H__
|
|
# define __VIR_NUMA_H__
|
|
|
|
# include "internal.h"
|
|
# include "virbitmap.h"
|
|
# include "virutil.h"
|
|
|
|
|
|
char *virNumaGetAutoPlacementAdvice(unsigned short vcups,
|
|
unsigned long long balloon);
|
|
|
|
int virNumaSetupMemoryPolicy(virDomainNumatuneMemMode mode,
|
|
virBitmapPtr nodeset);
|
|
|
|
virBitmapPtr virNumaGetHostMemoryNodeset(void);
|
|
bool virNumaNodesetIsAvailable(virBitmapPtr nodeset) ATTRIBUTE_NOINLINE;
|
|
bool virNumaIsAvailable(void) ATTRIBUTE_NOINLINE;
|
|
int virNumaGetMaxNode(void) ATTRIBUTE_NOINLINE;
|
|
bool virNumaNodeIsAvailable(int node) ATTRIBUTE_NOINLINE;
|
|
int virNumaGetDistances(int node,
|
|
int **distances,
|
|
int *ndistances) ATTRIBUTE_NOINLINE;
|
|
int virNumaGetNodeMemory(int node,
|
|
unsigned long long *memsize,
|
|
unsigned long long *memfree) ATTRIBUTE_NOINLINE;
|
|
|
|
unsigned int virNumaGetMaxCPUs(void);
|
|
|
|
int virNumaGetNodeCPUs(int node, virBitmapPtr *cpus) ATTRIBUTE_NOINLINE;
|
|
|
|
int virNumaGetPageInfo(int node,
|
|
unsigned int page_size,
|
|
unsigned long long huge_page_sum,
|
|
unsigned long long *page_avail,
|
|
unsigned long long *page_free);
|
|
int virNumaGetPages(int node,
|
|
unsigned int **pages_size,
|
|
unsigned long long **pages_avail,
|
|
unsigned long long **pages_free,
|
|
size_t *npages)
|
|
ATTRIBUTE_NONNULL(5) ATTRIBUTE_NOINLINE;
|
|
int virNumaSetPagePoolSize(int node,
|
|
unsigned int page_size,
|
|
unsigned long long page_count,
|
|
bool add);
|
|
#endif /* __VIR_NUMA_H__ */
|