mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-09-09 17:24:53 +00:00
5d7659027f
https://bugzilla.redhat.com/show_bug.cgi?id=1475250 It's possible to define and start a pool with a '.' in the name; however, when trying to add a volume to a domain using the storage pool source with a '.' in the storage pool name, the domain RNG validation fails because RNG uses 'genericName' which does not allow a '.' in the name. Domain XML def parsing has a virXMLValidateAgainstSchema which generates the error. The Storage Pool XML def parsing has no call to virXMLValidateAgainstSchema. The only Storage Pool name validation occurs in virStoragePoolDefParseXML to ensure the name doesn't have a '/' in it and in storagePoolDefineXML to call virXMLCheckIllegalChars using the same parameter "\n" as qemuDomainDefineXMLFlags would check after the RNG check could be succesful. In order to resolve this, create a poolName definition in storagecommon.rng that will mimic the domain name regex that disallows a newline character, but add the "/" in the exclude list. Then modify the pool and volume source name definitions to key off that poolName. |
||
|---|---|---|
| .. | ||
| basictypes.rng | ||
| capability.rng | ||
| cputypes.rng | ||
| domain.rng | ||
| domaincaps.rng | ||
| domaincommon.rng | ||
| domainsnapshot.rng | ||
| interface.rng | ||
| network.rng | ||
| networkcommon.rng | ||
| nodedev.rng | ||
| nwfilter.rng | ||
| secret.rng | ||
| storagecommon.rng | ||
| storagepool.rng | ||
| storagevol.rng | ||