libvirt/src
Peter Krempa 79bb49a83d qemu: Don't unref domain after exit from nested async job
In commit 540c339a25 the whole domain
reference counting was refactored in the qemu driver. Domain jobs now
don't need to reference the domain object as they now expect the
reference from the calling function.

However, the patch forgot to remove the unref call in case we exit the
monitor when we were acquiring a nested job. This caused the daemon to
crash on a subsequent access to the domain object once we've done an
operation requiring a nested job for a monitor access.

An easy reproducer case:

1) Start a vm with qcow disks
2) virsh snapshot-create-as DOMNAME
3) virsh dumpxml DOMNAME
4) daemon crashes in a semi-random spot while accessing a now-removed VM
object.

Fortunately, the commit wasn't released yet, so there are no security
implications.

Reported-by: Shanzi Yu <shyu@redhat.com>
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
2015-01-07 13:47:31 +01:00
..
access build: fix mingw printing of pid 2014-12-08 15:01:24 -07:00
bhyve drvbhyve: Automatically tear down guest domains on shutdown 2014-12-04 11:03:13 +01:00
conf conf: Don't format actual network definition in migratable XML 2015-01-07 13:11:02 +01:00
cpu cpu: fix possible crash in getModels 2014-12-03 19:17:05 +01:00
esx Replace virDomainFree with virObjectUnref 2014-12-02 11:03:40 -05:00
hyperv Replace virDomainFree with virObjectUnref 2014-12-02 11:03:40 -05:00
interface Replace virInterfaceFree with virObjectUnref 2014-12-02 11:03:41 -05:00
libxl libxl: Add support for parsing/formating Xen XL config 2015-01-03 22:41:26 -07:00
locking virstoragefile: Have virStorageFileResize use safezero 2014-12-16 13:11:35 -05:00
lxc LXC: honour network devices link state 2015-01-05 20:24:17 +01:00
network networkGetDHCPLeases: Remove unnecessary error reporting 2015-01-05 16:58:18 -07:00
node_device avoid using deprecated udev logging functions 2014-12-15 18:08:45 +00:00
nwfilter Replace virNWFilterFree with virObjectUnref 2014-12-02 11:03:41 -05:00
openvz Openvz --ipadd can be provided multiple times 2015-01-05 20:24:17 +01:00
parallels Parallels: Add VNC hostname setup 2015-01-07 09:58:18 +01:00
phyp Remove unnecessary curly brackets in rest of src/[o-u]*/ 2014-11-14 17:13:36 +01:00
qemu qemu: Don't unref domain after exit from nested async job 2015-01-07 13:47:31 +01:00
remote Replace virDomainSnapshotFree with virObjectUnref 2014-12-02 11:03:41 -05:00
rpc rpc: Report proper close reason 2014-12-08 13:03:49 +01:00
secret Replace virSecretFree with virObjectUnref 2014-12-02 11:03:41 -05:00
security Fix build on mingw 2014-12-11 11:13:43 +01:00
storage logical: Add "--type snapshot" to lvcreate command 2014-12-17 06:14:21 -05:00
test maint: forbid 'int foo = true' 2014-11-19 08:20:39 -07:00
uml Domain conf: allow more than one IP address for net devices 2015-01-05 20:24:04 +01:00
util virnetlink: fix build on non-Linux 2015-01-05 16:38:25 -07:00
vbox Report error if a driver can't handle multiple IP addresses 2015-01-05 20:24:18 +01:00
vmware Remove unnecessary curly brackets in rest of src/ 2014-11-14 17:13:36 +01:00
vmx Remove unnecessary curly brackets in src/vmx/vmx.c 2014-11-14 17:13:00 +01:00
xen video: cleanup usage of vram attribute and update documentation 2014-11-24 22:05:55 +01:00
xenapi Remove unnecessary curly brackets in rest of src/ 2014-11-14 17:13:36 +01:00
xenconfig Report error if a driver can't handle multiple IP addresses 2015-01-05 20:24:18 +01:00
check-aclperms.pl
check-aclrules.pl
check-driverimpls.pl
check-drivername.pl
check-symfile.pl
check-symsorting.pl
datatypes.c Remove unnecessary curly brackets in rest of src/[a-n]*/ 2014-11-14 17:13:36 +01:00
datatypes.h Move virDomainSnapshot related APIs out of libvirt.c 2014-10-24 15:59:22 +01:00
driver-hypervisor.h Implement public API for virDomainGetFSInfo 2014-11-24 10:02:08 -05:00
driver-interface.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-network.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-nodedev.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-nwfilter.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-secret.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-state.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-storage.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver-stream.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
driver.c Remove unnecessary curly brackets in rest of src/[a-n]*/ 2014-11-14 17:13:36 +01:00
driver.h Split driver.h into multiple parts 2014-10-23 11:10:05 +01:00
dtrace2systemtap.pl
fdstream.c Replace virStreamFree with virObjectUnref 2014-12-02 11:03:41 -05:00
fdstream.h fdstream: introduce virFDStreamOpenBlockDevice 2014-08-25 10:46:13 +04:00
gnutls_1_0_compat.h
internal.h internal: add macro to round value to the next closest power of 2 2014-11-24 22:05:55 +01:00
libvirt_atomic.syms
libvirt_daemon.syms
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_gnutls.syms
libvirt_internal.h Make virTypedParameterValidateSet non-static 2014-10-24 16:54:48 +01:00
libvirt_libssh2.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms Domain conf: allow more than one IP address for net devices 2015-01-05 20:24:04 +01:00
libvirt_probes.d
libvirt_public.syms Implement public API for virDomainGetFSInfo 2014-11-24 10:02:08 -05:00
libvirt_qemu_probes.d
libvirt_qemu.syms
libvirt_remote.syms remote: create virNetServerServiceNewFDOrUNIX() wrapper 2014-08-22 09:12:13 +02:00
libvirt_sasl.syms
libvirt_vmware.syms
libvirt_vmx.syms
libvirt_xenconfig.syms src/xenconfig: Xen-xl parser 2015-01-03 22:41:07 -07:00
libvirt-domain-snapshot.c Move virDomainSnapshot related APIs out of libvirt.c 2014-10-24 15:59:22 +01:00
libvirt-domain.c getstats: add new flag for block backing chain 2014-12-17 01:41:38 -07:00
libvirt-host.c Move virConnect/virNode related APIs out of libvirt.c 2014-10-24 16:59:58 +01:00
libvirt-interface.c Move virInterface related APIs out of libvirt.c 2014-10-24 16:08:28 +01:00
libvirt-lxc.c Remove unnecessary curly brackets in rest of src/[a-n]*/ 2014-11-14 17:13:36 +01:00
libvirt-lxc.pc.in Fix build-time pkg-config files in VPATH 2014-11-06 15:59:28 +01:00
libvirt-network.c Move virNetwork related APIs out of libvirt.c 2014-10-24 16:00:21 +01:00
libvirt-nodedev.c Remove unnecessary curly brackets in rest of src/[a-n]*/ 2014-11-14 17:13:36 +01:00
libvirt-nwfilter.c Move virNWFilter related APIs out of libvirt.c 2014-10-24 16:15:46 +01:00
libvirt-qemu.c
libvirt-qemu.pc.in Fix build-time pkg-config files in VPATH 2014-11-06 15:59:28 +01:00
libvirt-secret.c Move virSecret related APIs out of libvirt.c 2014-10-24 16:39:05 +01:00
libvirt-storage.c Remove unnecessary curly brackets in rest of src/[a-n]*/ 2014-11-14 17:13:36 +01:00
libvirt-stream.c Move virStream related APIs out of libvirt.c 2014-10-24 16:42:49 +01:00
libvirt.c libvirt.c: Move virDomainGetFSInfo to libvirt-domain.c 2014-12-02 13:49:50 +01:00
libvirt.conf
libvirt.pc.in Fix build-time pkg-config files in VPATH 2014-11-06 15:59:28 +01:00
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
Makefile.am src/Makefile.am: fix build breaker for xenconfig 2015-01-05 08:23:28 +01:00
nodeinfo.c nodeinfo: report error when failure in nodeSetMemoryParameters 2014-11-10 15:06:57 +01:00
nodeinfo.h nodeinfo: Implement nodeAllocPages 2014-09-25 10:24:45 +02:00
nodeinfopriv.h
qemu_protocol-structs
README
remote_protocol-structs remote: Implement the remote protocol for virDomainGetFSInfo 2014-11-24 10:04:32 -05:00
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * phyp/         - IBM Power Hypervisor using CLI tools over SSH
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * uml/          - User Mode Linux
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore
 * xenapi/       - Xen using libxenserver


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers.
The ESX, Hyper-V, Power Hypervisor, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories