mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-08 02:45:45 +00:00
f4e1ef9d39
It is documented that a command to run inside the container can be
passed with the -c arg.
virt-login-shell -c "ls -l /"
This fixes
commit 4feeb2d986
Author: Daniel P. Berrangé <berrange@redhat.com>
Date: Thu Aug 1 10:58:31 2019 +0100
tools: split virt-login-shell into two binaries
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
98 lines
3.0 KiB
C
98 lines
3.0 KiB
C
/*
|
|
* virt-login-shell.c: a setuid shell to connect to a container
|
|
*
|
|
* Copyright (C) 2019 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include <unistd.h>
|
|
#include <sys/types.h>
|
|
#include <assert.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <errno.h>
|
|
#include <string.h>
|
|
|
|
/*
|
|
* These gnulib files are used for their macros only,
|
|
* so don't introduce a link time dep, which we must avoid
|
|
*/
|
|
#include "gnulib/lib/configmake.h"
|
|
#include "gnulib/lib/intprops.h"
|
|
|
|
int main(int argc, char **argv) {
|
|
char uidstr[INT_BUFSIZE_BOUND(uid_t)];
|
|
char gidstr[INT_BUFSIZE_BOUND(gid_t)];
|
|
const char * newargv[6];
|
|
size_t nargs = 0;
|
|
char *newenv[] = {
|
|
NULL,
|
|
NULL,
|
|
};
|
|
char *term = getenv("TERM");
|
|
|
|
if (getuid() == 0 || getgid() == 0) {
|
|
fprintf(stderr, "%s: must not be run as root\n", argv[0]);
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
|
|
if (geteuid() != 0) {
|
|
fprintf(stderr, "%s: must be run as setuid root\n", argv[0]);
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
|
|
newargv[nargs++] = LIBEXECDIR "/virt-login-shell-helper";
|
|
if (argc == 3) {
|
|
if (strcmp(argv[1], "-c") != 0) {
|
|
fprintf(stderr, "%s: syntax: %s [-c CMDSTR]\n", argv[0], argv[0]);
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
newargv[nargs++] = argv[1];
|
|
newargv[nargs++] = argv[2];
|
|
} else if (argc != 1) {
|
|
fprintf(stderr, "%s: syntax: %s [-c CMDSTR]\n", argv[0], argv[0]);
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
newargv[nargs++] = uidstr;
|
|
newargv[nargs++] = gidstr;
|
|
newargv[nargs++] = NULL;
|
|
|
|
assert(nargs <= (sizeof(newargv)/sizeof(newargv[0])));
|
|
|
|
if (term &&
|
|
asprintf(&(newenv[0]), "TERM=%s", term) < 0) {
|
|
fprintf(stderr, "%s: cannot set TERM env variable: %s\n",
|
|
argv[0], strerror(errno));
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
|
|
assert(snprintf(uidstr, sizeof(uidstr), "%d", getuid()) < sizeof(uidstr));
|
|
assert(snprintf(gidstr, sizeof(gidstr), "%d", getgid()) < sizeof(gidstr));
|
|
|
|
if (setuid(0) < 0) {
|
|
fprintf(stderr, "%s: unable to set real UID to root: %s\n",
|
|
argv[0], strerror(errno));
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
|
|
execve(newargv[0], (char *const*)newargv, newenv);
|
|
fprintf(stderr, "%s: failed to run %s/virt-login-shell-helper: %s\n",
|
|
argv[0], LIBEXECDIR, strerror(errno));
|
|
exit(EXIT_FAILURE);
|
|
}
|