libvirt/src
Peter Krempa 7c1244f3a5 qemuMigrationDstPrecreateStorage: Fix and clarify logic
While it's intended that qemuMigrationDstPrecreateDisk is called with
any kind of the disk, the logic in qemuMigrationDstPrecreateStorage
which checks the existence of the image wouldn't properly handle e.g.
network backed disks, where it would attempt to use virFileExists() on
the disk's 'src->path'.

Fix the logic by first skipping disks not meant for migration, then do
the existence check only when 'disk->src' is local storage.

Since qemuMigrationDstPrecreateDisk has a debug statement there's no
need to have an extra one right before calling into it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-12-13 20:15:49 +01:00
..
access meson: Rename build_tests -> tests_enabled 2023-10-26 11:31:25 +02:00
admin admin: use g_auto for client RPC return parameters 2023-11-03 14:06:35 -04:00
bhyve bhyve: Add missing enum member to switch() in bhyveBuildSoundArgStr() 2023-11-25 08:35:00 +01:00
ch ch: Don't leak ch_driver->chCaps 2023-11-29 08:54:14 +01:00
conf virNodeDeviceCapStorageDefFormatBlocksize: Report sector size and count together 2023-12-07 16:42:32 +01:00
cpu lib: Replace qsort() with g_qsort_with_data() 2023-11-24 09:53:14 +01:00
cpu_map cpu_map: Add missing vmx features from MSR 0x491 2023-11-24 10:47:05 +01:00
esx esx: Move error messages onto a single line 2023-09-04 09:35:36 +02:00
hyperv meson: drop explicit python interpreter 2023-04-17 15:02:35 +02:00
hypervisor hypervisor: Move error messages onto a single line 2023-09-04 09:35:36 +02:00
interface systemd: Set service_extra_in/socket_extra_in everywhere 2023-10-25 12:19:32 +02:00
libxl systemd: Set service_extra_in/socket_extra_in everywhere 2023-10-25 12:19:32 +02:00
locking build: switch over to new rpc generator code 2023-11-03 14:06:35 -04:00
logging build: switch over to new rpc generator code 2023-11-03 14:06:35 -04:00
lxc lib: Replace qsort() with g_qsort_with_data() 2023-11-24 09:53:14 +01:00
network systemd: Set service_extra_in/socket_extra_in everywhere 2023-10-25 12:19:32 +02:00
node_device systemd: Set service_extra_in/socket_extra_in everywhere 2023-10-25 12:19:32 +02:00
nwfilter lib: Replace qsort() with g_qsort_with_data() 2023-11-24 09:53:14 +01:00
openvz openvz: Move error messages onto a single line 2023-09-04 09:35:36 +02:00
qemu qemuMigrationDstPrecreateStorage: Fix and clarify logic 2023-12-13 20:15:49 +01:00
remote remote: Fix cached hypervisor type 2023-12-08 08:18:39 -07:00
rpc rpc: don't try to spawn non-existant daemon 2023-12-06 16:45:46 +00:00
secret systemd: Set service_extra_in/socket_extra_in everywhere 2023-10-25 12:19:32 +02:00
security security_util: fix log in virSecurityMoveRememberedLabel 2023-12-07 11:31:30 +01:00
storage meson: Stop looking for scrub at build time 2023-12-05 11:50:42 +01:00
storage_file storage_file_probe: Treat qcow2 images with protocol drivers in backing store field as raw 2023-11-27 10:12:34 +01:00
test test_driver: Remove unused variable in testDomainAttachDeviceLiveAndConfig() 2023-12-04 09:50:17 +01:00
util network: convert virFileLinkPointsTo to return bool 2023-12-07 11:31:29 +01:00
vbox vbox_snapshot_conf: Keep indent in snapshot XML 2023-11-21 14:43:29 +01:00
vmware vmware: Move error messages onto a single line 2023-09-04 09:35:36 +02:00
vmx vmx: Move error messages onto a single line 2023-09-04 09:35:36 +02:00
vz systemd: Set service_extra_in/socket_extra_in everywhere 2023-10-25 12:19:32 +02:00
admin_protocol-structs
datatypes.c datatypes: Simplify error path of 'virGetDomain' 2023-01-06 15:27:52 +01:00
datatypes.h datatypes: Clean up whitespace in definition of struct _virConnect 2023-01-06 15:27:52 +01:00
driver-hypervisor.h lib: Introduce virDomainFDAssociate API 2023-01-09 14:59:42 +01:00
driver-interface.h
driver-network.h Adding Public Get and Set APIs for Network Metadata 2023-08-25 12:36:37 +02:00
driver-nodedev.h
driver-nwfilter.h
driver-secret.h
driver-state.h
driver-storage.h
driver-stream.h
driver.c Use 'virTypedParamListFetch' for extracting identity parameters list 2023-05-02 14:32:46 +02:00
driver.h
internal.h src: reject empty string for 'dname' in migrate APIs 2023-11-21 17:35:56 +00:00
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_internal.h
libvirt_libssh2.syms
libvirt_libssh.syms
libvirt_linux.syms
libvirt_logging.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms virfile: Drop virBuildPathInternal() 2023-10-17 08:32:20 +02:00
libvirt_probes.d
libvirt_public.syms Adding Public Get and Set APIs for Network Metadata 2023-08-25 12:36:37 +02:00
libvirt_qemu.syms
libvirt_remote.syms
libvirt_sasl.syms
libvirt_socket.syms
libvirt_vmware.syms
libvirt_vmx.syms
libvirt-domain-checkpoint.c Use 'libvirt.org' instead of 'www.libvirt.org' 2023-04-03 09:19:05 +02:00
libvirt-domain-snapshot.c api: document support for external snapshot deletion 2023-01-09 13:33:19 +01:00
libvirt-domain.c src: reject empty string for 'dname' in migrate APIs 2023-11-21 17:35:56 +00:00
libvirt-host.c src: Update format strings in translated messages 2023-04-01 11:40:35 +02:00
libvirt-interface.c
libvirt-lxc.c src: Update format strings in translated messages 2023-04-01 11:40:35 +02:00
libvirt-lxc.pc.in
libvirt-network.c src: Move error messages onto a single line 2023-09-04 09:35:36 +02:00
libvirt-nodedev.c src: Update format strings in translated messages 2023-04-01 11:40:35 +02:00
libvirt-nwfilter.c src: Update format strings in translated messages 2023-04-01 11:40:35 +02:00
libvirt-qemu.c src: Update format strings in translated messages 2023-04-01 11:40:35 +02:00
libvirt-qemu.pc.in
libvirt-secret.c src: Update format strings in translated messages 2023-04-01 11:40:35 +02:00
libvirt-storage.c src: Update format strings in translated messages 2023-04-01 11:40:35 +02:00
libvirt-stream.c
libvirt.c src: Detect close_range syscall during virGlobalInit() 2023-08-24 12:45:17 +02:00
libvirt.conf
libvirt.pc.in
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
meson.build build: suppress "ignoring duplicate libraries" warning on macOS 2023-11-03 15:56:37 -04:00
qemu_protocol-structs
README
remote_protocol-structs Define Network Metadata change event 2023-09-18 11:24:47 +02:00
virkeepaliveprotocol-structs
virnetprotocol-structs
virtd-admin.socket.in systemd: Improve and unify unit descriptions 2023-10-02 10:41:07 +02:00
virtd-ro.socket.in systemd: Improve and unify unit descriptions 2023-10-02 10:41:07 +02:00
virtd-tcp.socket.in systemd: Improve and unify unit descriptions 2023-10-02 10:41:07 +02:00
virtd-tls.socket.in systemd: Improve and unify unit descriptions 2023-10-02 10:41:07 +02:00
virtd.service.in systemd: Move Documentation lines 2023-10-02 10:41:07 +02:00
virtd.service.limitmemlock.extra.in systemd: Introduce systemd_service_limitmemlock_extra_in 2023-10-25 12:19:26 +02:00
virtd.service.limitnofile.extra.in systemd: Introduce systemd_service_limitnofile_extra_in 2023-10-25 12:19:21 +02:00
virtd.service.oomscoreadjust.extra.in systemd: Introduce systemd_service_oomscoreadjust_extra_in 2023-10-25 12:19:28 +02:00
virtd.service.tasksmax.extra.in systemd: Introduce systemd_service_tasksmax_extra_in 2023-10-25 12:19:24 +02:00
virtd.socket.in systemd: Improve and unify unit descriptions 2023-10-02 10:41:07 +02:00

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
The ESX, Hyper-V, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories