libvirt/src/vbox
John Ferlan 6cfd49bd4f vbox: Fix resource leak
The @disk was allocated, filled in, and consumed on the normal path,
but for error/cleanup paths it would be leaked.  Rename to newHardDisk
and manage properly.

Found by Coverity

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Katerina Koukiou <kkoukiou@redhat.com>
2018-06-11 18:33:13 -04:00
..
Makefile.inc.am make: split vbox driver build rules into vbox/Makefile.inc.am 2018-02-23 13:14:26 +00:00
README
vbox_CAPI_v4_0.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
vbox_CAPI_v4_1.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
vbox_CAPI_v4_2_20.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
vbox_CAPI_v4_2.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
vbox_CAPI_v4_3_4.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
vbox_CAPI_v4_3.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
vbox_CAPI_v5_0.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
vbox_CAPI_v5_1.h Remove backslash alignment attempts 2017-11-03 13:24:12 +01:00
vbox_CAPI_v5_2.h vbox: Add vbox 5.2 CAPI header file. 2017-11-09 17:09:41 -05:00
vbox_common.c vbox: Fix resource leak 2018-06-11 18:33:13 -04:00
vbox_common.h vbox: Add support for 5.2.x 2017-11-09 17:09:41 -05:00
vbox_driver.c driver: ensure URI path is non-NULL to simplify drivers 2018-04-12 16:52:02 +01:00
vbox_driver.h make: Drop building without driver modules 2017-07-27 12:00:35 +02:00
vbox_get_driver.h
vbox_glue.c
vbox_glue.h
vbox_MSCOMGlue.c
vbox_MSCOMGlue.h
vbox_network.c vbox: consolidate vbox IID structures. 2017-01-10 19:20:08 -05:00
vbox_snapshot_conf.c lib: Fix c99 style comments 2017-04-27 14:13:19 +02:00
vbox_snapshot_conf.h
vbox_storage.c vbox: Add support for 5.2.x 2017-11-09 17:09:41 -05:00
vbox_tmpl.c vbox: Add support for 5.2.x 2017-11-09 17:09:41 -05:00
vbox_uniformed_api.h vbox: Add support for 5.2.x 2017-11-09 17:09:41 -05:00
vbox_V4_0.c
vbox_V4_1.c
vbox_V4_2_20.c
vbox_V4_2.c
vbox_V4_3_4.c
vbox_V4_3.c
vbox_V5_0.c Add support for VirtualBox 5 2016-06-24 09:26:06 +02:00
vbox_V5_1.c Add vbox 5.1 driver file 2016-11-08 11:19:02 +00:00
vbox_V5_2.c vbox: Add support for 5.2.x 2017-11-09 17:09:41 -05:00
vbox_XPCOMCGlue.c maint: Remove not-so-much informative block commentaries 2017-10-18 13:38:59 +02:00
vbox_XPCOMCGlue.h vbox: remove SDK header files for vbox 3 and older. 2017-01-10 19:14:33 -05:00

    Licensing

Note that much of the vbox in this directory is LGPLv2-only.  Thus, it
cannot be linked into any software that also wants to use GPLv3+ code.
This readme file is:

Copyright (C) 2009, 2013 Red Hat, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.  This file is offered as-is,
without warranty of any kind.

    Explanation about the how multi-version support
    for VirtualBox libvirt driver is implemented.

Since VirtualBox adds multiple new features for each release, it is but
natural that the C API which VirtualBox exposes is volatile across
versions and thus needs a good mechanism to handle multiple versions
during runtime. The solution was something like this:

Firstly the file structure is as below:

vbox_CAPI_v2_2.h
vbox_XPCOMCGlue.h
vbox_XPCOMCGlue.c
These files are C API/glue code files directly taken from the
VirtualBox OSE source and is needed for C API to work as expected.

vbox_driver.h
vbox_driver.c
These files have the main logic for registering the virtualbox driver
with libvirt.

vbox_V2_2.c
The file which has version dependent changes and includes the template
file for given below for all of its functionality.

vbox_tmpl.c
The file contains all version specified codes. It implements the
vboxUniformedAPI for each vbox version.

vbox_common.c
The file implement the common driver, with the uniformed api which
defined in vbox_uniformed_api.h and implemented in vbox_tmpl.c

Now there would be a vbox_V*.c file (for eg: vbox_V2_2.c for V2.2) for
each major virtualbox version which would do some preprocessor magic
and include the template file (vbox_tmpl.c) in it for the functionality
it offers.