mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-11 12:25:52 +00:00
a678430492
When loading a latest caps for an arch for the first time the following occurs in testQemuInfoInitArgs(): - the caps file is located. It's not in the cache since it's the first time it's being read; - the cachecaps are retrieved using qemuTestParseCapabilitiesArch() and stored in the capscache; - FLAG_REAL_CAPS is set and regular flow continues. Loading the same latest caps for the second time the caps are loaded from the cache, skipping qemuTestParseCapabilitiesArch(). By skipping this function it means that it also skips virQEMUCapsLoadCache() and, more relevant to our case, virQEMUCapsInitHostCPUModel(). This function will use the current arch and cpuModel settings to write the qemuCaps that are being stored in the cache. And we're also setting FLAG_REAL_CAPS, meaning that we won't be updating the qemucaps host model via testUpdateQEMUCaps() as well. This has side-effects such as: - the first time the latest caps for an arch is loaded determines the cpuModel it'll use during the current qemuxml2argvtest run. For example, when running all tests, the first time the latest ppc64 caps are read is on "disk-floppy-pseries" test. Since the current host arch at this point is x86_64, the cpuModel that will be set for this capability is "core2duo"; - every other latest arch test will use the same hostCPU as the first one set since we read it from the cache after the first run. qemuTestSetHostCPU() makes no difference because we won't update the host model due to FLAG_REAL_CAPS being set. Using the previous example, every other latest ppc64 test that will be run will be using the "core2duo" cpuModel. Using fake capabilities (e.g. using DO_TEST()) prevents FLAG_REAL_CAPS to be set, meaning that the cpuModel will be updated using the current settings the test is being ran due to testUpdateQEMUCaps(). Note that not all latest caps arch tests care about the cpuModel being set to an unexpected default cpuModel. But some tests will care, e.g. "pseries-cpu-compat-power9", and changing it from DO_TEST() to DO_TEST_CAPS_ARCH_LATEST() will make it fail every time the "disk-floppy-pseries" is being ran first. One way of fixing it is to rethink all the existing logic, for example not setting FLAG_REAL_CAPS for latest arch tests. Another way is presented here. ARGS_CAPS_HOST_CPU_MODEL is a new testQemuInfo arg that allow us to set any specific host CPU model we want when running latest arch caps tests. This new arg can then be used when converting existing DO_TEST() testcases to DO_TEST_CAPS_ARCH_LATEST() that requires a specific host CPU setting to be successful, which we're going to do in the next patch with "pseries-cpu-compat-power9". Reviewed-by: Martin Kletzander <mkletzan@redhat.com> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
155 lines
4.4 KiB
C
155 lines
4.4 KiB
C
/*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#ifdef WITH_QEMU
|
|
|
|
# include "capabilities.h"
|
|
# include "virfilecache.h"
|
|
# include "domain_conf.h"
|
|
# include "qemu/qemu_capabilities.h"
|
|
# include "qemu/qemu_conf.h"
|
|
|
|
# define TEST_QEMU_CAPS_PATH abs_srcdir "/qemucapabilitiesdata"
|
|
|
|
enum {
|
|
GIC_NONE = 0,
|
|
GIC_V2,
|
|
GIC_V3,
|
|
GIC_BOTH,
|
|
};
|
|
|
|
typedef enum {
|
|
HOST_OS_LINUX = 0,
|
|
HOST_OS_MACOS,
|
|
} testQemuHostOS;
|
|
|
|
typedef enum {
|
|
ARG_QEMU_CAPS = QEMU_CAPS_LAST + 1,
|
|
ARG_GIC,
|
|
ARG_MIGRATE_FROM,
|
|
ARG_MIGRATE_FD,
|
|
ARG_FLAGS,
|
|
ARG_PARSEFLAGS,
|
|
ARG_CAPS_ARCH,
|
|
ARG_CAPS_VER,
|
|
ARG_CAPS_HOST_CPU_MODEL,
|
|
ARG_HOST_OS,
|
|
ARG_END,
|
|
} testQemuInfoArgName;
|
|
|
|
typedef enum {
|
|
FLAG_EXPECT_FAILURE = 1 << 0,
|
|
FLAG_EXPECT_PARSE_ERROR = 1 << 1,
|
|
FLAG_FIPS_HOST = 1 << 2, /* simulate host with FIPS mode enabled */
|
|
FLAG_REAL_CAPS = 1 << 3,
|
|
FLAG_SKIP_LEGACY_CPUS = 1 << 4,
|
|
FLAG_SLIRP_HELPER = 1 << 5,
|
|
} testQemuInfoFlags;
|
|
|
|
struct testQemuConf {
|
|
GHashTable *capscache;
|
|
GHashTable *capslatest;
|
|
GHashTable *qapiSchemaCache;
|
|
};
|
|
|
|
typedef enum {
|
|
QEMU_CPU_DEF_DEFAULT,
|
|
QEMU_CPU_DEF_HASWELL,
|
|
QEMU_CPU_DEF_POWER8,
|
|
QEMU_CPU_DEF_POWER9,
|
|
} qemuTestCPUDef;
|
|
|
|
struct testQemuArgs {
|
|
bool newargs;
|
|
virQEMUCaps *fakeCaps;
|
|
bool fakeCapsUsed;
|
|
char *capsver;
|
|
char *capsarch;
|
|
qemuTestCPUDef capsHostCPUModel;
|
|
int gic;
|
|
testQemuHostOS hostOS;
|
|
bool invalidarg;
|
|
};
|
|
|
|
struct testQemuInfo {
|
|
const char *name;
|
|
char *infile;
|
|
char *outfile;
|
|
char *errfile;
|
|
virQEMUCaps *qemuCaps;
|
|
const char *migrateFrom;
|
|
int migrateFd;
|
|
unsigned int flags;
|
|
unsigned int parseFlags;
|
|
virArch arch;
|
|
char *schemafile;
|
|
|
|
struct testQemuArgs args;
|
|
struct testQemuConf *conf;
|
|
};
|
|
|
|
virCaps *testQemuCapsInit(void);
|
|
virCaps *testQemuCapsInitMacOS(void);
|
|
virDomainXMLOption *testQemuXMLConfInit(void);
|
|
|
|
|
|
virQEMUCaps *qemuTestParseCapabilitiesArch(virArch arch,
|
|
const char *capsFile);
|
|
virCPUDef *qemuTestGetCPUDef(qemuTestCPUDef d);
|
|
|
|
void qemuTestSetHostArch(virQEMUDriver *driver,
|
|
virArch arch);
|
|
void qemuTestSetHostCPU(virQEMUDriver *driver,
|
|
virArch arch,
|
|
virCPUDef *cpu);
|
|
|
|
int qemuTestDriverInit(virQEMUDriver *driver);
|
|
void qemuTestDriverFree(virQEMUDriver *driver);
|
|
int qemuTestCapsCacheInsert(virFileCache *cache,
|
|
virQEMUCaps *caps);
|
|
int qemuTestCapsCacheInsertMacOS(virFileCache *cache,
|
|
virQEMUCaps *caps);
|
|
|
|
int testQemuCapsSetGIC(virQEMUCaps *qemuCaps,
|
|
int gic);
|
|
|
|
char *testQemuGetLatestCapsForArch(const char *arch,
|
|
const char *suffix);
|
|
GHashTable *testQemuGetLatestCaps(void);
|
|
|
|
typedef int (*testQemuCapsIterateCallback)(const char *inputDir,
|
|
const char *prefix,
|
|
const char *version,
|
|
const char *archName,
|
|
const char *suffix,
|
|
void *opaque);
|
|
int testQemuCapsIterate(const char *suffix,
|
|
testQemuCapsIterateCallback callback,
|
|
void *opaque);
|
|
|
|
void testQemuInfoSetArgs(struct testQemuInfo *info,
|
|
struct testQemuConf *conf,
|
|
...);
|
|
int testQemuInfoInitArgs(struct testQemuInfo *info);
|
|
void testQemuInfoClear(struct testQemuInfo *info);
|
|
|
|
int testQemuPrepareHostBackendChardevOne(virDomainDeviceDef *dev,
|
|
virDomainChrSourceDef *chardev,
|
|
void *opaque);
|
|
#endif
|