libvirt/src/conf/netdev_vlan_conf.c
Michal Privoznik 80178428ca conf: Move error messages onto a single line
Error messages are exempt from the 80 columns rule. Move them
onto one line.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
2023-09-04 09:35:35 +02:00

165 lines
5.1 KiB
C

/*
* Copyright (C) 2009-2014 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library. If not, see
* <http://www.gnu.org/licenses/>.
*/
#include <config.h>
#include "netdev_vlan_conf.h"
#include "virerror.h"
#include "viralloc.h"
#define VIR_FROM_THIS VIR_FROM_NONE
VIR_ENUM_IMPL(virNativeVlanMode,
VIR_NATIVE_VLAN_MODE_LAST,
"default", "tagged", "untagged",
);
int
virNetDevVlanParse(xmlNodePtr node, xmlXPathContextPtr ctxt, virNetDevVlan *def)
{
int ret = -1;
VIR_XPATH_NODE_AUTORESTORE(ctxt)
char *trunk = NULL;
xmlNodePtr *tagNodes = NULL;
int nTags;
size_t i;
ctxt->node = node;
nTags = virXPathNodeSet("./tag", ctxt, &tagNodes);
if (nTags < 0)
goto cleanup;
if (nTags == 0) {
virReportError(VIR_ERR_XML_ERROR, "%s",
_("missing tag id - each <vlan> must have at least one <tag id='n'/> subelement"));
goto cleanup;
}
def->tag = g_new0(unsigned int, nTags);
def->nativeMode = 0;
def->nativeTag = 0;
for (i = 0; i < nTags; i++) {
unsigned int nativeMode = 0;
int rc;
if (virXMLPropUInt(tagNodes[i], "id", 10, VIR_XML_PROP_REQUIRED,
&def->tag[i]) < 0)
goto cleanup;
if (def->tag[i] > 4095) {
virReportError(VIR_ERR_XML_ERROR,
_("vlan tag id %1$u too large (maximum 4095)"), def->tag[i]);
goto cleanup;
}
if ((rc = virXMLPropEnum(tagNodes[i], "nativeMode",
virNativeVlanModeTypeFromString,
VIR_XML_PROP_NONZERO, &nativeMode)) < 0)
return -1;
if (rc == 1) {
if (def->nativeMode != 0) {
virReportError(VIR_ERR_XML_ERROR, "%s",
_("duplicate native vlan setting"));
goto cleanup;
}
def->nativeMode = nativeMode;
def->nativeTag = def->tag[i];
}
}
def->nTags = nTags;
/* now that we know how many tags there are, look for an explicit
* trunk setting.
*/
if (nTags > 1)
def->trunk = true;
ctxt->node = node;
if ((trunk = virXPathString("string(./@trunk)", ctxt)) != NULL) {
def->trunk = STRCASEEQ(trunk, "yes");
if (!def->trunk) {
if (nTags > 1) {
virReportError(VIR_ERR_XML_ERROR,
_("invalid \"trunk='%1$s'\" in <vlan> - trunk='yes' is required for more than one vlan tag"),
trunk);
goto cleanup;
}
if (def->nativeMode != 0) {
virReportError(VIR_ERR_XML_ERROR, "%s",
_("invalid configuration in <vlan> - \"trunk='no'\" is not allowed with a native vlan id"));
goto cleanup;
}
/* allow (but discard) "trunk='no' if there is a single tag */
if (STRCASENEQ(trunk, "no")) {
virReportError(VIR_ERR_XML_ERROR,
_("invalid \"trunk='%1$s'\" in <vlan> - must be yes or no"),
trunk);
goto cleanup;
}
}
}
ret = 0;
cleanup:
VIR_FREE(tagNodes);
VIR_FREE(trunk);
if (ret < 0)
virNetDevVlanClear(def);
return ret;
}
int
virNetDevVlanFormat(const virNetDevVlan *def, virBuffer *buf)
{
size_t i;
if (!(def && def->nTags))
return 0;
if (!def->tag) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("missing vlan tag data"));
return -1;
}
virBufferAsprintf(buf, "<vlan%s>\n", def->trunk ? " trunk='yes'" : "");
virBufferAdjustIndent(buf, 2);
for (i = 0; i < def->nTags; i++) {
if (def->nativeMode != VIR_NATIVE_VLAN_MODE_DEFAULT &&
def->nativeTag == def->tag[i]) {
/* check the nativeMode in case we get <tag id='0'/>*/
const char *mode = virNativeVlanModeTypeToString(def->nativeMode);
if (!mode) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("Bad value for nativeMode"));
}
virBufferAsprintf(buf, "<tag id='%u' nativeMode='%s'/>\n",
def->tag[i], mode);
} else {
virBufferAsprintf(buf, "<tag id='%u'/>\n", def->tag[i]);
}
}
virBufferAdjustIndent(buf, -2);
virBufferAddLit(buf, "</vlan>\n");
return 0;
}