mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-09-25 00:45:46 +00:00
0117b7da68
We've been running into a lot of situations where virGetHostname() is returning "localhost", where a plain gethostname() would have returned the correct thing. This is because virGetHostname() is *always* trying to canonicalize the name returned from gethostname(), even when it doesn't have to. This patch changes virGetHostname so that if the value returned from gethostname() is already FQDN or localhost, it returns that string directly. If the value returned from gethostname() is a shortened hostname, then we try to canonicalize it. If that succeeds, we returned the canonicalized hostname. If that fails, and/or returns "localhost", then we just return the original string we got from gethostname() and hope for the best. Note that after this patch it is up to clients to check whether "localhost" is an allowed return value. The only place where it's currently not is in qemu migration. Signed-off-by: Chris Lalancette <clalance@redhat.com> |
||
|---|---|---|
| .. | ||
| libvirtd_qemu.aug | ||
| qemu_bridge_filter.c | ||
| qemu_bridge_filter.h | ||
| qemu_conf.c | ||
| qemu_conf.h | ||
| qemu_driver.c | ||
| qemu_driver.h | ||
| qemu_monitor_json.c | ||
| qemu_monitor_json.h | ||
| qemu_monitor_text.c | ||
| qemu_monitor_text.h | ||
| qemu_monitor.c | ||
| qemu_monitor.h | ||
| qemu_security_dac.c | ||
| qemu_security_dac.h | ||
| qemu_security_stacked.c | ||
| qemu_security_stacked.h | ||
| qemu.conf | ||
| test_libvirtd_qemu.aug | ||
| THREADS.txt | ||