mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-31 22:17:17 +00:00
ef1e024df8
A block commit moves data in the opposite direction of block pull. Block pull reduces the chain length by dropping backing files after data has been pulled into the top overlay, and is always safe; block commit reduces the chain length by dropping overlays after data has been committed into the backing file, and any files that depended on base but not on top are invalidated at any point where they have unallocated data that is now pointing to changed contents in base. Both directions are useful, however: a qcow2 layer that is more than 50% allocated will typically be faster with a pull operation, while a qcow2 layer with less than 50% allocation will be faster as a commit operation. Committing across multiple layers can be more efficient than repeatedly committing one layer at a time, but requires extra support from the hypervisor. This API matches Jeff Cody's proposed qemu command 'block-commit': https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02226.html Jeff's command is still in the works for qemu 1.3, and may gain further enhancements, such as the ability to control on-error handling (it will be comparable to the error handling Paolo is adding to 'drive-mirror', so a similar solution will be needed when I finally propose virDomainBlockCopy with more functionality than the basics supported by virDomainBlockRebase). However, even without qemu support, this API will be useful for _offline_ block commits, by wrapping qemu-img calls and turning them into a block job, so this API is worth committing now. For some examples of how this will be implemented, all starting with the chain: base <- snap1 <- snap2 <- active + These are equivalent: virDomainBlockCommit(dom, disk, NULL, NULL, 0, 0) virDomainBlockCommit(dom, disk, NULL, "active", 0, 0) virDomainBlockCommit(dom, disk, "base", NULL, 0, 0) virDomainBlockCommit(dom, disk, "base", "active", 0, 0) but cannot be implemented for online qemu with round 1 of Jeff's patches; and for offline images, it would require three back-to-back qemu-img invocations unless qemu-img is patched to allow more efficient multi-layer commits; the end result would be 'base' as the active disk with contents from all three other files, where 'snap1' and 'snap2' are invalid right away, and 'active' is invalid once any further changes to 'base' are made. + These are equivalent: virDomainBlockCommit(dom, disk, "snap2", NULL, 0, 0) virDomainBlockCommit(dom, disk, NULL, NULL, 0, _SHALLOW) they cannot be implemented for online qemu, but for offline, it is a matter of 'qemu-img commit active', so that 'snap2' is now the active disk with contents formerly in 'active'. + Similarly: virDomainBlockCommit(dom, disk, "snap2", NULL, 0, _DELETE) for an offline domain will merge 'active' into 'snap2', then delete 'active' to avoid leaving a potentially invalid file around. + This version: virDomainBlockCommit(dom, disk, NULL, "snap2", 0, _SHALLOW) can be implemented online with 'block-commit' passing a base of snap1 and a top of snap2; and can be implemented offline by 'qemu-img commit snap2' followed by 'qemu-img rebase -u -b snap1 active' * include/libvirt/libvirt.h.in (virDomainBlockCommit): New API. * src/libvirt.c (virDomainBlockCommit): Implement it. * src/libvirt_public.syms (LIBVIRT_0.10.2): Export it. * src/driver.h (virDrvDomainBlockCommit): New driver callback. * docs/apibuild.py (CParser.parseSignature): Add exception. |
||
|---|---|---|
| .. | ||
| api_extension | ||
| devhelp | ||
| html | ||
| internals | ||
| schemas | ||
| 32favicon.png | ||
| 404.html.in | ||
| api_extension.html.in | ||
| api.html.in | ||
| apibuild.py | ||
| apps.html.in | ||
| archdomain.html.in | ||
| architecture.fig | ||
| architecture.gif | ||
| architecture.html.in | ||
| archnetwork.html.in | ||
| archnode.html.in | ||
| archstorage.html.in | ||
| auth.html.in | ||
| bindings.html.in | ||
| bugs.html.in | ||
| compiling.html.in | ||
| contact.html.in | ||
| csharp.html.in | ||
| deployment.html.in | ||
| devguide.html.in | ||
| docs.html.in | ||
| downloads.html.in | ||
| drivers.html.in | ||
| drvesx.html.in | ||
| drvhyperv.html.in | ||
| drvlxc.html.in | ||
| drvopenvz.html.in | ||
| drvparallels.html.in | ||
| drvqemu.html.in | ||
| drvremote.html.in | ||
| drvtest.html.in | ||
| drvuml.html.in | ||
| drvvbox.html.in | ||
| drvvmware.html.in | ||
| drvxen.html.in | ||
| errors.html.in | ||
| et.png | ||
| firewall.html.in | ||
| footer_corner.png | ||
| footer_pattern.png | ||
| format.html.in | ||
| formatcaps.html.in | ||
| formatdomain.html.in | ||
| formatnetwork.html.in | ||
| formatnode.html.in | ||
| formatnwfilter.html.in | ||
| formatsecret.html.in | ||
| formatsnapshot.html.in | ||
| formatstorage.html.in | ||
| formatstorageencryption.html.in | ||
| generic.css | ||
| goals.html.in | ||
| hacking1.xsl | ||
| hacking2.xsl | ||
| hacking.html.in | ||
| hooks.html.in | ||
| hvsupport.pl | ||
| index.html.in | ||
| index.py | ||
| internals.html.in | ||
| intro.html.in | ||
| java.html.in | ||
| library.xen | ||
| libvirt-daemon-arch.fig | ||
| libvirt-daemon-arch.png | ||
| libvirt-driver-arch.fig | ||
| libvirt-driver-arch.png | ||
| libvirt-header-bg.png | ||
| libvirt-header-logo.png | ||
| libvirt-net-logical.fig | ||
| libvirt-net-logical.png | ||
| libvirt-net-physical.fig | ||
| libvirt-net-physical.png | ||
| libvirt-object-model.fig | ||
| libvirt-object-model.png | ||
| libvirt.css | ||
| libvirtLogo404.png | ||
| libvirtLogo.png | ||
| locking.html.in | ||
| logging.html.in | ||
| madeWith.png | ||
| main.css | ||
| Makefile.am | ||
| migration-managed-direct.fig | ||
| migration-managed-direct.png | ||
| migration-managed-p2p.fig | ||
| migration-managed-p2p.png | ||
| migration-native.fig | ||
| migration-native.png | ||
| migration-tunnel.fig | ||
| migration-tunnel.png | ||
| migration-unmanaged-direct.fig | ||
| migration-unmanaged-direct.png | ||
| migration.html.in | ||
| newapi.xsl | ||
| news.html.in | ||
| news.xsl | ||
| node.fig | ||
| node.gif | ||
| page.xsl | ||
| pending.html.in | ||
| php.html.in | ||
| python.html.in | ||
| relatedlinks.html.in | ||
| remote.html.in | ||
| search.php.code.in | ||
| search.php.in | ||
| site.xsl | ||
| sitemap.html.in | ||
| storage.html.in | ||
| structures.fig | ||
| subsite.xsl | ||
| testapi.html.in | ||
| testsuites.html.in | ||
| testtck.html.in | ||
| todo.cfg-example | ||
| todo.pl | ||
| uri.html.in | ||
| virshcmdref.html.in | ||
| windows.html.in | ||
| wrapstring.xsl | ||
