libvirt/src
Tim Wiederhake 879ecd602f virNWFilterSnoopState: Prevent mutex leak
virNWFilterDHCPSnoopShutdown would never destroy the mutexes created
in virNWFilterDHCPSnoopInit. Additionally, if in virNWFilterDHCPSnoopInit
the call to virMutexInitRecursive succeeds and the call to virMutexInit
fails, this would lead to either virNWFilterSnoopState.snoopLock being
initialized twice or virNWFilterSnoopState.activeLock destroyed without
being initialized first.

This enables a later patch to use virNWFilterDHCPSnoopShutdown as a
cleanup function safely, as it is a no-op if virNWFilterSnoopState was
not yet initialized.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2022-04-08 16:43:16 +02:00
..
access
admin admin: Use automatic mutex management 2022-03-16 10:54:30 +01:00
bhyve src: Initialize stack allocated virPCIDeviceAddress variables 2022-02-11 15:01:19 +01:00
ch drivers: Group global features together 2022-04-07 18:59:08 +02:00
conf virNWFilterObjListFree: Prevent null pointer derefernce 2022-04-08 16:43:16 +02:00
cpu lib: Almost eliminate use of virTristateBoolTypeFromString() 2022-01-21 16:42:13 +01:00
cpu_map
esx drivers: Group global features together 2022-04-07 18:59:08 +02:00
hyperv lib: Use g_clear_pointer() more 2022-02-08 08:42:07 +01:00
hypervisor hypervisor: Drop dead code in virDomainCgroupSetupGlobalCpuCgroup() 2022-04-07 12:12:05 +02:00
interface interface_backend_netcf: Use automatic mutex management 2022-04-05 15:59:08 +02:00
keycodemapdb@57ba70da53 keycodemapdb: Update git submodule 2022-03-22 18:00:40 +01:00
libxl drivers: Group global features together 2022-04-07 18:59:08 +02:00
locking util: drop support for obsolete systemd in RHEL-7 2022-02-17 12:35:42 +00:00
logging util: drop support for obsolete systemd in RHEL-7 2022-02-17 12:35:42 +00:00
lxc drivers: Group global features together 2022-04-07 18:59:08 +02:00
network drivers: Group global features together 2022-04-07 18:59:08 +02:00
node_device node_device_udev: Use automatic mutex management 2022-04-05 15:59:08 +02:00
nwfilter virNWFilterSnoopState: Prevent mutex leak 2022-04-08 16:43:16 +02:00
openvz drivers: Group global features together 2022-04-07 18:59:08 +02:00
qemu qemu: Drop QEMU_CAPS_INCOMING_DEFER 2022-04-08 10:27:02 +02:00
remote meson: Use dicts to initialize cfg_data objects 2022-04-01 15:33:19 +02:00
rpc virnetdaemon: Use automatic mutex management 2022-04-05 15:59:08 +02:00
secret secret: Use automatic mutex management 2022-02-11 16:03:18 +01:00
security meson: Use dicts to initialize cfg_data objects 2022-04-01 15:33:19 +02:00
storage storage: Use automatic mutex management 2022-03-16 10:54:42 +01:00
storage_file lib: Use g_clear_pointer() more 2022-02-08 08:42:07 +01:00
test conf: snapshot: Introduce 'manual' mode for snapshot of a disk 2022-03-22 10:32:43 +01:00
util virXMLFormatElement: Introduce virXMLFormatElementInternal 2022-04-08 09:32:47 +02:00
vbox vboxSetBootDeviceOrder: Remove whitespace alignment in VIR_DEBUG statements 2022-04-08 09:32:47 +02:00
vmware vmware: Use automatic mutex management 2022-02-11 16:03:12 +01:00
vmx lib: Use g_clear_pointer() more 2022-02-08 08:42:07 +01:00
vz conf: snapshot: Remove VIR_DOMAIN_SNAPSHOT_PARSE_DISKS flag 2022-03-11 13:55:50 +01:00
admin_protocol-structs
datatypes.c datatypes: Use automatic mutex management 2022-04-05 15:59:08 +02:00
datatypes.h
driver-hypervisor.h lib: Introduce 'virDomainQemuMonitorCommandWithFiles' 2022-03-01 13:29:49 +01:00
driver-interface.h
driver-network.h
driver-nodedev.h
driver-nwfilter.h
driver-secret.h
driver-state.h
driver-storage.h
driver-stream.h
driver.c virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_FD_PASSING 2022-02-17 13:15:46 +01:00
driver.h driver: Introduce global driver feature flag handling function 2022-02-17 13:15:46 +01:00
internal.h internal: Add CONCAT macro 2022-02-01 17:19:05 +01:00
libvirt_driver_modules.syms
libvirt_esx.syms
libvirt_internal.h
libvirt_libssh2.syms
libvirt_libssh.syms
libvirt_linux.syms
libvirt_logging.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms virXMLFormatElement: Introduce virXMLFormatElementInternal 2022-04-08 09:32:47 +02:00
libvirt_probes.d
libvirt_public.syms
libvirt_qemu.syms lib: Introduce 'virDomainQemuMonitorCommandWithFiles' 2022-03-01 13:29:49 +01:00
libvirt_remote.syms virnetmessage: Introduce virNetMessageClearFDs 2022-03-01 13:29:49 +01:00
libvirt_sasl.syms
libvirt_socket.syms
libvirt_vmware.syms
libvirt_vmx.syms
libvirt-domain-checkpoint.c checkpoint: Fix a typo of comments 2022-04-01 07:14:19 +02:00
libvirt-domain-snapshot.c include: define constants for resetting NVRAM state 2022-02-08 13:04:11 +00:00
libvirt-domain.c libvirt: introduce VIR_DOMAIN_DESTROY_REMOVE_LOGS flag 2022-04-06 10:48:04 +03:00
libvirt-host.c
libvirt-interface.c API: discourage usage of non-ListAll APIs 2021-08-24 16:26:55 +02:00
libvirt-lxc.c
libvirt-lxc.pc.in
libvirt-network.c
libvirt-nodedev.c
libvirt-nwfilter.c api: add virNWFilterBindingCreateFlags 2021-09-06 17:08:59 +02:00
libvirt-qemu.c libvirt-qemu: Fix capitalization of QEMU 2022-03-08 16:04:24 +01:00
libvirt-qemu.pc.in
libvirt-secret.c
libvirt-storage.c
libvirt-stream.c
libvirt.c
libvirt.conf
libvirt.pc.in
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
meson.build meson: Use dicts to initialize cfg_data objects 2022-04-01 15:33:19 +02:00
qemu_protocol-structs lib: Introduce 'virDomainQemuMonitorCommandWithFiles' 2022-03-01 13:29:49 +01:00
README
remote_protocol-structs
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
The ESX, Hyper-V, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories