mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-16 11:09:24 +00:00
ceb1019257
virDomainSnapshotFindByName(list, NULL) should return NULL, rather than the internal-use-only metaroot. Most existing callers pass in a non-NULL name; the few external callers that don't are immediately calling virDomainMomentSetParent (which indeed needs the metaroot rather than NULL if the parent name is NULL); but as the leaky abstraction is ugly, it is worth instead making virDomainMomentSetParent static and adding a new function for resolving the parent link of a brand new moment within its list. The existing external uses of virDomainMomentSetParent always succeed (either the new moment has parent_name of NULL to become a new root, or has parent_name set to a strdup of the previous current moment); hence, our new function does not need a return value (but it still has a VIR_WARN in case future uses break our assumptions about failure being impossible). Missed when commit02c4e24drefactored things to attempt to remove direct metaroot manipulations out of the qemu and test drivers into internal-only details, and made more obvious when commitdc8d3dc6factored it out into a separate file. Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
96 lines
4.3 KiB
C
96 lines
4.3 KiB
C
/*
|
|
* virdomainsnapshotobjlist.h: handle a tree of snapshot objects
|
|
* (derived from snapshot_conf.h)
|
|
*
|
|
* Copyright (C) 2006-2019 Red Hat, Inc.
|
|
* Copyright (C) 2006-2008 Daniel P. Berrange
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "internal.h"
|
|
#include "virdomainmomentobjlist.h"
|
|
#include "virbuffer.h"
|
|
|
|
virDomainSnapshotObjListPtr virDomainSnapshotObjListNew(void);
|
|
void virDomainSnapshotObjListFree(virDomainSnapshotObjListPtr snapshots);
|
|
|
|
virDomainMomentObjPtr virDomainSnapshotAssignDef(virDomainSnapshotObjListPtr snapshots,
|
|
virDomainSnapshotDefPtr def);
|
|
|
|
int virDomainSnapshotObjListGetNames(virDomainSnapshotObjListPtr snapshots,
|
|
virDomainMomentObjPtr from,
|
|
char **const names, int maxnames,
|
|
unsigned int flags);
|
|
int virDomainSnapshotObjListNum(virDomainSnapshotObjListPtr snapshots,
|
|
virDomainMomentObjPtr from,
|
|
unsigned int flags);
|
|
virDomainMomentObjPtr virDomainSnapshotFindByName(virDomainSnapshotObjListPtr snapshots,
|
|
const char *name);
|
|
virDomainMomentObjPtr virDomainSnapshotGetCurrent(virDomainSnapshotObjListPtr snapshots);
|
|
const char *virDomainSnapshotGetCurrentName(virDomainSnapshotObjListPtr snapshots);
|
|
void virDomainSnapshotSetCurrent(virDomainSnapshotObjListPtr snapshots,
|
|
virDomainMomentObjPtr snapshot);
|
|
bool virDomainSnapshotObjListRemove(virDomainSnapshotObjListPtr snapshots,
|
|
virDomainMomentObjPtr snapshot);
|
|
void virDomainSnapshotObjListRemoveAll(virDomainSnapshotObjListPtr snapshots);
|
|
int virDomainSnapshotForEach(virDomainSnapshotObjListPtr snapshots,
|
|
virHashIterator iter,
|
|
void *data);
|
|
void virDomainSnapshotLinkParent(virDomainSnapshotObjListPtr snapshots,
|
|
virDomainMomentObjPtr moment);
|
|
int virDomainSnapshotUpdateRelations(virDomainSnapshotObjListPtr snapshots);
|
|
int virDomainSnapshotCheckCycles(virDomainSnapshotObjListPtr snapshots,
|
|
virDomainSnapshotDefPtr def,
|
|
const char *domname);
|
|
|
|
#define VIR_DOMAIN_SNAPSHOT_FILTERS_METADATA \
|
|
(VIR_DOMAIN_SNAPSHOT_LIST_METADATA | \
|
|
VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA)
|
|
|
|
#define VIR_DOMAIN_SNAPSHOT_FILTERS_LEAVES \
|
|
(VIR_DOMAIN_SNAPSHOT_LIST_LEAVES | \
|
|
VIR_DOMAIN_SNAPSHOT_LIST_NO_LEAVES)
|
|
|
|
#define VIR_DOMAIN_SNAPSHOT_FILTERS_STATUS \
|
|
(VIR_DOMAIN_SNAPSHOT_LIST_INACTIVE | \
|
|
VIR_DOMAIN_SNAPSHOT_LIST_ACTIVE | \
|
|
VIR_DOMAIN_SNAPSHOT_LIST_DISK_ONLY)
|
|
|
|
#define VIR_DOMAIN_SNAPSHOT_FILTERS_LOCATION \
|
|
(VIR_DOMAIN_SNAPSHOT_LIST_INTERNAL | \
|
|
VIR_DOMAIN_SNAPSHOT_LIST_EXTERNAL)
|
|
|
|
#define VIR_DOMAIN_SNAPSHOT_FILTERS_ALL \
|
|
(VIR_DOMAIN_SNAPSHOT_FILTERS_METADATA | \
|
|
VIR_DOMAIN_SNAPSHOT_FILTERS_LEAVES | \
|
|
VIR_DOMAIN_SNAPSHOT_FILTERS_STATUS | \
|
|
VIR_DOMAIN_SNAPSHOT_FILTERS_LOCATION)
|
|
|
|
int virDomainListSnapshots(virDomainSnapshotObjListPtr snapshots,
|
|
virDomainMomentObjPtr from,
|
|
virDomainPtr dom,
|
|
virDomainSnapshotPtr **snaps,
|
|
unsigned int flags);
|
|
|
|
/* Access the snapshot-specific definition from a given list member. */
|
|
static inline virDomainSnapshotDefPtr
|
|
virDomainSnapshotObjGetDef(virDomainMomentObjPtr obj)
|
|
{
|
|
return (virDomainSnapshotDefPtr) obj->def;
|
|
}
|