mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-09-08 16:54:49 +00:00
89b6284fd9
I got confused when 'virsh domblkinfo dom disk' required the path to a disk (which can be ambiguous, since a single file can back multiple disks), rather than the unambiguous target device name that I was using in disk snapshots. So, in true developer fashion, I went for the best of both worlds - all interfaces that operate on a disk (aka block) now accept either the target name or the unambiguous path to the backing file used by the disk. * src/conf/domain_conf.h (virDomainDiskIndexByName): Add parameter. (virDomainDiskPathByName): New prototype. * src/libvirt_private.syms (domain_conf.h): Export it. * src/conf/domain_conf.c (virDomainDiskIndexByName): Also allow searching by path, and decide whether ambiguity is okay. (virDomainDiskPathByName): New function. (virDomainDiskRemoveByName, virDomainSnapshotAlignDisks): Update callers. * src/qemu/qemu_driver.c (qemudDomainBlockPeek) (qemuDomainAttachDeviceConfig, qemuDomainUpdateDeviceConfig) (qemuDomainGetBlockInfo, qemuDiskPathToAlias): Likewise. * src/qemu/qemu_process.c (qemuProcessFindDomainDiskByPath): Likewise. * src/libxl/libxl_driver.c (libxlDomainAttachDeviceDiskLive) (libxlDomainDetachDeviceDiskLive, libxlDomainAttachDeviceConfig) (libxlDomainUpdateDeviceConfig): Likewise. * src/uml/uml_driver.c (umlDomainBlockPeek): Likewise. * src/xen/xend_internal.c (xenDaemonDomainBlockPeek): Likewise. * docs/formatsnapshot.html.in: Update documentation. * tools/virsh.pod (domblkstat, domblkinfo): Likewise. * docs/schemas/domaincommon.rng (diskTarget): Tighten pattern on disk targets. * docs/schemas/domainsnapshot.rng (disksnapshot): Update to match. * tests/domainsnapshotxml2xmlin/disk_snapshot.xml: Update test. |
||
---|---|---|
.. | ||
capabilityschemadata | ||
commanddata | ||
confdata | ||
cputestdata | ||
domainschemadata | ||
domainsnapshotxml2xmlin | ||
domainsnapshotxml2xmlout | ||
interfaceschemadata | ||
networkxml2argvdata | ||
networkxml2xmlin | ||
networkxml2xmlout | ||
nodedevschemadata | ||
nodeinfodata | ||
nwfilterxml2xmlin | ||
nwfilterxml2xmlout | ||
qemuhelpdata | ||
qemuxml2argvdata | ||
qemuxml2xmloutdata | ||
sexpr2xmldata | ||
storagepoolxml2xmlin | ||
storagepoolxml2xmlout | ||
storagevolxml2xmlin | ||
storagevolxml2xmlout | ||
vmx2xmldata | ||
xencapsdata | ||
xmconfigdata | ||
xml2sexprdata | ||
xml2vmxdata | ||
.gitignore | ||
.valgrind.supp | ||
capabilityschematest | ||
commandhelper.c | ||
commandtest.c | ||
conftest.c | ||
cpuset | ||
cputest.c | ||
daemon-conf | ||
define-dev-segfault | ||
domainschematest | ||
domainsnapshotschematest | ||
esxutilstest.c | ||
eventtest.c | ||
hashdata.h | ||
hashtest.c | ||
int-overflow | ||
interfaceschematest | ||
interfacexml2xmltest.c | ||
jsontest.c | ||
libvirtd-fail | ||
libvirtd-pool | ||
Makefile.am | ||
networkschematest | ||
networkxml2argvtest.c | ||
networkxml2xmltest.c | ||
nodedevschematest | ||
nodedevxml2xmltest.c | ||
nodeinfotest.c | ||
nwfilterschematest | ||
nwfilterxml2xmltest.c | ||
object-locking.ml | ||
oomtrace.pl | ||
openvzutilstest.c | ||
openvzutilstest.conf | ||
pkix_asn1_tab.c | ||
qemuargv2xmltest.c | ||
qemuhelptest.c | ||
qemuxml2argvtest.c | ||
qemuxml2xmltest.c | ||
qparamtest.c | ||
read-bufsiz | ||
read-non-seekable | ||
reconnect.c | ||
schematestutils.sh | ||
seclabeltest.c | ||
sexpr2xmltest.c | ||
sockettest.c | ||
ssh.c | ||
start | ||
statstest.c | ||
storagepoolschematest | ||
storagepoolxml2xmltest.c | ||
storagevolschematest | ||
storagevolxml2xmltest.c | ||
test_conf.sh | ||
test-lib.sh | ||
testutils.c | ||
testutils.h | ||
testutilsqemu.c | ||
testutilsqemu.h | ||
testutilsxen.c | ||
testutilsxen.h | ||
undefine | ||
utiltest.c | ||
vcpupin | ||
virbuftest.c | ||
virnetmessagetest.c | ||
virnetsockettest.c | ||
virnettlscontexttest.c | ||
virsh-all | ||
virsh-optparse | ||
virsh-schedinfo | ||
virsh-synopsis | ||
virshtest.c | ||
virt-aa-helper-test | ||
vmx2xmltest.c | ||
xencapstest.c | ||
xmconfigtest.c | ||
xml2sexprtest.c | ||
xml2vmxtest.c |