libvirt/src
Marc Hartmayer cb09344a2c udevProcessCSS: Check if def->driver is non-NULL
Don't process subchannel devices where `def->driver` is not set. This
fixes the following segfault:

Thread 21 "nodedev-init" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x3ffb08fc910 (LWP 64303)]
(gdb) bt
 #0  0x000003fffd1272b4 in __strcmp_vx () at /lib64/libc.so.6
 #1  0x000003ffc260c3a8 in udevProcessCSS (device=0x3ff9018d130, def=0x3ff90194a90)
 #2  0x000003ffc260cb78 in udevGetDeviceDetails (device=0x3ff9018d130, def=0x3ff90194a90)
 #3  0x000003ffc260d126 in udevAddOneDevice (device=0x3ff9018d130)
 #4  0x000003ffc260d414 in udevProcessDeviceListEntry (udev=0x3ffa810d800, list_entry=0x3ff90001990)
 #5  0x000003ffc260d638 in udevEnumerateDevices (udev=0x3ffa810d800)
 #6  0x000003ffc260e08e in nodeStateInitializeEnumerate (opaque=0x3ffa810d800)
 #7  0x000003fffdaa14b6 in virThreadHelper (data=0x3ffa810df00)
 #8  0x000003fffc309ed6 in start_thread ()
 #9  0x000003fffd185e66 in thread_start ()
(gdb) p *def
$2 = {
  name = 0x0,
  sysfs_path = 0x3ff90198e80 "/sys/devices/css0/0.0.ff40",
  parent = 0x0,
  parent_sysfs_path = 0x0,
  parent_wwnn = 0x0,
  parent_wwpn = 0x0,
  parent_fabric_wwn = 0x0,
  driver = 0x0,
  devnode = 0x0,
  devlinks = 0x3ff90194670,
  caps = 0x3ff90194380
}

Fixes: 05e6cdafa6 ("node_device: detect CSS devices")
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
2020-09-22 10:57:06 +02:00
..
access access: ensure ACL files are rebuilt when protocol changes 2020-09-16 15:53:27 +01:00
admin lib: Prefer WITH_* prefix for #if conditionals 2020-09-02 10:28:10 +02:00
bhyve bhyve: soften requirements for slot 1 2020-09-21 20:03:45 +04:00
conf conf: add 'isa' controller type 2020-09-21 20:01:12 +04:00
cpu cpu: Replace VIR_FREE with g_free 2020-09-11 15:33:55 +02:00
cpu_map meson: src: install cpu_map data 2020-08-03 09:27:04 +02:00
esx esx: implement domainInterfaceAddresses 2020-09-15 10:00:48 +02:00
hyperv hyperv: fix the number of threads per core 2020-09-16 10:14:42 +02:00
hypervisor Remove redundant conditions 2020-08-03 15:19:28 +02:00
interface meson: src: add check-aclrules test 2020-08-03 09:27:05 +02:00
keycodemapdb@27acf0ef82 keycodemapdb: update submodule for win32 keycode fix 2020-05-07 12:18:29 +01:00
libxl libxl: use b_info->{acpi,acpi} when available 2020-09-18 08:51:47 +02:00
locking lib: Prefer WITH_* prefix for #if conditionals 2020-09-02 10:28:10 +02:00
logging logging: Replace virMutex with GMutex 2020-08-21 11:34:23 +01:00
lxc src/lxc/lxc_controller: convert to use GLib DBus 2020-09-17 18:20:05 +02:00
network src/network/bridge_driver: convert to use GLib DBus 2020-09-17 18:20:07 +02:00
node_device udevProcessCSS: Check if def->driver is non-NULL 2020-09-22 10:57:06 +02:00
nwfilter src/nwfilter/nwfilter_driver: convert to use GLib DBus 2020-09-17 18:20:28 +02:00
openvz Move declarations before statements 2020-08-25 19:03:11 +02:00
qemu conf: add 'isa' controller type 2020-09-21 20:01:12 +04:00
remote remote: slightly improve debugging of socket selection 2020-09-18 11:33:40 +01:00
rpc src/rpc/virnetdaemon: convert to use GLib DBus 2020-09-17 18:20:32 +02:00
secret meson: src: add check-aclrules test 2020-08-03 09:27:05 +02:00
security apparmor: allow libvirtd to call virtiofsd 2020-08-26 10:34:53 +02:00
storage storage: add support for qcow2 LUKS encryption 2020-09-18 11:22:28 +01:00
test test: fix emulator pin info in test driver 2020-08-08 11:07:15 +02:00
util util: fix non-null pointer parameter annotations 2020-09-21 14:26:12 +01:00
vbox conf: add 'isa' controller type 2020-09-21 20:01:12 +04:00
vmware meson: src: build libvirt.so library 2020-08-03 09:27:04 +02:00
vmx Prefer https: everywhere where possible 2020-09-01 21:58:46 +02:00
vz Move declarations before statements 2020-08-25 19:03:11 +02:00
admin_protocol-structs admin: Introduce virAdmServerUpdateTlsFiles 2020-03-13 17:07:32 +00:00
datatypes.c src: make virObjectUnref return void 2020-06-03 10:20:17 +01:00
datatypes.h define g_autoptr cleanup function for virNetworkDHCPLease 2020-07-20 19:08:07 -04:00
driver-hypervisor.h
driver-interface.h
driver-network.h
driver-nodedev.h
driver-nwfilter.h Use #pragma once in driver headers 2019-06-13 17:05:08 +02:00
driver-secret.h
driver-state.h libvirt: add stateShutdownPrepare/stateShutdownWait to drivers 2020-09-07 09:33:58 +03:00
driver-storage.h
driver-stream.h Use #pragma once in driver headers 2019-06-13 17:05:08 +02:00
driver.c util: use host module suffix when loading drivers 2020-08-26 10:30:18 +02:00
driver.h
internal.h lib: Prefer WITH_* prefix for #if conditionals 2020-09-02 10:28:10 +02:00
libvirt_driver_modules.syms util: create new virmodule.{c,h} files for dlopen support code 2018-05-03 12:47:43 +01:00
libvirt_esx.syms
libvirt_internal.h libvirt: add stateShutdownPrepare/stateShutdownWait to drivers 2020-09-07 09:33:58 +03:00
libvirt_libssh2.syms
libvirt_libssh.syms
libvirt_linux.syms
libvirt_lxc.syms
libvirt_openvz.syms
libvirt_private.syms drop libdbus from libvirt 2020-09-17 18:20:33 +02:00
libvirt_probes.d drop libdbus from libvirt 2020-09-17 18:20:33 +02:00
libvirt_public.syms
libvirt_qemu.syms
libvirt_remote.syms rpc: merge logic for generating remote SSH shell script 2020-09-09 16:46:22 +01:00
libvirt_sasl.syms virneserverclient: Introduce virNetServerClientHasSASLSession 2016-05-03 15:52:50 +02:00
libvirt_vmware.syms
libvirt_vmx.syms
libvirt-domain-checkpoint.c checkpoint: Mention that VIR_DOMAIN_CHECKPOINT_XML_SIZE is expensive and stale 2020-07-07 12:58:19 +02:00
libvirt-domain-snapshot.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-domain.c peer2peer migration: allow connecting to local sockets 2020-09-04 10:20:49 +02:00
libvirt-host.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-interface.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-lxc.c Substitute security_context_t with char * 2020-07-15 14:31:07 +02:00
libvirt-lxc.pc.in meson: remove '.libs' from all relevant paths 2020-08-03 09:27:00 +02:00
libvirt-network.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-nodedev.c virsh: nodedev: ability to filter CSS capabilities 2020-09-15 09:06:24 +02:00
libvirt-nwfilter.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-qemu.c
libvirt-qemu.pc.in meson: remove '.libs' from all relevant paths 2020-08-03 09:27:00 +02:00
libvirt-secret.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt-storage.c libvirt-storage: Document volume upload/download stream format 2020-08-24 13:32:53 +02:00
libvirt-stream.c src: don't include ref count in debug messages / probes 2020-06-03 10:20:17 +01:00
libvirt.c libvirt: add stateShutdownPrepare/stateShutdownWait to drivers 2020-09-07 09:33:58 +03:00
libvirt.conf
libvirt.pc.in meson: remove '.libs' from all relevant paths 2020-08-03 09:27:00 +02:00
lock_protocol-structs
lxc_monitor_protocol-structs
lxc_protocol-structs
meson.build drop libdbus from libvirt 2020-09-17 18:20:33 +02:00
qemu_protocol-structs
README Remove phyp driver 2019-12-20 12:25:42 -05:00
remote_protocol-structs
virkeepaliveprotocol-structs
virnetprotocol-structs

       libvirt library code README
       ===========================

The directory provides the bulk of the libvirt codebase. Everything
except for the libvirtd daemon and client tools. The build uses a
large number of libtool convenience libraries - one for each child
directory, and then links them together for the final libvirt.so,
although some bits get linked directly to libvirtd daemon instead.

The files directly in this directory are supporting the public API
entry points & data structures.

There are two core shared modules to be aware of:

 * util/  - a collection of shared APIs that can be used by any
            code. This directory is always in the include path
            for all things built

 * conf/  - APIs for parsing / manipulating all the official XML
            files used by the public API. This directory is only
            in the include path for driver implementation modules

 * vmx/   - VMware VMX config handling (used by esx/ and vmware/)


Then there are the hypervisor implementations:

 * bhyve         - bhyve - The BSD Hypervisor
 * esx/          - VMware ESX and GSX support using vSphere API over SOAP
 * hyperv/       - Microsoft Hyper-V support using WinRM
 * lxc/          - Linux Native Containers
 * openvz/       - OpenVZ containers using cli tools
 * qemu/         - QEMU / KVM using qemu CLI/monitor
 * remote/       - Generic libvirt native RPC client
 * test/         - A "mock" driver for testing
 * vbox/         - Virtual Box using native API
 * vmware/       - VMware Workstation and Player using the vmrun tool
 * xen/          - Xen using hypercalls, XenD SEXPR & XenStore


Finally some secondary drivers that are shared for several HVs.
Currently these are used by LXC, OpenVZ, QEMU and Xen drivers.
The ESX, Hyper-V, Remote, Test & VirtualBox drivers all
implement the secondary drivers directly

 * cpu/          - CPU feature management
 * interface/    - Host network interface management
 * network/      - Virtual NAT networking
 * nwfilter/     - Network traffic filtering rules
 * node_device/  - Host device enumeration
 * secret/       - Secret management
 * security/     - Mandatory access control drivers
 * storage/      - Storage management drivers


Since both the hypervisor and secondary drivers can be built as
dlopen()able modules, it is *FORBIDDEN* to have build dependencies
between these directories. Drivers are only allowed to depend on
the public API, and the internal APIs in the util/ and conf/
directories