Serge Hallyn 2879582847 Change locking for udev monitor and callbacks ...

We're seeing bugs apparently resulting from thread unsafety of
libpciaccess, such as
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/726099
To prevent those, as suggested by danpb on irc, move the
nodeDeviceLock(driverState) higher into the callers.  In
particular:

  udevDeviceMonitorStartup should hold the lock while calling
  udevEnumerateDevices(), and udevEventHandleCallback should hold it
  over its entire execution.

It's not clear to me whether it is ok to hold the
nodeDeviceLock while taking the virNodeDeviceObjLock(dev) on a
device.  If not, then the lock will need to be dropped around
the calling of udevSetupSystemDev(), and udevAddOneDevice()
may not actually be safe to call from higher layers with the
driverstate lock held.

libvirt 0.8.8 with this patch on it seems to work fine for me.
Assuming it looks ok and I haven't done anything obviously dumb,
I'll ask the bug submitters to try this patch.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>

2011-04-06 10:20:47 -06:00

..

node_device_driver.c

Create file in virFileWriteStr() if it doesn't exist

2010-12-03 08:08:22 -07:00

node_device_driver.h

Make check_fc_host() and check_vport_capable() usable as rvalues

2011-04-01 11:23:51 +02:00

node_device_hal.c

maint: kill all remaining uses of old DEBUG macro

2011-02-21 08:46:52 -07:00

node_device_hal.h

build: consistently indent preprocessor directives

2010-03-09 19:22:28 +01:00

node_device_linux_sysfs.c

bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-11-09 15:48:48 -05:00

node_device_udev.c

Change locking for udev monitor and callbacks

2011-04-06 10:20:47 -06:00

node_device_udev.h

maint: make Red Hat copyright notices consistent

2010-03-18 16:48:05 +01:00