mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-28 19:41:16 +00:00
Guest CPU definitions with mode='custom' and missing <vendor> are expected to run on a host CPU from any vendor as long as the required CPU model can be used as a guest CPU on the host. But even though no CPU vendor was explicitly requested we would sometimes force it due to a bug in virCPUUpdate and virCPUTranslate. The bug would effectively forbid cross vendor migrations even if they were previously working just fine. Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
135 lines
3.3 KiB
C
135 lines
3.3 KiB
C
/*
|
|
* cpu_arm.c: CPU driver for arm CPUs
|
|
*
|
|
* Copyright (C) 2013 Red Hat, Inc.
|
|
* Copyright (C) Canonical Ltd. 2012
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see
|
|
* <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Authors:
|
|
* Chuck Short <chuck.short@canonical.com>
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "viralloc.h"
|
|
#include "cpu.h"
|
|
#include "virstring.h"
|
|
|
|
#define VIR_FROM_THIS VIR_FROM_CPU
|
|
|
|
static const virArch archs[] = {
|
|
VIR_ARCH_ARMV6L,
|
|
VIR_ARCH_ARMV7B,
|
|
VIR_ARCH_ARMV7L,
|
|
VIR_ARCH_AARCH64,
|
|
};
|
|
|
|
static void
|
|
armDataFree(virCPUDataPtr data)
|
|
{
|
|
VIR_FREE(data);
|
|
}
|
|
|
|
|
|
static int
|
|
virCPUarmUpdate(virCPUDefPtr guest,
|
|
const virCPUDef *host)
|
|
{
|
|
int ret = -1;
|
|
virCPUDefPtr updated = NULL;
|
|
|
|
if (guest->mode != VIR_CPU_MODE_HOST_MODEL)
|
|
return 0;
|
|
|
|
if (!host) {
|
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
|
_("unknown host CPU model"));
|
|
goto cleanup;
|
|
}
|
|
|
|
if (!(updated = virCPUDefCopyWithoutModel(guest)))
|
|
goto cleanup;
|
|
|
|
updated->mode = VIR_CPU_MODE_CUSTOM;
|
|
if (virCPUDefCopyModel(updated, host, true) < 0)
|
|
goto cleanup;
|
|
|
|
virCPUDefStealModel(guest, updated, false);
|
|
guest->mode = VIR_CPU_MODE_CUSTOM;
|
|
guest->match = VIR_CPU_MATCH_EXACT;
|
|
ret = 0;
|
|
|
|
cleanup:
|
|
virCPUDefFree(updated);
|
|
return ret;
|
|
}
|
|
|
|
|
|
static virCPUCompareResult
|
|
armGuestData(virCPUDefPtr host ATTRIBUTE_UNUSED,
|
|
virCPUDefPtr guest ATTRIBUTE_UNUSED,
|
|
virCPUDataPtr *data ATTRIBUTE_UNUSED,
|
|
char **message ATTRIBUTE_UNUSED)
|
|
{
|
|
return VIR_CPU_COMPARE_IDENTICAL;
|
|
}
|
|
|
|
static virCPUDefPtr
|
|
armBaseline(virCPUDefPtr *cpus,
|
|
unsigned int ncpus ATTRIBUTE_UNUSED,
|
|
const char **models ATTRIBUTE_UNUSED,
|
|
unsigned int nmodels ATTRIBUTE_UNUSED,
|
|
unsigned int flags)
|
|
{
|
|
virCPUDefPtr cpu = NULL;
|
|
|
|
virCheckFlags(VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES |
|
|
VIR_CONNECT_BASELINE_CPU_MIGRATABLE, NULL);
|
|
|
|
if (VIR_ALLOC(cpu) < 0 ||
|
|
VIR_STRDUP(cpu->model, cpus[0]->model) < 0) {
|
|
virCPUDefFree(cpu);
|
|
return NULL;
|
|
}
|
|
|
|
cpu->type = VIR_CPU_TYPE_GUEST;
|
|
cpu->match = VIR_CPU_MATCH_EXACT;
|
|
|
|
return cpu;
|
|
}
|
|
|
|
static virCPUCompareResult
|
|
virCPUarmCompare(virCPUDefPtr host ATTRIBUTE_UNUSED,
|
|
virCPUDefPtr cpu ATTRIBUTE_UNUSED,
|
|
bool failMessages ATTRIBUTE_UNUSED)
|
|
{
|
|
return VIR_CPU_COMPARE_IDENTICAL;
|
|
}
|
|
|
|
struct cpuArchDriver cpuDriverArm = {
|
|
.name = "arm",
|
|
.arch = archs,
|
|
.narch = ARRAY_CARDINALITY(archs),
|
|
.compare = virCPUarmCompare,
|
|
.decode = NULL,
|
|
.encode = NULL,
|
|
.free = armDataFree,
|
|
.nodeData = NULL,
|
|
.guestData = armGuestData,
|
|
.baseline = armBaseline,
|
|
.update = virCPUarmUpdate,
|
|
};
|